Skip to content

Commit 48177ee

Browse files
committed
[ES|QL] Hide "not" operators from suggestions menu (elastic#216355)
## Summary in elastic#205565 we accidentally removed the behavior where we don't show `NOT LIKE` and `NOT RLIKE` in the suggestions list. We want to show these eventually but right now, it's broken behavior: https://github.com/user-attachments/assets/0a7f860d-3a12-49cf-94b3-668848cff6ae --------- Co-authored-by: Stratoula Kalafateli <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 4970bb9) # Conflicts: # src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/operators.ts
1 parent eff6a4e commit 48177ee

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/platform/packages/shared/kbn-esql-validation-autocomplete/scripts/generate_function_definitions.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ const enrichOperators = (
622622
const isInOperator = op.name === 'in' || op.name === 'not_in';
623623
const isLikeOperator = /like/i.test(op.name);
624624
const isNotOperator =
625-
op.name?.toLowerCase()?.startsWith('not_') && (isInOperator || isInOperator);
625+
op.name?.toLowerCase()?.startsWith('not_') && (isInOperator || isLikeOperator);
626626

627627
let signatures = op.signatures.map((s) => ({
628628
...s,
@@ -743,7 +743,7 @@ function printGeneratedFunctionsFile(
743743
name: '${functionName}',
744744
description: i18n.translate('kbn-esql-validation-autocomplete.esql.definitions.${name}', { defaultMessage: ${JSON.stringify(
745745
removeAsciiDocInternalCrossReferences(removeInlineAsciiDocLinks(description), functionNames)
746-
)} }),${functionDefinition.ignoreAsSuggestion ? 'ignoreAsSuggestion: true,\n' : ''}
746+
)} }),${functionDefinition.ignoreAsSuggestion ? 'ignoreAsSuggestion: true,' : ''}
747747
preview: ${functionDefinition.preview || 'false'},
748748
alias: ${alias ? `['${alias.join("', '")}']` : 'undefined'},
749749
signatures: ${JSON.stringify(signatures, null, 2)},

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/operators.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4513,6 +4513,7 @@ const notLikeDefinition: FunctionDefinition = {
45134513
}),
45144514
preview: false,
45154515
alias: undefined,
4516+
ignoreAsSuggestion: true,
45164517
signatures: [
45174518
{
45184519
params: [
@@ -4563,6 +4564,7 @@ const notRlikeDefinition: FunctionDefinition = {
45634564
}),
45644565
preview: false,
45654566
alias: undefined,
4567+
ignoreAsSuggestion: true,
45664568
signatures: [
45674569
{
45684570
params: [

0 commit comments

Comments
 (0)