Commit e1a59c1
committed
Get all sets when performing LTI date synchronization.
After the issue with the names and role service URL and realizing that
the `next` link needs to be utilized to get all names and roles from the
URL, I figured I had better check the spec for the `lineitems` URL used
for set date synchronization to see if it works the same, and in fact,
it does. See https://www.imsglobal.org/spec/lti-ags/v2p0#container-request-filters.
So this makes sure that all sets are obtained from the `lineitems` URL
in the same way.
In testing this with Canvas, it turns out that Canvas only sends 10 sets
at once. So if a course has more than 10 sets, then only 10 sets will
be retrieved from the lineitems URL in the first request. Note that
date synchronization will not necessarily fail though, as in the next
phase of the job queue task, requests are sent to the individual
lineitem URLs for the sets if the data was not received from the
lineitems URL for the set assuming that the lineitem URL for the set has
been obtained (webwork will have it if content item selection was used,
or if a user has entered the set directly from the LMS). However, this
results in extra network communication that is unnecessary.1 parent 838b4fc commit e1a59c1
1 file changed
Lines changed: 30 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
72 | 79 | | |
73 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
74 | 86 | | |
75 | 87 | | |
76 | 88 | | |
| |||
0 commit comments