Minor diagonal artifact in scanlines rendering

[lostromb]

When displaying an image with Integer scaling mode, "Enable Scanlines" ON and "Enable Scanlines Filter" OFF, there is a minor artifact running diagonally on the screen from the top left to the bottom right, shown here:

Turning on the filter fixes it, so I don't know if this is just a side effect of accurate emulation and the point of the filter is specifically to smooth this out. But it is a bit distracting against solid color backgrounds.

[lostromb]

Possibly a continuation of #100

[drhelius]

Yeah, I know. This is a side effect of nearest neighbor scaling together with scanlines trying to shade half the pixel. It will occur on odd scaling factors only, if you try an even scaling factor x2, x4, x6... it will probably be fine.

It is not really a bug, it's a limitation of the current way of doing scanlines and scaling using nearest, that's why I added scanline filtering but it adds some blur.

I'll think about it.

which platform is this picture from? Windows?

[lostromb]

This is on windows, yes. And you're right, it does change depending on the scale factor. 4x / 8x integer scaling appears to remove it entirely.