program: always fail settle pnl even if try_settle used (#1809)

* program: always fail settle pnl even if try_settle used

* CHANGELOG

* disable test

---------

Co-authored-by: wphan <[email protected]>

Author: crispheaney

CHANGELOG.md

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Breaking
 
+- program: have TRY_SETTLE pnl mode fail ([#1809](https://github.com/drift-labs/protocol-v2/pull/1809))
+
 ## [2.132.0] - 2025-08-06
 
 ### Features

programs/drift/src/state/settle_pnl_mode.rs

@@ -27,7 +27,7 @@ impl SettlePnlMode {
         );
         match self {
             SettlePnlMode::MustSettle => Err(error_code),
-            SettlePnlMode::TrySettle => Ok(()),
+            SettlePnlMode::TrySettle => Err(error_code),
         }
     }
 }

programs/drift/src/state/settle_pnl_mode/tests.rs

@@ -9,10 +9,10 @@ mod test {
         assert_eq!(result, Err(ErrorCode::DefaultError));
     }
 
-    #[test]
-    fn test_try_settle_returns_ok() {
-        let mode = SettlePnlMode::TrySettle;
-        let result = mode.result(ErrorCode::DefaultError, 0, "Try settle error");
-        assert_eq!(result, Ok(()));
-    }
+    // #[test]
+    // fn test_try_settle_returns_ok() {
+    //     let mode = SettlePnlMode::TrySettle;
+    //     let result = mode.result(ErrorCode::DefaultError, 0, "Try settle error");
+    //     assert_eq!(result, Ok(()));
+    // }
 }