Wphan/builder codes #1805
Wphan/builder codes #1805
Conversation
…n place_signed_msg_taker_order
programs/drift/src/state/builder.rs
Outdated
| pub authority: Pubkey, | ||
| pub total_referrer_rewards: i64, | ||
| pub total_builder_rewards: i64, | ||
| // might need padding for the len 4 bytes |
|
|
||
| #[account(zero_copy(unsafe))] | ||
| #[derive(Eq, PartialEq, Debug, Default)] | ||
| pub struct Builder { |
There was a problem hiding this comment.
is it less confusing if we call this referrer instead of builder?
| pub authority: Pubkey, | ||
| pub total_referrer_rewards: u64, | ||
| pub total_builder_rewards: u64, | ||
| pub padding: [u8; 18], |
| /// the index of the BuilderEscrow.approved_builders list, that this order's fee will settle to. Ignored | ||
| /// if bit_flag = Referral. | ||
| pub builder_idx: u8, | ||
| pub padding0: [u8; 7], |
There was a problem hiding this comment.
if you order the fields from largest size to smallest size, it's guranteed to minimize padding. I think if you move builder_idx to bottom, you can get rid of this extra padding
| /// Checks if the order can be merged with another order. Merged orders track cumulative fees accrued | ||
| /// and are settled together, making more efficient use of the orders list. | ||
| pub fn is_mergeable(&self, other: &BuilderOrder) -> bool { | ||
| !self.is_referral_order() |
There was a problem hiding this comment.
can referrer orders be merged together?
|
|
||
| /// Returns two distinct mutable references to orders by indices in one borrow of `self`. | ||
| /// Either index may be None. If both Some, they must be distinct. | ||
| pub fn get_two_orders_mut_by_indices( |
There was a problem hiding this comment.
gnarly, might be good to have unit test for this just to make sure each case works
| builder.authority = ctx.accounts.authority.key(); | ||
| builder.total_referrer_rewards = 0; | ||
| builder.total_builder_rewards = 0; | ||
| builder.padding = [0; 18]; |
| )] | ||
| pub builder_escrow: Box<Account<'info, BuilderEscrow>>, | ||
| /// CHECK: The auth owning this account, payer of builder/ref fees | ||
| pub authority: Signer<'info>, |
There was a problem hiding this comment.
idk if you need to force the authority to sign?
| ) -> Result<()> { | ||
| let state = &mut ctx.accounts.state; | ||
| if !state.builder_referral_enabled() { | ||
| if state.admin != ctx.accounts.payer.key() { |
There was a problem hiding this comment.
prob want this to be allowed to be hot wallet?
| )] | ||
| pub builder: AccountLoader<'info, Builder>, | ||
| /// CHECK: The builder and/or referrer authority, beneficiary of builder/ref fees | ||
| pub authority: Signer<'info>, |
| } else { | ||
| 0 | ||
| }; | ||
| let user_fee = fee.safe_add(builder_fee)?; |
There was a problem hiding this comment.
this might mess with accounting we do, also dont you already add it before calling update_quote_asset_and_break_even_amount, so it'd be double counting?
| unsafe impl Zeroable for MarketType {} | ||
| unsafe impl Pod for MarketType {} |
There was a problem hiding this comment.
Needed it for MarketType to work in zerocopy
No description provided.