Adds the ArrayAccess to Method Call set (#218)

* Adds the ArrayAccess set

* fixes

* More fixes

Author: peterfox

README.md

@@ -45,7 +45,7 @@ return RectorConfig::configure()
 | [LaravelSetList::LARAVEL_IF_HELPERS](https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel-if-helpers.php)                                                             | Replaces `abort()`, `report()`, `throw` statements inside conditions with `abort_if()`, `report_if()`, `throw_if()` function calls.<br/>https://laravel.com/docs/11.x/helpers#method-abort-if                                                    |
 | [LaravelSetList::LARAVEL_LEGACY_FACTORIES_TO_CLASSES](https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel-legacy-factories-to-classes.php)                           | Migrates Eloquent legacy model factories (with closures) into class based factories.<br/>https://laravel.com/docs/8.x/releases#model-factory-classes                                                                                             |
 | [LaravelSetList::LARAVEL_STATIC_TO_INJECTION](https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel-static-to-injection.php)                                           | Replaces Laravel's Facades with Dependency Injection.<br/>https://tomasvotruba.com/blog/2019/03/04/how-to-turn-laravel-from-static-to-dependency-injection-in-one-day/<br/>https://laravel.com/docs/11.x/facades#facades-vs-dependency-injection |
-
+| [LaravelSetList::LARAVEL_ARRAYACCESS_TO_METHOD_CALL](https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel-arrayaccess-to-method-call.php)                             | Converts uses of things like `$app['config']` to `$app->make('config')`.                                                                                                                                                                         |
 
 ## Contributors
 

config/sets/laravel-arrayaccess-to-method-call.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+use PHPStan\Type\ObjectType;
+use Rector\Config\RectorConfig;
+use Rector\Transform\Rector\ArrayDimFetch\ArrayDimFetchToMethodCallRector;
+use Rector\Transform\ValueObject\ArrayDimFetchToMethodCall;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../config.php');
+
+    $rectorConfig
+        ->ruleWithConfiguration(
+            ArrayDimFetchToMethodCallRector::class,
+            [
+                new ArrayDimFetchToMethodCall(
+                    new ObjectType('Illuminate\Foundation\Application'),
+                    'make',
+                ),
+                new ArrayDimFetchToMethodCall(
+                    new ObjectType('Illuminate\Config\Repository'),
+                    'get',
+                ),
+            ],
+        );
+};

src/Set/LaravelSetList.php

@@ -127,4 +127,9 @@ final class LaravelSetList implements SetListInterface
      * @var string
      */
     final public const LARAVEL_IF_HELPERS = __DIR__ . '/../../config/sets/laravel-if-helpers.php';
+
+    /**
+     * @var string
+     */
+    final public const LARAVEL_ARRAYACCESS_TO_METHOD_CALL = __DIR__ . '/../../config/sets/laravel-arrayaccess-to-method-call.php';
 }

tests/Sets/ArrayAccessToMethodCall/ArrayAccessToMethodCallTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Sets\ArrayAccessToMethodCall;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ArrayAccessToMethodCallTest extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Sets/ArrayAccessToMethodCall/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace RectorLaravel\Tests\Sets\ArrayAccessToMethodCall;
+
+$app = new \Illuminate\Foundation\Application();
+
+$service = $app[\Illuminate\Contracts\Events\Dispatcher::class];
+
+$config = new \Illuminate\Config\Repository();
+
+$name = $config['app.name'];
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Sets\ArrayAccessToMethodCall;
+
+$app = new \Illuminate\Foundation\Application();
+
+$service = $app->make(\Illuminate\Contracts\Events\Dispatcher::class);
+
+$config = new \Illuminate\Config\Repository();
+
+$name = $config->get('app.name');
+
+?>

tests/Sets/ArrayAccessToMethodCall/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../config/sets/laravel-arrayaccess-to-method-call.php');
+};