skip global check when checking for updates.

Author: bhouston

src/index.ts

@@ -23,7 +23,9 @@ const main = async () => {
 
   const updateMessage = await checkForUpdates();
   if (updateMessage) {
+    console.log();
     logger.info(updateMessage);
+    console.log();
   }
 
   // Error handling

src/test-eslint.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach } from "vitest";
 import { processStates, shellStartTool } from "./shellStart.js";
-import { MockLogger } from "../../utils/mockLogger.js";
+import { MockLogger } from "../../utils/mockLogger.test.js";
 import { shellMessageTool } from "./shellMessage.js";
 
 // Helper function to get instanceId from shellStart result

src/tools/system/shellMessage.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach } from "vitest";
 import { processStates, shellStartTool } from "./shellStart.js";
-import { MockLogger } from "../../utils/mockLogger.js";
+import { MockLogger } from "../../utils/mockLogger.test.js";
 
 describe("shellStartTool", () => {
   const mockLogger = new MockLogger();

src/tools/system/shellStart.test.ts

@@ -1,13 +1,13 @@
-import { Logger } from './logger.js';
+import { Logger } from "./logger.js";
 
 export class MockLogger extends Logger {
   constructor() {
-    super({ name: 'mock' });
+    super({ name: "mock" });
   }
 
   debug(..._messages: any[]): void {}
   verbose(..._messages: any[]): void {}
   info(..._messages: any[]): void {}
   warn(..._messages: any[]): void {}
   error(..._messages: any[]): void {}
-}
+}

src/utils/mockLogger.ts renamed to src/utils/mockLogger.test.ts

@@ -1,40 +1,16 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
 import {
-  isGlobalPackage,
   generateUpgradeMessage,
   fetchLatestVersion,
   getPackageInfo,
   checkForUpdates,
 } from "./versionCheck.js";
 
-// eslint-disable-next-line max-lines-per-function
 describe("versionCheck", () => {
-  describe("isGlobalPackage", () => {
-    const originalEnv = process.env;
-
-    beforeEach(() => {
-      process.env = { ...originalEnv };
-    });
-
-    afterEach(() => {
-      process.env = originalEnv;
-    });
-
-    it("returns true when npm_config_global is set", () => {
-      process.env.npm_config_global = "true";
-      expect(isGlobalPackage()).toBe(true);
-    });
-
-    it("returns false when npm_config_global is not set", () => {
-      delete process.env.npm_config_global;
-      expect(isGlobalPackage()).toBe(false);
-    });
-  });
-
   describe("generateUpgradeMessage", () => {
     it("returns null when versions are the same", () => {
       expect(generateUpgradeMessage("1.0.0", "1.0.0", "test-package")).toBe(
-        null,
+        null
       );
     });
 
@@ -67,7 +43,7 @@ describe("versionCheck", () => {
       const version = await fetchLatestVersion("test-package");
       expect(version).toBe("1.1.0");
       expect(mockFetch).toHaveBeenCalledWith(
-        "https://registry.npmjs.org/test-package/latest",
+        "https://registry.npmjs.org/test-package/latest"
       );
     });
 

src/utils/versionCheck.test.ts

@@ -1,4 +1,5 @@
 import { Logger } from "./logger.js";
+import chalk from "chalk";
 import { createRequire } from "module";
 import type { PackageJson } from "type-fest";
 
@@ -30,7 +31,7 @@ export function isGlobalPackage(): boolean {
  * Fetches the latest version of a package from npm registry
  */
 export async function fetchLatestVersion(
-  packageName: string,
+  packageName: string
 ): Promise<string | null> {
   try {
     const registryUrl = `https://registry.npmjs.org/${packageName}/latest`;
@@ -45,7 +46,7 @@ export async function fetchLatestVersion(
   } catch (error) {
     logger.warn(
       "Error fetching latest version:",
-      error instanceof Error ? error.message : String(error),
+      error instanceof Error ? error.message : String(error)
     );
     return null;
   }
@@ -57,10 +58,10 @@ export async function fetchLatestVersion(
 export function generateUpgradeMessage(
   currentVersion: string,
   latestVersion: string,
-  packageName: string,
+  packageName: string
 ): string | null {
   return currentVersion !== latestVersion
-    ? `Update available: ${currentVersion} → ${latestVersion}\nRun 'npm install -g ${packageName}' to update`
+    ? chalk.green(`  Update available: ${currentVersion} → ${latestVersion}\n  Run 'npm install -g ${packageName}' to update`)
     : null;
 }
 
@@ -72,11 +73,6 @@ export function generateUpgradeMessage(
  */
 export async function checkForUpdates(): Promise<string | null> {
   try {
-    // Only check for updates if running as global package
-    if (!isGlobalPackage()) {
-      return null;
-    }
-
     const { name: packageName, version: currentVersion } = getPackageInfo();
 
     if (!packageName || !currentVersion) {
@@ -96,7 +92,7 @@ export async function checkForUpdates(): Promise<string | null> {
     // Log error but don't throw to handle gracefully
     logger.warn(
       "Error checking for updates:",
-      error instanceof Error ? error.message : String(error),
+      error instanceof Error ? error.message : String(error)
     );
     return null;
   }