lint passes.

Author: bhouston

src/tools/browser/PageController.ts

@@ -5,6 +5,7 @@ import {
   BrowserError,
   BrowserErrorCode,
 } from './types.js';
+import { errorToString } from '../../utils/errorToString.js';
 
 export class PageController {
   constructor(private page: Page) {}
@@ -27,13 +28,14 @@ export class PageController {
     }
   }
 
-  private validateSelector(selector: string, type: SelectorType): void {
+  private validateSelector(selector: string, _type: SelectorType): void {
     if (!selector) {
       throw new BrowserError(
         'Invalid selector: empty string',
         BrowserErrorCode.SELECTOR_INVALID,
       );
     }
+    // TODO: Add more validation
   }
 
   async waitForSelector(
@@ -51,7 +53,7 @@ export class PageController {
       });
     } catch (error) {
       throw new BrowserError(
-        `Failed to find element: ${error}`,
+        `Failed to find element: ${errorToString(error)}`,
         BrowserErrorCode.ELEMENT_NOT_FOUND,
         error,
       );
@@ -67,7 +69,7 @@ export class PageController {
       await locator.click({ timeout: options.timeout });
     } catch (error) {
       throw new BrowserError(
-        `Failed to click element: ${error}`,
+        `Failed to click element: ${errorToString(error)}`,
         BrowserErrorCode.SELECTOR_ERROR,
         error,
       );
@@ -87,7 +89,7 @@ export class PageController {
       await locator.fill(text, { timeout: options.timeout });
     } catch (error) {
       throw new BrowserError(
-        `Failed to type text: ${error}`,
+        `Failed to type text: ${errorToString(error)}`,
         BrowserErrorCode.SELECTOR_ERROR,
         error,
       );
@@ -106,7 +108,7 @@ export class PageController {
       return (await locator.textContent()) || '';
     } catch (error) {
       throw new BrowserError(
-        `Failed to get text: ${error}`,
+        `Failed to get text: ${errorToString(error)}`,
         BrowserErrorCode.SELECTOR_ERROR,
         error,
       );

src/tools/browser/browseMessage.ts

@@ -2,6 +2,7 @@ import { Tool } from '../../core/types.js';
 import { z } from 'zod';
 import { zodToJsonSchema } from 'zod-to-json-schema';
 import { browserSessions, type BrowserAction, SelectorType } from './types.js';
+import { errorToString } from '../../utils/errorToString.js';
 
 // Schema for browser action
 const browserActionSchema = z
@@ -141,7 +142,7 @@ export const browseMessageTool: Tool<Parameters, ReturnType> = {
       logger.error('Browser action failed:', { error });
       return {
         status: 'error',
-        error: error instanceof Error ? error.message : String(error),
+        error: errorToString(error),
       };
     }
   },

src/tools/browser/browseStart.ts

@@ -4,6 +4,7 @@ import { zodToJsonSchema } from 'zod-to-json-schema';
 import { v4 as uuidv4 } from 'uuid';
 import { chromium } from '@playwright/test';
 import { browserSessions } from './types.js';
+import { errorToString } from '../../utils/errorToString.js';
 
 const parameterSchema = z.object({
   url: z.string().url().optional().describe('Initial URL to navigate to'),
@@ -91,11 +92,11 @@ export const browseStartTool: Tool<Parameters, ReturnType> = {
         content: content || undefined,
       };
     } catch (error) {
-      logger.error(`Failed to start browser: ${error}`);
+      logger.error(`Failed to start browser: ${errorToString(error)}`);
       return {
         instanceId: '',
         status: 'error',
-        error: error instanceof Error ? error.message : String(error),
+        error: errorToString(error),
       };
     }
   },

src/tools/system/shellStart.ts

@@ -169,7 +169,7 @@ export const shellStartTool: Tool<Parameters, ReturnType> = {
           stdout: '',
           stderr: '',
           exitCode: 1,
-          error: error instanceof Error ? error.message : String(error),
+          error: errorToString(error),
         });
       }
     });

src/utils/versionCheck.ts

@@ -7,6 +7,7 @@ import { getSettingsDir } from '../settings/settings.js';
 import * as fsPromises from 'fs/promises';
 import * as fs from 'fs';
 import * as semver from 'semver';
+import { errorToString } from './errorToString.js';
 
 const require = createRequire(import.meta.url);
 const logger = new Logger({ name: 'version-check' });
@@ -76,19 +77,13 @@ export async function checkForUpdates(): Promise<string | null> {
         return fsPromises.writeFile(versionFilePath, latestVersion, 'utf8');
       })
       .catch((error) => {
-        logger.warn(
-          'Error fetching latest version:',
-          error instanceof Error ? error.message : String(error),
-        );
+        logger.warn('Error fetching latest version:', errorToString(error));
       });
 
     return null;
   } catch (error) {
     // Log error but don't throw to handle gracefully
-    logger.warn(
-      'Error checking for updates:',
-      error instanceof Error ? error.message : String(error),
-    );
+    logger.warn('Error checking for updates:', errorToString(error));
     return null;
   }
 }