chore: fix broken tests

Author: bhouston

packages/agent/src/tools/browser/BrowserManager.ts

@@ -14,12 +14,12 @@ export class BrowserManager {
     headless: true,
     defaultTimeout: 30000,
   };
-  
+
   constructor() {
     // Store a reference to the instance globally for cleanup
     // This allows the CLI to access the instance for cleanup
     (globalThis as any).__BROWSER_MANAGER__ = this;
-    
+
     // Set up cleanup handlers for graceful shutdown
     this.setupGlobalCleanup();
   }
@@ -92,7 +92,7 @@ export class BrowserManager {
     // No need to add individual process handlers for each session
     // We'll handle all sessions in the global cleanup
   }
-  
+
   /**
    * Sets up global cleanup handlers for all browser sessions
    */
@@ -103,23 +103,28 @@ export class BrowserManager {
         console.error('Error closing browser sessions:', err);
       });
     });
-    
+
     // Use exit for synchronous cleanup (as a fallback)
     process.on('exit', () => {
       // Can only do synchronous operations here
       for (const session of this.sessions.values()) {
         try {
           // Attempt synchronous close - may not fully work
           session.browser.close();
+          // eslint-disable-next-line unused-imports/no-unused-vars
         } catch (e) {
           // Ignore errors during exit
         }
       }
     });
-    
+
     // Handle SIGINT (Ctrl+C)
     process.on('SIGINT', () => {
-      this.closeAllSessions().catch(() => {})
+      // eslint-disable-next-line promise/catch-or-return
+      this.closeAllSessions()
+        .catch(() => {
+          return false;
+        })
         .finally(() => {
           // Give a moment for cleanup to complete
           setTimeout(() => process.exit(0), 500);

packages/cli/src/commands/config.ts

@@ -21,9 +21,9 @@ export interface ConfigOptions extends SharedOptions {
   command: 'get' | 'set' | 'list' | 'clear';
   key?: string;
   value?: string;
-  all: boolean;  // Has default value in builder, so it's always defined
-  global: boolean;  // Has default value in builder, so it's always defined
-  verbose: boolean;  // Has default value in builder, so it's always defined
+  all: boolean; // Has default value in builder, so it's always defined
+  global: boolean; // Has default value in builder, so it's always defined
+  verbose: boolean; // Has default value in builder, so it's always defined
 }
 
 export const command: CommandModule<SharedOptions, ConfigOptions> = {
@@ -134,10 +134,9 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
       logger.info('Current configuration:');
 
       // Show config file locations
-      const {
-        getSettingsDir,
-        getProjectSettingsDir,
-      } = require('../settings/settings.js');
+      const { getSettingsDir, getProjectSettingsDir } = await import(
+        '../settings/settings.js'
+      );
       const globalConfigPath = path.join(getSettingsDir(), 'config.json');
       const projectDir = getProjectSettingsDir();
       const projectConfigPath = projectDir

packages/cli/src/index.ts

@@ -83,10 +83,10 @@ await main()
   .finally(async () => {
     // Report timings if profiling is enabled
     await reportTimings();
-    
+
     // Clean up all resources before exit
     await cleanupResources();
-    
+
     // Setup a force exit as a failsafe
     // This ensures the process will exit even if there are lingering handles
     setupForceExit(5000);

packages/cli/src/utils/cleanup.ts

@@ -6,19 +6,21 @@ import { BrowserManager, processStates } from 'mycoder-agent';
  */
 export async function cleanupResources(): Promise<void> {
   console.log('Cleaning up resources before exit...');
-  
+
   // 1. Clean up browser sessions
   try {
     // Get the BrowserManager instance - this is a singleton
-    const browserManager = (globalThis as any).__BROWSER_MANAGER__ as BrowserManager | undefined;
+    const browserManager = (globalThis as any).__BROWSER_MANAGER__ as
+      | BrowserManager
+      | undefined;
     if (browserManager) {
       console.log('Closing all browser sessions...');
       await browserManager.closeAllSessions();
     }
   } catch (error) {
     console.error('Error closing browser sessions:', error);
   }
-  
+
   // 2. Clean up shell processes
   try {
     if (processStates.size > 0) {
@@ -34,6 +36,7 @@ export async function cleanupResources(): Promise<void> {
                 if (!state.state.completed) {
                   state.process.kill('SIGKILL');
                 }
+                // eslint-disable-next-line unused-imports/no-unused-vars
               } catch (e) {
                 // Ignore errors on forced kill
               }
@@ -47,10 +50,10 @@ export async function cleanupResources(): Promise<void> {
   } catch (error) {
     console.error('Error terminating shell processes:', error);
   }
-  
+
   // 3. Give async operations a moment to complete
   await new Promise((resolve) => setTimeout(resolve, 1000));
-  
+
   console.log('Cleanup completed');
 }
 
@@ -63,4 +66,4 @@ export function setupForceExit(timeoutMs = 5000): void {
     console.log(`Forcing exit after ${timeoutMs}ms timeout`);
     process.exit(0);
   }, timeoutMs);
-}
+}

packages/cli/tests/commands/config.test.ts

@@ -8,6 +8,7 @@ import {
   updateConfig,
   getConfigAtLevel,
   clearConfigAtLevel,
+  clearConfigKey,
 } from '../../src/settings/config.js';
 
 // Mock dependencies
@@ -17,6 +18,7 @@ vi.mock('../../src/settings/config.js', () => ({
   updateConfig: vi.fn(),
   getConfigAtLevel: vi.fn(),
   clearConfigAtLevel: vi.fn(),
+  clearConfigKey: vi.fn(),
   ConfigLevel: {
     DEFAULT: 'default',
     GLOBAL: 'global',
@@ -76,6 +78,8 @@ describe('Config Command', () => {
       ...config,
     }));
     vi.mocked(getConfigAtLevel).mockReturnValue({});
+    vi.mocked(clearConfigKey).mockImplementation(() => ({ githubMode: false }));
+    vi.mocked(clearConfigKey).mockImplementation(() => ({ githubMode: false }));
   });
 
   afterEach(() => {