Skip to content

file_mode and dir_mode do not correctly handle empty string case #24

@jayqi

Description

@jayqi

If you do something like:

REPRO_ZIPFILE_DIR_MODE= python

Then you get

os.environ.get("REPRO_ZIPFILE_DIR_MODE", None)
#> ''

We should really be checking the truthiness of the value. Even if it were being entered as 0 or 000, it would be a string and still be truthy.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions