Using Promise.all inside transactions

[lucaspiresfernandes]

I often use Promise.all inside batch select queries. Is it possible to do the same using write transactions? Like this:

await db.transaction((tx) =>
      Promise.all([
        tx.delete(CharacterDetail).where(eq(CharacterDetail.characterId, characterId)),
        tx.delete(CharacterVital).where(eq(CharacterVital.characterId, characterId)),
        tx.delete(CharacterCondition).where(eq(CharacterCondition.characterId, characterId)),
        tx.delete(CharacterTest).where(eq(CharacterTest.characterId, characterId)),
        tx.delete(CharacterItem).where(eq(CharacterItem.characterId, characterId)),
        tx
          .delete(CharacterItemDescriptor)
          .where(eq(CharacterItemDescriptor.characterId, characterId)),
        tx.delete(Character).where(and(eq(Character.id, characterId))),
      ]),
    );

Is there any problem by doing this? Does it run on parallel? Is it faster?

[brijmcq]

@lucaspiresfernandes Hey there! I'm curious, how did it work out for you? I think the issue with your code is that when something goes wrong with one of your promises, it won't roll back properly because it won't throw an error here. You should rewrite this to use Promise.allSettled and rethrow the error.