Fix unused variable warnings (#2385)

Author: sjanel

lib/inc/drogon/HttpResponse.h

@@ -39,7 +39,7 @@ using HttpResponsePtr = std::shared_ptr<HttpResponse>;
  * type object. Users must specialize the template for a particular type.
  */
 template <typename T>
-T fromResponse(const HttpResponse &resp)
+T fromResponse(const HttpResponse &)
 {
     LOG_ERROR
         << "You must specialize the fromResponse template for the type of "

lib/inc/drogon/HttpViewData.h

@@ -88,9 +88,9 @@ class DROGON_EXPORT HttpViewData
                                 backup_ap);
         va_end(backup_ap);
         if ((result >= 0) &&
-            ((std::string::size_type)result < strBuffer.size()))
+            (static_cast<std::string::size_type>(result) < strBuffer.size()))
         {
-            strBuffer.resize(result);
+            strBuffer.resize(static_cast<std::string::size_type>(result));
         }
         else
         {

lib/src/HttpClientImpl.cc

@@ -549,7 +549,6 @@ void HttpClientImpl::handleResponse(
     const trantor::TcpConnectionPtr &connPtr)
 {
     assert(!pipeliningCallbacks_.empty());
-    auto &type = resp->getHeaderBy("content-type");
     auto &coding = resp->getHeaderBy("content-encoding");
     if (coding == "gzip")
     {

lib/src/HttpControllersRouter.h

@@ -27,7 +27,7 @@ namespace drogon
 {
 class HttpControllerBinder;
 class HttpSimpleControllerBinder;
-class WebsocketControllerBinder;
+struct WebsocketControllerBinder;
 
 class HttpControllersRouter : public trantor::NonCopyable
 {

lib/src/HttpResponseImpl.cc

@@ -222,7 +222,6 @@ HttpResponsePtr HttpResponse::newFileResponse(
     // Check for type and assign proper content type in header
     if (!typeString.empty())
     {
-        // auto contentType = type;
         if (type == CT_NONE)
             type = parseContentType(typeString);
         if (type == CT_NONE)
@@ -344,7 +343,6 @@ HttpResponsePtr HttpResponse::newFileResponse(
         if (!typeString.empty())
         {
             auto r = static_cast<HttpResponse *>(resp.get());
-            // auto contentType = type;
             if (type == CT_NONE)
                 type = parseContentType(typeString);
             if (type == CT_NONE)
@@ -368,7 +366,6 @@ HttpResponsePtr HttpResponse::newFileResponse(
         else
         {
             auto r = static_cast<HttpResponse *>(resp.get());
-            // auto contentType = type;
             if (type == CT_NONE)
                 type = parseContentType(typeString);
             if (type == CT_NONE)
@@ -423,7 +420,6 @@ HttpResponsePtr HttpResponse::newStreamResponse(
         if (!typeString.empty())
         {
             auto r = static_cast<HttpResponse *>(resp.get());
-            auto contentType = type;
             if (type == CT_NONE)
                 type = parseContentType(typeString);
             if (type == CT_NONE)
@@ -443,7 +439,6 @@ HttpResponsePtr HttpResponse::newStreamResponse(
         else
         {
             auto r = static_cast<HttpResponse *>(resp.get());
-            auto contentType = type;
             if (type == CT_NONE)
                 type = parseContentType(typeString);
             if (type == CT_NONE)

lib/src/SlidingWindowRateLimiter.cc

@@ -34,7 +34,6 @@ bool SlidingWindowRateLimiter::isAllowed()
         auto duration =
             std::chrono::duration_cast<std::chrono::duration<double>>(
                 unitStartTime_ - lastTime_);
-        auto startTime = lastTime_;
         if (duration >= timeUnit_)
         {
             previousRequests_ = 0;

lib/src/Utilities.cc

@@ -1039,7 +1039,6 @@ void dateToCustomFormattedString(const std::string &fmtStr,
                                  const trantor::Date &date)
 {
     auto nowSecond = date.microSecondsSinceEpoch() / MICRO_SECONDS_PRE_SEC;
-    time_t seconds = static_cast<time_t>(nowSecond);
     struct tm tm_LValue = date.tmStruct();
     std::stringstream Out;
     Out.imbue(std::locale{"C"});
@@ -1318,7 +1317,7 @@ const size_t fixedRandomNumber = []() {
     utils::secureRandomBytes(&res, sizeof(res));
     return res;
 }();
-}
+}  // namespace internal
 
 }  // namespace utils
 }  // namespace drogon