Make quit function thread safe (#2247)

Demilivor · web-flow · commit f5de41f5d7c3 · 2025-02-02T22:22:17.000+08:00
diff --git a/lib/src/HttpAppFrameworkImpl.cc b/lib/src/HttpAppFrameworkImpl.cc
@@ -1033,7 +1033,7 @@ HttpAppFramework &HttpAppFrameworkImpl::createRedisClient(
 
 void HttpAppFrameworkImpl::quit()
 {
-    if (getLoop()->isRunning())
+    if (getLoop()->isRunning() && running_.exchange(false))
     {
         getLoop()->queueInLoop([this]() {
             // Release members in the reverse order of initialization
@@ -1044,7 +1044,6 @@ void HttpAppFrameworkImpl::quit()
             pluginsManagerPtr_.reset();
             redisClientManagerPtr_.reset();
             dbClientManagerPtr_.reset();
-            running_ = false;
             getLoop()->quit();
             for (trantor::EventLoop *loop : ioLoopThreadPool_->getLoops())
             {

Original file line number	Diff line number	Diff line change
`@@ -1033,7 +1033,7 @@ HttpAppFramework &HttpAppFrameworkImpl::createRedisClient(`
`1033`	`1033`
`1034`	`1034`	`void HttpAppFrameworkImpl::quit()`
`1035`	`1035`	`{`
`1036`		`- if (getLoop()->isRunning())`
	`1036`	`+ if (getLoop()->isRunning() && running_.exchange(false))`
`1037`	`1037`	`{`
`1038`	`1038`	`getLoop()->queueInLoop([this]() {`
`1039`	`1039`	`// Release members in the reverse order of initialization`
`@@ -1044,7 +1044,6 @@ void HttpAppFrameworkImpl::quit()`
`1044`	`1044`	`pluginsManagerPtr_.reset();`
`1045`	`1045`	`redisClientManagerPtr_.reset();`
`1046`	`1046`	`dbClientManagerPtr_.reset();`
`1047`		`- running_ = false;`
`1048`	`1047`	`getLoop()->quit();`
`1049`	`1048`	`for (trantor::EventLoop *loop : ioLoopThreadPool_->getLoops())`
`1050`	`1049`	`{`