Skip to content

Commit ee0a6ea

Browse files
committed
Updated support library version to v25.0.1
1 parent e5dcf73 commit ee0a6ea

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

android/build.gradle

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apply plugin: "com.android.library"
22

33
android {
4-
compileSdkVersion 23
5-
buildToolsVersion "23.0.3"
4+
compileSdkVersion 25
5+
buildToolsVersion "25.0.1"
66

77
defaultConfig {
88
minSdkVersion 16
@@ -14,7 +14,10 @@ android {
1414

1515
dependencies {
1616
compile "com.facebook.react:react-native:+" // From node_modules
17-
compile 'com.github.droibit.customtabslauncher:launcher:1.0.4'
17+
compile 'com.android.support:customtabs:25.0.1'
18+
compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') {
19+
exclude module: 'customtabs'
20+
}
1821

1922
testCompile 'junit:junit:4.12'
2023
}

android/src/main/java/com/github/droibit/android/reactnative/customtabs/CustomTabsModule.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import android.os.Bundle;
77
import android.provider.Browser;
88
import android.support.customtabs.CustomTabsIntent;
9+
import android.text.TextUtils;
910

1011
import com.droibit.android.customtabs.launcher.CustomTabsLauncher;
1112
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
@@ -26,8 +27,6 @@
2627

2728
/**
2829
* CustomTabs module.
29-
*
30-
* @author kumagai
3130
*/
3231
public class CustomTabsModule extends ReactContextBaseJavaModule {
3332

@@ -89,7 +88,7 @@ public Map<String, Object> getConstants() {
8988
*/
9089
@ReactMethod
9190
public void openURL(String url, ReadableMap option, Promise promise) {
92-
if (url == null || url.equals("")) {
91+
if (TextUtils.isEmpty(url)) {
9392
promise.reject(new JSApplicationIllegalArgumentException("Invalid URL: " + url));
9493
return;
9594
}

example/android/app/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@ def enableSeparateBuildPerCPUArchitecture = false
7777
def enableProguardInReleaseBuilds = false
7878

7979
android {
80-
compileSdkVersion 23
81-
buildToolsVersion "23.0.3"
80+
compileSdkVersion 25
81+
buildToolsVersion "25.0.1"
8282

8383
defaultConfig {
8484
applicationId "com.github.droibit.android.reactnative.customtabs.example"
8585
minSdkVersion 16
86-
targetSdkVersion 22
86+
targetSdkVersion 23
8787
versionCode 1
8888
versionName "1.0"
8989
ndk {
@@ -122,7 +122,7 @@ android {
122122
dependencies {
123123
compile fileTree(dir: "libs", include: ["*.jar"])
124124
compile project(':react-native-custom-tabs')
125-
compile "com.android.support:appcompat-v7:23.3.0"
125+
compile "com.android.support:appcompat-v7:25.0.1"
126126
compile "com.facebook.react:react-native:+" // From node_modules
127127
}
128128

0 commit comments

Comments
 (0)