From f5c69ad95bd3a020d19dec8faf6eaa830d9c3280 Mon Sep 17 00:00:00 2001 From: Arjan Zuidema Date: Thu, 13 Sep 2018 12:48:44 +0200 Subject: [PATCH 1/2] Fixed Execution failed for task ':react-native-custom-tabs:verifyReleaseResources'. --- android/build.gradle | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 53a1a73..53a3e9a 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -1,21 +1,25 @@ apply plugin: "com.android.library" +def safeExtGet(prop, fallback) { + rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback +} + android { - compileSdkVersion 25 - buildToolsVersion "25.0.1" + compileSdkVersion safeExtGet("compileSdkVersion", 25) + buildToolsVersion safeExtGet("buildToolsVersion", "25.0.1") defaultConfig { - minSdkVersion 16 - targetSdkVersion 23 + minSdkVersion safeExtGet("minSdkVersion", 16) + targetSdkVersion safeExtGet("targetSdkVersion", 23) versionCode 1 versionName "1.0" } } dependencies { - compile "com.facebook.react:react-native:+" // From node_modules - compile 'com.android.support:customtabs:25.0.1' - compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') { + implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}" + implementation 'com.android.support:customtabs:25.0.1' + implementation ('com.github.droibit.customtabslauncher:launcher:1.0.8') { exclude module: 'customtabs' } From 9c834b5f9de52c0fc9bc95506973d90492cdadbc Mon Sep 17 00:00:00 2001 From: Arjan Zuidema Date: Wed, 20 Mar 2019 15:38:51 +0100 Subject: [PATCH 2/2] Fixed: WARNING: Configuration 'testCompile' is obsolete and has been replaced with 'testImplementation' --- .gitignore | 1 + android/build.gradle | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 2c1792d..224fed7 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ build/ .gradle local.properties *.iml +.history # node.js # diff --git a/android/build.gradle b/android/build.gradle index 53a3e9a..8ec5a49 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -23,5 +23,5 @@ dependencies { exclude module: 'customtabs' } - testCompile 'junit:junit:4.12' + testImplementation 'junit:junit:4.12' } \ No newline at end of file diff --git a/package.json b/package.json index d0b3836..f77f12d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-custom-tabs", - "version": "0.1.7", + "version": "0.1.8", "description": "Chrome Custom Tabs for React Native.", "keywords": [ "react-native",