Merge pull request #126 from droidconKE/issue-117

Setup Lint Plugins

Author: michaelbukachi

.editorconfig

@@ -0,0 +1,4 @@
+[*.{kt,kts}]
+insert_final_newline=false
+max_line_length=off
+disabled_rules=no-wildcard-imports,import-ordering

.github/workflows/ci.yml

@@ -23,6 +23,22 @@ jobs:
           key: gradle-${{ runner.os }}-${{ hashFiles('**/build.gradle.kts') }}-${{ hashFiles('**/gradle/wrapper/gradle-wrapper.properties') }}-${{ hashFiles('**/buildSrc/src/main/kotlin/Dependencies.kt') }}
       - name: Unit tests
         run: ./gradlew -Pci --console=plain bundleDebug
+  lint-check:
+    name: Lint check
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v2
+      - uses: gradle/wrapper-validation-action@v1
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - uses: actions/cache@v1
+        with:
+          path: ~/.gradle/caches
+          key: gradle-${{ runner.os }}-${{ hashFiles('**/build.gradle.kts') }}-${{ hashFiles('**/gradle/wrapper/gradle-wrapper.properties') }}-${{ hashFiles('**/buildSrc/src/main/kotlin/Dependencies.kt') }}
+      - name: Lint checks
+        run: ./gradlew -Pci --console=plain ktlintFormat ktlintCheck detekt
   unit-tests:
     name: Unit tests
     runs-on: ubuntu-latest

app/build.gradle.kts

@@ -3,6 +3,7 @@ plugins {
     id(BuildPlugins.kotlinAndroid)
     id(BuildPlugins.kotlinAndroidExtensions)
     id(BuildPlugins.safeArgs)
+    id(BuildPlugins.ktlintPlugin)
 }
 android {
     compileSdkVersion(AndroidSDK.compile)
@@ -88,15 +89,11 @@ dependencies {
     implementation(Libraries.koinScope)
     implementation(Libraries.koinViewModel)
 
-    androidTestImplementation(TestLibraries.testRunner)
     androidTestImplementation(TestLibraries.testRules)
     androidTestImplementation(TestLibraries.koin)
     debugImplementation(TestLibraries.fragment)
     androidTestImplementation(TestLibraries.kakao)
-
-    //Google services
     implementation(Libraries.googleServices)
-
     // Mock data
     api(Libraries.fakeit)
-}
+}

app/src/main/java/com/android254/droidconKE2020/DroidConKeApp.kt

@@ -23,8 +23,8 @@ class DroidConKeApp : Application() {
         setSavedTheme()
     }
 
-     fun setSavedTheme() {
-         val sharedPrefs: Preferences by inject()
+    fun setSavedTheme() {
+        val sharedPrefs: Preferences by inject()
         val savedTheme = sharedPrefs.getUserTheme()
         AppCompatDelegate.setDefaultNightMode(savedTheme)
     }

app/src/main/java/com/android254/droidconKE2020/DynamicToolbar.kt

@@ -23,9 +23,9 @@ class DynamicToolbar @JvmOverloads constructor(
     var authHandler: (() -> Unit)? = null
     var feedbackHandler: (() -> Unit)? = null
     var nightModeHandler: (() -> Unit)? = null
-    var sessionsHandler :(() -> Unit)? = null
+    var sessionsHandler: (() -> Unit)? = null
 
-    fun onDestinationChanged(destination: Int, destinationName : String) {
+    fun onDestinationChanged(destination: Int, destinationName: String) {
         when (destination) {
             R.id.homeFragment, R.id.authDialog -> setHomeToolbar()
             R.id.feedFragment -> setFeedToolbar()
@@ -52,7 +52,8 @@ class DynamicToolbar @JvmOverloads constructor(
             }
             addView(view)
         } else {
-            val view = LayoutInflater.from(context).inflate(R.layout.home_signed_out_toolbar, this, false)
+            val view = LayoutInflater.from(context).inflate(R.layout.home_signed_out_toolbar,
+                this, false)
             val droidconIcon = view.findViewById<ImageView>(R.id.imgToolbarLogo)
             droidconIcon.setOnClickListener {
                 nightModeHandler?.invoke()
@@ -75,5 +76,4 @@ class DynamicToolbar @JvmOverloads constructor(
         }
         return view
     }
-
 }

app/src/main/java/com/android254/droidconKE2020/HomeActivity.kt

@@ -33,18 +33,18 @@ class HomeActivity : AppCompatActivity() {
             feedback()
         }
         toolbar.nightModeHandler = {
-            Toast.makeText(applicationContext,"Night",Toast.LENGTH_SHORT).show()
+            Toast.makeText(applicationContext, "Night", Toast.LENGTH_SHORT).show()
             toggleDarkTheme()
         }
     }
 
-    //Set up bottom navigation
+    // Set up bottom navigation
     private fun setUpBottomNavigation() {
-        //Retrieve fragment container view as nav host fragment
+        // Retrieve fragment container view as nav host fragment
         val navHostFragment =
             supportFragmentManager.findFragmentById(R.id.nav_host_fragment) as NavHostFragment
         val navController = navHostFragment.findNavController()
-        //Setup bottom navigation view with nav controller for dynamic navigation
+        // Setup bottom navigation view with nav controller for dynamic navigation
         bottomNavigation.setupWithNavController(navController = navController)
         navController.addOnDestinationChangedListener { _, destination, _ ->
             toolbar.onDestinationChanged(destination.id, destination.label as String)
@@ -77,4 +77,4 @@ class HomeActivity : AppCompatActivity() {
         sharedPrefs.setUserTheme(newTheme)
         (application as DroidConKeApp).setSavedTheme()
     }
-}
+}

app/src/main/java/com/android254/droidconKE2020/SplashScreenActivity.kt

@@ -1,22 +1,21 @@
 package com.android254.droidconKE2020
 
 import android.content.Intent
-import androidx.appcompat.app.AppCompatActivity
 import android.os.Bundle
-import android.util.Log
+import androidx.appcompat.app.AppCompatActivity
 import com.android254.droidconKE2020.core.PreferencesImpl
 import com.example.android_animation.AndroidAnimation
 import com.example.android_animation.enums.Easing
 import kotlinx.android.synthetic.main.activity_splash_screen.*
 
 class SplashScreenActivity : AppCompatActivity() {
 
-    private val MAX_SCALE = 1.5f
-    private val MIN_SCALE = .3f
-    private val MAX_ROTATION = 360f
-    private val MIN_ROTATION = -45f
-    private val MAX_TRANSLATION_X = 310f
-    private val MAX_TRANSLATION_Y = 170f
+    private val maxScale = 1.5f
+    private val minScale = .3f
+    private val maxRotation = 360f
+    private val minRotation = -45f
+    private val maxTranslationX = 310f
+    private val maxTranslationY = 170f
 
     private lateinit var preferencesImpl: PreferencesImpl
 
@@ -37,26 +36,26 @@ class SplashScreenActivity : AppCompatActivity() {
         AndroidAnimation().apply {
             delay = 300
             targetViews(imageViewLogo)
-            scaleX(MAX_SCALE)
-            scaleY(MAX_SCALE)
+            scaleX(maxScale)
+            scaleY(maxScale)
             duration = 1000
             thenPlay()
             easing = Easing.EXP_IN
-            translateX(MAX_TRANSLATION_X)
-            translateY(-MAX_TRANSLATION_Y + 40f)
-            scaleX(MAX_SCALE - 1f)
-            scaleY(MAX_SCALE - 1f)
-            rotate(MIN_ROTATION)
+            translateX(maxTranslationX)
+            translateY(-maxTranslationY + 40f)
+            scaleX(maxScale - 1f)
+            scaleY(maxScale - 1f)
+            rotate(minRotation)
             thenPlay()
             easing = Easing.CIRC_OUT
-            translateX(-MAX_TRANSLATION_X)
-            translateY(-MAX_TRANSLATION_Y, delay = 3500)
-            scaleX(MIN_SCALE)
-            scaleY(MIN_SCALE)
-            rotate(MAX_ROTATION)
+            translateX(-maxTranslationX)
+            translateY(-maxTranslationY, delay = 3500)
+            scaleX(minScale)
+            scaleY(minScale)
+            rotate(maxRotation)
             targetChildViews(linearLayout, stagger = 100, reverse = true)
-            scaleX((MIN_SCALE + .2f), 1f, MAX_SCALE, 1f)
-            scaleY((MIN_SCALE + .2f), 1f, MAX_SCALE, 1f)
+            scaleX((minScale + .2f), 1f, maxScale, 1f)
+            scaleY((minScale + .2f), 1f, maxScale, 1f)
             alpha(1f)
             onAnimationEnd {
                 preferencesImpl.setShowSplashScreen(false)
@@ -65,4 +64,4 @@ class SplashScreenActivity : AppCompatActivity() {
             start()
         }
     }
-}
+}

app/src/test/java/com/android254/droidconKE2020/ExampleUnitTest.kt

@@ -1,8 +1,7 @@
 package com.android254.droidconKE2020
 
-import org.junit.Test
-
 import org.junit.Assert.*
+import org.junit.Test
 
 /**
  * Example local unit test, which will execute on the development machine (host).
@@ -14,4 +13,4 @@ class ExampleUnitTest {
     fun addition_isCorrect() {
         assertEquals(4, 2 + 2)
     }
-}
+}

build.gradle.kts

@@ -1,17 +1,13 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
-buildscript {
-    repositories {
-        google()
-        jcenter()
-        
-    }
-    dependencies {
-        classpath(BuildPlugins.androidGradlePlugin)
-        classpath(BuildPlugins.kotlinGradlePlugin)
-        classpath(BuildPlugins.safeArgsGradlePlugin)
-        // NOTE: Do not place your application dependencies here; they belong
-        // in the individual module build.gradle files
-    }
+plugins {
+    id(BuildPlugins.ktlintPlugin)
+    id(BuildPlugins.dektPlugin)
+    id(BuildPlugins.dynamicFeature) apply false
+    id(BuildPlugins.androidLibrary) apply false
+    id(BuildPlugins.androidApplication) apply false
+    id(BuildPlugins.kotlinAndroid) apply false
+    id(BuildPlugins.kotlinAndroidExtensions) apply false
+    id(BuildPlugins.safeArgs) apply false
 }
 
 allprojects {
@@ -20,9 +16,24 @@ allprojects {
         jcenter()
         maven(url = "https://jitpack.io")
     }
+    apply(plugin = BuildPlugins.ktlintPlugin)
+    ktlint {
+        android.set(true)
+        verbose.set(true)
+        filter {
+            exclude { element -> element.file.path.contains("generated/") }
+        }
+    }
+}
+subprojects {
+    apply(plugin = BuildPlugins.dektPlugin)
+    detekt {
+        config = files("${project.rootDir}/detekt.yml")
+        parallel = true
+    }
 }
 
-tasks.register("clean").configure{
+tasks.register("clean").configure {
     delete("build")
 }
 
@@ -81,4 +92,4 @@ fun printResults(desc: TestDescriptor, result: TestResult) {
         println(testResultLine)
         println(separationLine)
     }
-}
+}