Inline check for slash in branch name

Author: christianruhstaller

scm/driver/bitbucket/linker.go

@@ -7,6 +7,7 @@ package bitbucket
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/drone/go-scm/scm"
 )
@@ -33,7 +34,7 @@ func (l *linker) Resource(ctx context.Context, repo string, ref scm.Reference) (
 		// a slash so we do this for branches with slashes in its names.
 		// See https://jira.atlassian.com/browse/BCLOUD-14422 for more information
 		//
-		if scm.BranchContainsSlash(t) {
+		if strings.Contains(t, "/") {
 			return fmt.Sprintf("%s%s/branch/%s", l.base, repo, t), nil
 		}
 

scm/util.go

@@ -77,9 +77,3 @@ func IsPullRequest(ref string) bool {
 		strings.HasPrefix(ref, "refs/pull-request/") ||
 		strings.HasPrefix(ref, "refs/merge-requests/")
 }
-
-// BranchContainsSlash returns true if the branch name
-// contains a slash.
-func BranchContainsSlash(branch string) bool {
-	return strings.Contains(branch, "/")
-}