support head and base ref and sha for prs

Author: bradrydzewski

CHANGELOG.md

@@ -6,7 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 ### Added
+- Support Head and Base sha for GitHub pull request, from [@bradrydzewski](https://github.com/bradrydzewski).
 - Support Before sha for Bitbucket, from [@jkdev81](https://github.com/jkdev81).
+- Support for creating GitHub deployment hooks, from [@bradrydzewski](https://github.com/bradrydzewski).
 
 ### Fixed
 - Fix issue getting a GitLab commit by ref, from [@bradrydzewski](https://github.com/bradrydzewski).

scm/driver/bitbucket/webhook.go

@@ -493,7 +493,7 @@ func convertPushHook(src *pushHook) *scm.PushHook {
 	change := src.Push.Changes[0]
 	namespace, name := scm.Split(src.Repository.FullName)
 	dst := &scm.PushHook{
-		Ref: scm.ExpandRef(change.New.Name, "refs/heads/"),
+		Ref:    scm.ExpandRef(change.New.Name, "refs/heads/"),
 		Before: change.Old.Target.Hash,
 		Commit: scm.Commit{
 			Sha:     change.New.Target.Hash,

scm/driver/gitea/webhook.go

@@ -66,7 +66,7 @@ func (s *webhookService) Parse(req *http.Request, fn scm.SecretFunc) (scm.Webhoo
 	if signature == "" && secret == "" {
 		return hook, scm.ErrSignatureInvalid
 	}
-	
+
 	// test signature if header not set and secret is in payload
 	if signature == "" && secret != "" && secret != key {
 		return hook, scm.ErrSignatureInvalid

scm/driver/github/pr.go

@@ -115,6 +115,16 @@ func convertPullRequest(from *pr) *scm.PullRequest {
 		Link:   from.DiffURL,
 		Closed: from.State != "open",
 		Merged: from.MergedAt.String != "",
+		Head: scm.Reference{
+			Name: from.Head.Ref,
+			Path: scm.ExpandRef(from.Head.Ref, "refs/heads"),
+			Sha:  from.Head.Sha,
+		},
+		Base: scm.Reference{
+			Name: from.Base.Ref,
+			Path: scm.ExpandRef(from.Base.Ref, "refs/heads"),
+			Sha:  from.Base.Sha,
+		},
 		Author: scm.User{
 			Login:  from.User.Login,
 			Avatar: from.User.AvatarURL,

scm/driver/github/repo.go

@@ -209,6 +209,9 @@ func convertHookEvents(from scm.HookEvents) []string {
 		events = append(events, "create")
 		events = append(events, "delete")
 	}
+	if from.Deployment {
+		events = append(events, "deployment")
+	}
 	return events
 }
 

scm/driver/github/repo_test.go

@@ -432,6 +432,7 @@ func TestHookEvents(t *testing.T) {
 		{
 			in: scm.HookEvents{
 				Branch:             true,
+				Deployment:         true,
 				Issue:              true,
 				IssueComment:       true,
 				PullRequest:        true,
@@ -440,7 +441,7 @@ func TestHookEvents(t *testing.T) {
 				ReviewComment:      true,
 				Tag:                true,
 			},
-			out: []string{"push", "pull_request", "pull_request_review_comment", "issues", "issue_comment", "create", "delete"},
+			out: []string{"push", "pull_request", "pull_request_review_comment", "issues", "issue_comment", "create", "delete", "deployment"},
 		},
 	}
 	for i, test := range tests {

scm/driver/github/testdata/pr.json.golden

@@ -10,6 +10,16 @@
     "Link": "https://github.com/octocat/Hello-World/pull/1347.diff",
     "Closed": false,
     "Merged": true,
+    "Base": {
+        "Sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+        "Path": "refs/heads/master",
+        "Name": "master"
+    },
+    "Head": {
+        "Sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+        "Path": "refs/heads/new-topic",
+        "Name": "new-topic"
+    },
     "Author": {
         "Login": "octocat",
         "Name": "",

scm/driver/github/testdata/pulls.json.golden

@@ -11,6 +11,16 @@
         "Link": "https://github.com/octocat/Hello-World/pull/1347.diff",
         "Closed": false,
         "Merged": true,
+        "Base": {
+            "Sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+            "Path": "refs/heads/master",
+            "Name": "master"
+        },
+        "Head": {
+            "Sha": "6dcb09b5b57875f334f61aebed695e2e4193db5e",
+            "Path": "refs/heads/new-topic",
+            "Name": "new-topic"
+        },
         "Author": {
             "Login": "octocat",
             "Name": "",

scm/driver/github/testdata/webhooks/pr_closed.json.golden

@@ -25,6 +25,16 @@
     "Link": "https://github.com/bradrydzewski/drone-test-go/pull/1.diff",
     "Closed": true,
     "Merged": false,
+    "Base": {
+      "Sha": "86378926c25f4b8310d3cc37f215eb6f25712850",
+      "Path": "refs/heads/bradrydzewski-patch-1",
+      "Name": "bradrydzewski-patch-1"
+    },
+    "Head": {
+        "Sha": "d2b75aa7797ec26b088fa2dd527e9d2c052fcedd",
+        "Path": "refs/heads/master",
+        "Name": "master"
+    },
     "Author": {
       "Login": "bradrydzewski",
       "Name": "",

scm/driver/github/testdata/webhooks/pr_edited.json.golden

@@ -25,6 +25,16 @@
     "Link": "https://github.com/bradrydzewski/drone-test-go/pull/1.diff",
     "Closed": false,
     "Merged": false,
+    "Base": {
+      "Sha": "86378926c25f4b8310d3cc37f215eb6f25712850",
+      "Path": "refs/heads/bradrydzewski-patch-1",
+      "Name": "bradrydzewski-patch-1"
+    },
+    "Head": {
+        "Sha": "d2b75aa7797ec26b088fa2dd527e9d2c052fcedd",
+        "Path": "refs/heads/master",
+        "Name": "master"
+    },
     "Author": {
       "Login": "bradrydzewski",
       "Name": "",