Update webhook.go

techknowlogick · web-flow · commit 7a85fe3b9f1d · 2019-05-14T23:54:41.000-04:00
diff --git a/scm/driver/gitea/webhook.go b/scm/driver/gitea/webhook.go
@@ -63,7 +63,7 @@ func (s *webhookService) Parse(req *http.Request, fn scm.SecretFunc) (scm.Webhoo
 	signature := req.Header.Get("X-Gitea-Signature")
 	
 	// test signature if header not set and secret is in payload
-	if (signature == "" || signature == nil) && secret != "" && secret != key {
+	if signature == "" && secret != "" && secret != key {
 		return hook, scm.ErrSignatureInvalid
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func (s webhookService) Parse(req http.Request, fn scm.SecretFunc) (scm.Webhoo`
`63`	`63`	`signature := req.Header.Get("X-Gitea-Signature")`
`64`	`64`
`65`	`65`	`// test signature if header not set and secret is in payload`
`66`		`- if (signature == "" \|\| signature == nil) && secret != "" && secret != key {`
	`66`	`+ if signature == "" && secret != "" && secret != key {`
`67`	`67`	`return hook, scm.ErrSignatureInvalid`
`68`	`68`	`}`
`69`	`69`