fix ns issue

Author: bradrydzewski

scm/driver/gitlab/repo.go

@@ -30,8 +30,9 @@ type repository struct {
 }
 
 type namespace struct {
-	Name string `json:"name"`
-	Path string `json:"path"`
+	Name     string `json:"name"`
+	Path     string `json:"path"`
+	FullPath string `json:"full_path"`
 }
 
 type permissions struct {
@@ -184,6 +185,9 @@ func convertRepository(from *repository) *scm.Repository {
 			Admin: canAdmin(from),
 		},
 	}
+	if path := from.Namespace.FullPath; path != "" {
+		to.Namespace = path
+	}
 	if to.Namespace == "" {
 		if parts := strings.SplitN(from.PathNamespace, "/", 2); len(parts) == 2 {
 			to.Namespace = parts[1]

scm/driver/gitlab/repo_test.go

@@ -49,6 +49,33 @@ func TestRepositoryFind(t *testing.T) {
 	t.Run("Rate", testRate(res))
 }
 
+func TestSubgroupFind(t *testing.T) {
+	defer gock.Off()
+
+	gock.New("https://gitlab.com").
+		Get("/api/v4/projects/gitlab-org/gitter/gitter-demo-app").
+		Reply(200).
+		Type("application/json").
+		SetHeaders(mockHeaders).
+		File("testdata/subgroup.json")
+
+	client := NewDefault()
+	got, _, err := client.Repositories.Find(context.Background(), "gitlab-org/gitter/gitter-demo-app")
+	if err != nil {
+		t.Error(err)
+		return
+	}
+
+	want := new(scm.Repository)
+	raw, _ := ioutil.ReadFile("testdata/subgroup.json.golden")
+	json.Unmarshal(raw, want)
+
+	if diff := cmp.Diff(got, want); diff != "" {
+		t.Errorf("Cannot parse subgroup")
+		t.Log(diff)
+	}
+}
+
 func TestRepositoryPerms(t *testing.T) {
 	defer gock.Off()
 

scm/driver/gitlab/testdata/subgroup.json

@@ -0,0 +1,29 @@
+{
+    "id": 14264161,
+    "description": "Gitter Demo App",
+    "name": "gitter-demo-app",
+    "name_with_namespace": "GitLab.org / gitter / gitter-demo-app",
+    "path": "gitter-demo-app",
+    "path_with_namespace": "gitlab-org/gitter/gitter-demo-app",
+    "created_at": "2019-09-11T23:30:02.188Z",
+    "default_branch": "master",
+    "tag_list": [],
+    "ssh_url_to_repo": "[email protected]:gitlab-org/gitter/gitter-demo-app.git",
+    "http_url_to_repo": "https://gitlab.com/gitlab-org/gitter/gitter-demo-app.git",
+    "web_url": "https://gitlab.com/gitlab-org/gitter/gitter-demo-app",
+    "readme_url": "https://gitlab.com/gitlab-org/gitter/gitter-demo-app/blob/master/README.md",
+    "avatar_url": null,
+    "star_count": 0,
+    "forks_count": 1,
+    "last_activity_at": "2020-01-09T10:11:44.250Z",
+    "namespace": {
+        "id": 1540914,
+        "name": "gitter",
+        "path": "gitter",
+        "kind": "group",
+        "full_path": "gitlab-org/gitter",
+        "parent_id": 9970,
+        "avatar_url": "/uploads/-/system/group/avatar/1540914/icon_128x128.png",
+        "web_url": "https://gitlab.com/groups/gitlab-org/gitter"
+    }
+}

scm/driver/gitlab/testdata/subgroup.json.golden

@@ -0,0 +1,17 @@
+{
+    "ID": "14264161",
+    "Namespace": "gitlab-org/gitter",
+    "Name": "gitter-demo-app",
+    "Perm": {
+        "Pull": true,
+        "Push": false,
+        "Admin": false
+    },
+    "Branch": "master",
+    "Private": false,
+    "Clone": "https://gitlab.com/gitlab-org/gitter/gitter-demo-app.git",
+    "CloneSSH": "[email protected]:gitlab-org/gitter/gitter-demo-app.git",
+    "Link": "",
+    "Created": "0001-01-01T00:00:00Z",
+    "Updated": "0001-01-01T00:00:00Z"
+}