Implemented PR creation in Stash driver.

Author: chhsia0

scm/driver/stash/pr.go

@@ -19,7 +19,7 @@ type pullService struct {
 func (s *pullService) Find(ctx context.Context, repo string, number int) (*scm.PullRequest, *scm.Response, error) {
 	namespace, name := scm.Split(repo)
 	path := fmt.Sprintf("rest/api/1.0/projects/%s/repos/%s/pull-requests/%d", namespace, name, number)
-	out := new(pullRequest)
+	out := new(pr)
 	res, err := s.client.do(ctx, "GET", path, nil, out)
 	return convertPullRequest(out), res, err
 }
@@ -35,7 +35,7 @@ func (s *pullService) FindComment(ctx context.Context, repo string, number int,
 func (s *pullService) List(ctx context.Context, repo string, opts scm.PullRequestListOptions) ([]*scm.PullRequest, *scm.Response, error) {
 	namespace, name := scm.Split(repo)
 	path := fmt.Sprintf("rest/api/1.0/projects/%s/repos/%s/pull-requests", namespace, name)
-	out := new(pullRequests)
+	out := new(prs)
 	res, err := s.client.do(ctx, "GET", path, nil, out)
 	if !out.pagination.LastPage.Bool {
 		res.Page.First = 1
@@ -79,6 +79,23 @@ func (s *pullService) Close(ctx context.Context, repo string, number int) (*scm.
 	return res, err
 }
 
+func (s *pullService) Create(ctx context.Context, repo string, input *scm.PullRequestInput) (*scm.PullRequest, *scm.Response, error) {
+	namespace, name := scm.Split(repo)
+	path := fmt.Sprintf("rest/api/1.0/projects/%s/repos/%s/pull-requests", namespace, name)
+	in := new(prInput)
+	in.Title = input.Title
+	in.Description = input.Body
+	in.FromRef.Repository.Project.Key = namespace
+	in.FromRef.Repository.Slug = name
+	in.FromRef.ID = scm.ExpandRef(input.Source, "refs/heads")
+	in.ToRef.Repository.Project.Key = namespace
+	in.ToRef.Repository.Slug = name
+	in.ToRef.ID = scm.ExpandRef(input.Target, "refs/heads")
+	out := new(pr)
+	res, err := s.client.do(ctx, "POST", path, in, out)
+	return convertPullRequest(out), res, err
+}
+
 func (s *pullService) CreateComment(ctx context.Context, repo string, number int, in *scm.CommentInput) (*scm.Comment, *scm.Response, error) {
 	input := pullRequestCommentInput{Text: in.Body}
 	namespace, name := scm.Split(repo)
@@ -97,7 +114,7 @@ func (s *pullService) DeleteComment(context.Context, string, int, int) (*scm.Res
 	return nil, scm.ErrNotSupported
 }
 
-type pullRequest struct {
+type pr struct {
 	ID          int    `json:"id"`
 	Version     int    `json:"version"`
 	Title       string `json:"title"`
@@ -146,20 +163,43 @@ type pullRequest struct {
 	} `json:"links"`
 }
 
-type pullRequests struct {
+type prs struct {
 	pagination
-	Values []*pullRequest `json:"values"`
+	Values []*pr `json:"values"`
+}
+
+type prInput struct {
+	Title       string `json:"title"`
+	Description string `json:"description"`
+	FromRef     struct {
+		ID         string `json:"id"`
+		Repository struct {
+			Slug    string `json:"slug"`
+			Project struct {
+				Key string `json:"key"`
+			} `json:"project"`
+		} `json:"repository"`
+	} `json:"fromRef"`
+	ToRef struct {
+		ID         string `json:"id"`
+		Repository struct {
+			Slug    string `json:"slug"`
+			Project struct {
+				Key string `json:"key"`
+			} `json:"project"`
+		} `json:"repository"`
+	} `json:"toRef"`
 }
 
-func convertPullRequests(from *pullRequests) []*scm.PullRequest {
+func convertPullRequests(from *prs) []*scm.PullRequest {
 	to := []*scm.PullRequest{}
 	for _, v := range from.Values {
 		to = append(to, convertPullRequest(v))
 	}
 	return to
 }
 
-func convertPullRequest(from *pullRequest) *scm.PullRequest {
+func convertPullRequest(from *pr) *scm.PullRequest {
 	fork := scm.Join(
 		from.FromRef.Repository.Project.Key,
 		from.FromRef.Repository.Slug,

scm/driver/stash/pr_test.go

@@ -150,6 +150,38 @@ func TestPullClose(t *testing.T) {
 	}
 }
 
+func TestPullCreate(t *testing.T) {
+	defer gock.Off()
+
+	gock.New("http://example.com:7990").
+		Post("rest/api/1.0/projects/PRJ/repos/my-repo/pull-requests").
+		Reply(201).
+		Type("application/json").
+		File("testdata/pr.json")
+
+	input := scm.PullRequestInput{
+		Title:  "Updated Files",
+		Body:   `* added LICENSE\r\n* update files\r\n* update files`,
+		Source: "feature/x",
+		Target: "master",
+	}
+
+	client, _ := New("http://example.com:7990")
+	got, _, err := client.PullRequests.Create(context.Background(), "PRJ/my-repo", &input)
+	if err != nil {
+		t.Error(err)
+	}
+
+	want := new(scm.PullRequest)
+	raw, _ := ioutil.ReadFile("testdata/pr.json.golden")
+	json.Unmarshal(raw, &want)
+
+	if diff := cmp.Diff(got, want); diff != "" {
+		t.Errorf("Unexpected Results")
+		t.Log(diff)
+	}
+}
+
 func TestPullCreateComment(t *testing.T) {
 	defer gock.Off()
 

scm/driver/stash/webhook.go

@@ -123,10 +123,10 @@ type pushHook struct {
 }
 
 type pullRequestHook struct {
-	EventKey    string       `json:"eventKey"`
-	Date        string       `json:"date"`
-	Actor       *user        `json:"actor"`
-	PullRequest *pullRequest `json:"pullRequest"`
+	EventKey    string `json:"eventKey"`
+	Date        string `json:"date"`
+	Actor       *user  `json:"actor"`
+	PullRequest *pr    `json:"pullRequest"`
 }
 
 type change struct {