fixes issue #27

Author: bradrydzewski

CHANGELOG.md

@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 ### Added
+- Improve status display text in new bitbucket pull request screen, from [@bradrydzewski](https://github.com/bradrydzewski). See [#27](https://github.com/drone/go-scm/issues/27).
 
 ## [1.6.0]
 ### Added

scm/driver/bitbucket/integration/integration.go

@@ -0,0 +1,7 @@
+// Copyright 2017 Drone.IO Inc. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Package integration implements a Bitbucket Cloud integration
+// tests.
+package integration

scm/driver/bitbucket/integration/integration_test.go

@@ -0,0 +1,26 @@
+// Copyright 2017 Drone.IO Inc. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package integration
+
+import (
+	"context"
+	"net/http"
+	"os"
+	"testing"
+
+	"github.com/drone/go-scm/scm/driver/bitbucket"
+	"github.com/drone/go-scm/scm/transport"
+)
+
+var noContext = context.Background()
+
+func TestIntegration(t *testing.T) {
+	client := bitbucket.NewDefault()
+	client.Client = &http.Client{
+		Transport: &transport.BearerToken{
+			Token: os.Getenv("BITBUCKET_TOKEN"),
+		},
+	}
+}

scm/driver/bitbucket/repo.go

@@ -142,6 +142,7 @@ func (s *repositoryService) CreateStatus(ctx context.Context, repo, ref string,
 	path := fmt.Sprintf("2.0/repositories/%s/commit/%s/statuses/build", repo, ref)
 	in := &status{
 		State: convertFromState(input.State),
+		Name:  input.Title,
 		Desc:  input.Desc,
 		Key:   input.Label,
 		URL:   input.Target,
@@ -282,6 +283,7 @@ func convertStatus(from *status) *scm.Status {
 	return &scm.Status{
 		State:  convertState(from.State),
 		Label:  from.Key,
+		Title:  from.Name,
 		Desc:   from.Desc,
 		Target: from.URL,
 	}

scm/driver/bitbucket/repo_test.go

@@ -176,6 +176,7 @@ func TestStatusCreate(t *testing.T) {
 		File("testdata/status.json")
 
 	in := &scm.StatusInput{
+		Title:  "BUILD-22",
 		Desc:   "Build has completed successfully",
 		Label:  "continuous-integration/drone",
 		State:  scm.StateSuccess,

scm/driver/bitbucket/testdata/status.json

@@ -44,5 +44,5 @@
   },
   "updated_on": "2018-07-01T20:27:45.726774+00:00",
   "type": "build",
-  "name": ""
+  "name": "build-22"
 }

scm/driver/bitbucket/testdata/status.json.golden

@@ -2,5 +2,6 @@
     "State": 3,
     "Label": "drone",
     "Desc": "Build has completed successfully",
+    "Title": "build-22",
     "Target": "https://ci.example.com/1000/output"
 }

scm/repo.go

@@ -76,13 +76,20 @@ type (
 		Label  string
 		Desc   string
 		Target string
+
+		// TODO(bradrydzewski) this field is only used
+		// by Bitbucket which requires a user-defined
+		// key (label), title and description. We need
+		// to cleanup this abstraction.
+		Title string
 	}
 
 	// StatusInput provides the input fields required for
 	// creating or updating commit statuses.
 	StatusInput struct {
 		State  State
 		Label  string
+		Title  string
 		Desc   string
 		Target string
 	}