Set pathsAffectingAllModules via OS specific path

mezpahlan · mezpahlan · commit 7a9d718af8c0 · 2022-10-16T17:34:08.000+01:00
This protects against some users specifying Windows separators and some
specifying Unix-like separators.
diff --git a/affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt b/affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt
@@ -1,5 +1,6 @@
 package com.dropbox.affectedmoduledetector
 
+import com.dropbox.affectedmoduledetector.util.toOsSpecificPath
 import java.io.File
 
 class AffectedModuleConfiguration {
@@ -66,7 +67,8 @@ class AffectedModuleConfiguration {
             requireNotNull(baseDir) {
                 "baseDir must be set to use pathsAffectingAllModules"
             }
-            field = value
+            // Protect against users specifying the wrong path separator for their OS.
+            field = value.map { it.toOsSpecificPath() }.toSet()
         }
         get() {
             field.forEach { path ->

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`package com.dropbox.affectedmoduledetector`
`2`	`2`
	`3`	`+import com.dropbox.affectedmoduledetector.util.toOsSpecificPath`
`3`	`4`	`import java.io.File`
`4`	`5`
`5`	`6`	`class AffectedModuleConfiguration {`
`@@ -66,7 +67,8 @@ class AffectedModuleConfiguration {`
`66`	`67`	`requireNotNull(baseDir) {`
`67`	`68`	`"baseDir must be set to use pathsAffectingAllModules"`
`68`	`69`	`}`
`69`		`- field = value`
	`70`	`+ // Protect against users specifying the wrong path separator for their OS.`
	`71`	`+ field = value.map { it.toOsSpecificPath() }.toSet()`
`70`	`72`	`}`
`71`	`73`	`get() {`
`72`	`74`	`field.forEach { path ->`