new way for creating custom task

Author: Evleaps

README.md

@@ -94,6 +94,13 @@ affectedModuleDetector {
     ]
     includeUncommitted = true
     top = "HEAD"
+    customTasks = [
+        new AffectedModuleConfiguration.CustomTask(
+            "runDetektByImpact",
+            "detekt",
+            "Run static analysis tool without auto-correction by Impact analysis"
+        )
+    ]
 }
 ```
 
@@ -109,7 +116,7 @@ affectedModuleDetector {
  - `excludedModules`: A list of modules that will be excluded from the build process
  - `includeUncommitted`: If uncommitted files should be considered affected
  - `top`: The top of the git log to use. Must be used in combination with configuration `includeUncommitted = false`
- - `customTasks`: set of enum fields which implemented [AffectedModuleTaskType]()
+ - `customTasks`: set of [CustomTask](https://github.com/dropbox/AffectedModuleDetector/blob/main/affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt)
 
  By default, the Detector will look for `assembleAndroidDebugTest`, `connectedAndroidDebugTest`, and `testDebug`.  Modules can specify a configuration block to specify which variant tests to run:
  ```groovy
@@ -175,44 +182,22 @@ You should see zero tests run. Make a change within one of the modules and commi
 ## Custom tasks 
 
 If you want to add a custom gradle command to execute with impact analysis 
-you must create data structure which implementing [AffectedModuleTaskType](). 
-
-**NOTE1:** Your declared data structure might be in any place of your project.<br/>
-**NOTE2:** In example bottom we using ENUM, but it not necessary. You can use any way for overriding fields of interface. 
-
-Example:
-```kotlin
-enum class CustomImpactAnalysisTaskType(
-    override val commandByImpact: String,
-    override val originalGradleCommand: String,
-    override val taskDescription: String
-): AffectedModuleTaskType {
-
-    DETEKT_TASK(
-        commandByImpact = "runDetektByImpact",
-        originalGradleCommand = "detekt",
-        taskDescription = "Run static analysis tool without auto-correction by Impact analysis"
-    )
-   
-   // other tasks
-}
-```
-
-And then you must add your custom enum fields to configuration in `build.gradle` of your project: 
+you must declare [AffectedModuleConfiguration.CustomTask](https://github.com/dropbox/AffectedModuleDetector/blob/main/affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt) 
+which is implementing [AffectedModuleTaskType]() in the configuration in `build.gradle` of your project:
 
 ```groovy
-// some code 
+// ... 
 
 affectedModuleDetector {
-     baseDir = "${project.rootDir}"
-     pathsAffectingAllModules = ["buildSrc/"]
-     specifiedBranch = "dev"
-     customTasks = [ // <- list of enum fields
-             CustomImpactAnalysisTaskType.DETEKT_TASK, 
-             CustomImpactAnalysisTaskType.OTHER_TASK
+     // ...
+     customTasks = [
+           new AffectedModuleConfiguration.CustomTask(
+                   "runDetektByImpact", 
+                   "detekt",
+                   "Run static analysis tool without auto-correction by Impact analysis"
+           )
      ]
-     compareFrom = "SpecifiedBranchCommit"
-     includeUncommitted = false
+     // ...
 }
 ```
 

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt

@@ -4,6 +4,45 @@ import java.io.File
 
 class AffectedModuleConfiguration {
 
+    /**
+     * Implementation of [AffectedModuleTaskType] for easy adding of custom gradle task to
+     * AffectedModuleDetector. You can declare a new instance of it in build.gradle.
+     *
+     * @see AffectedModuleTaskType - interface
+     * @see customTasks - configuration field
+     */
+    data class CustomTask(
+        override val commandByImpact: String,
+        override val originalGradleCommand: String,
+        override val taskDescription: String
+    ) : AffectedModuleTaskType
+
+    /**
+     * If you want to add a custom task for impact analysis you must set the list
+     * of [AffectedModuleTaskType] implementations.
+     *
+     * Example:
+     * `build.gradle
+     *
+     *  affectedModuleDetector {
+     *       ...
+     *       customTasks = [ // <- list of custom gradle invokes
+     *           new AffectedModuleConfiguration.CustomTask(
+     *                "runSomeCustomTaskByImpact",
+     *                "someTaskForExample",
+     *                "Task description."
+     *            )
+     *       ]
+     *       ...
+     *  }
+     * `
+     *
+     * @see AffectedModuleTaskType - interface
+     * @see CustomTask - Implementation class
+     * @see AffectedModuleDetectorPlugin - gradle plugin
+     */
+    var customTasks = emptySet<AffectedModuleConfiguration.CustomTask>()
+
     /**
      * Folder to place the log in
      */
@@ -64,28 +103,6 @@ class AffectedModuleConfiguration {
      */
     var includeUncommitted: Boolean = true
 
-    /**
-     * If you want to add a custom task for impact analysis you must set the list
-     * of [AffectedModuleTaskType] implementations.
-     *
-     * Example:
-     * `build.gradle
-     *
-     *  affectedModuleDetector {
-     *       baseDir = "${project.rootDir}"
-     *       pathsAffectingAllModules = ["buildSrc/"]
-     *       specifiedBranch = "dev"
-     *       customTasks = [MyCustomTask.DETEKT_TASK] // <- list of enum fields
-     *       compareFrom = "SpecifiedBranchCommit"
-     *       includeUncommitted = false
-     *  }
-     * `
-     *
-     * @see AffectedModuleTaskType
-     * @see AffectedModuleDetectorPlugin
-     */
-    var customTasks = emptySet<AffectedModuleTaskType>()
-
     /**
      * The top of the git log to use, only used when [includeUncommitted] is false
      */

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt

@@ -82,15 +82,17 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
             lazyMessage = {  "Unable to find ${AffectedTestConfiguration.name} in $rootProject" }
         ) as AffectedModuleConfiguration
 
-        mainConfiguration
-            .customTasks
-            .forEach { taskType ->
-                registerImpactAnalysisTask(
-                    rootProject = rootProject,
-                    taskType = taskType,
-                    groupName = CUSTOM_TASK_GROUP_NAME
-                )
-            }
+        rootProject.afterEvaluate {
+            mainConfiguration
+                .customTasks
+                .forEach { taskType ->
+                    registerImpactAnalysisTask(
+                        rootProject = rootProject,
+                        taskType = taskType,
+                        groupName = CUSTOM_TASK_GROUP_NAME
+                    )
+                }
+        }
     }
 
     @VisibleForTesting

sample/build.gradle

@@ -1,3 +1,4 @@
+import com.dropbox.affectedmoduledetector.AffectedModuleConfiguration
 import com.dropbox.sample.Dependencies
 
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
@@ -27,13 +28,27 @@ affectedModuleDetector {
     ]
     specifiedBranch = "main"
     compareFrom = "SpecifiedBranchCommit"
-
+    customTasks = [
+            new AffectedModuleConfiguration.CustomTask(
+                    "runSomeCustomTaskByImpact",
+                    "someTaskForExample",
+                    "Command someTaskForExample is just an example task for demonstration of" +
+                            "how to add custom commands to impact analysis"
+            )
+    ]
     logFolder = "${project.rootDir}"
     excludedModules = [
             "sample-util"
     ]
 }
 
+// just for example; Do not add to you project.
+allprojects {
+    tasks.register("someTaskForExample") {task ->
+        println("someTaskForExample on path: ${task.path} was called")
+    }
+}
+
 allprojects {
     repositories {
         google()