test fix

Author: Evleaps

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt

@@ -199,7 +199,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
     private fun filterAndroidTests(project: Project) {
         val tracker = DependencyTracker(project, null)
         project.tasks.configureEach { task ->
-            if (task.name.contains("AndroidTest")) {
+            if (task.name.contains(ANDROID_TEST_PATTERN)) {
                 tracker.findAllDependents(project).forEach { dependentProject ->
                     dependentProject.tasks.forEach { dependentTask ->
                         AffectedModuleDetector.configureTaskGuard(dependentTask)
@@ -237,6 +237,8 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
         private const val PLUGIN_JAVA_LIBRARY = "com.android.library"
         private const val PLUGIN_KOTLIN = "kotlin"
 
+        private const val ANDROID_TEST_PATTERN = "AndroidTest"
+
         private val pluginIds = listOf(
             PLUGIN_ANDROID_APPLICATION,
             PLUGIN_ANDROID_LIBRARY,

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/InternalTaskType.kt

@@ -25,7 +25,7 @@ internal enum class InternalTaskType(
     ),
 
     JVM_TEST(
-        commandByImpact = "runAffectedUnitTests",
+        commandByImpact = "", // inner type. This type doesn't registered in gradle
         originalGradleCommand = "test",
         taskDescription = "Runs all affected unit tests for non Android modules."
     )

affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPluginTest.kt

@@ -9,7 +9,10 @@ import org.junit.Rule
 import org.junit.Test
 import org.junit.rules.TemporaryFolder
 import java.lang.IllegalStateException
+import org.junit.runner.RunWith
+import org.junit.runners.JUnit4
 
+@RunWith(JUnit4::class)
 class AffectedModuleDetectorPluginTest {
 
     private companion object {
@@ -168,14 +171,13 @@ class AffectedModuleDetectorPluginTest {
         assertThat(jvmTestTask?.group).isEqualTo(AffectedModuleDetectorPlugin.TEST_TASK_GROUP_NAME)
     }
 
-
-
     @Test
     fun `GIVEN affected module detector plugin WHEN registerTestTasks called THEN added all tasks from InternalTaskType`() {
         // GIVEN
         val configuration = AffectedModuleConfiguration()
         rootProject.extensions.add(AffectedModuleConfiguration.name, configuration)
         val plugin = AffectedModuleDetectorPlugin()
+        val availableTaskVariants = 3 // runAffectedAndroidTests, assembleAffectedAndroidTests and runAffectedUnitTests
 
         // WHEN
         plugin.registerTestTasks(rootProject)
@@ -184,7 +186,7 @@ class AffectedModuleDetectorPluginTest {
             .filter { it.group == AffectedModuleDetectorPlugin.TEST_TASK_GROUP_NAME }
 
         // THEN
-        assert(testTasks.size == InternalTaskType.values().size)
+        assert(testTasks.size == availableTaskVariants)
     }
 
     @Test

affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/InternalTaskTypeTest.kt

@@ -0,0 +1,18 @@
+package com.dropbox.affectedmoduledetector
+
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.JUnit4
+
+@RunWith(JUnit4::class)
+class InternalTaskTypeTest {
+
+    @Test
+    fun `GIVEN InternalTaskType WHEN JVM_TEST WHEN THEN originalGradleCommand is "test"`() {
+        // GIVEN
+        val nonAndroidTestTask = InternalTaskType.JVM_TEST.originalGradleCommand
+        val nonAndroidTestCommand = "test"
+
+        assert(nonAndroidTestTask == nonAndroidTestCommand)
+    }
+}