Optimize memory usage.

Author: Qiming Yuan

Dropbox.Api.Tests/DropboxApiTests.cs

@@ -249,6 +249,22 @@ public async Task TestNoAuth()
             Assert.IsTrue(response.Changes);
         }
 
+        /// Test APM flow.
+        /// </summary>
+        [TestMethod]
+        public void TaskAPM()
+        {
+            var result = Client.Users.BeginGetCurrentAccount(null);
+            var account = Client.Users.EndGetCurrentAccount(result);
+            var accountId = account.AccountId;
+
+            result = Client.Users.BeginGetAccountBatch(new string[] { accountId }, null);
+            var accounts = Client.Users.EndGetAccountBatch(result);
+
+            Assert.AreEqual(accounts.Count, 1);
+            Assert.AreEqual(accounts[0].AccountId, accountId);
+        }
+
         /// <summary>
         /// Converts string to a memory stream.
         /// </summary>

Dropbox.Api/Async/PollArg.cs

@@ -51,6 +51,7 @@ public PollArg(string asyncJobId)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PollArg()
         {
         }

Dropbox.Api/Auth/RateLimitError.cs

@@ -50,6 +50,7 @@ public RateLimitError(RateLimitReason reason,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public RateLimitError()
         {
             this.RetryAfter = 1;

Dropbox.Api/Auth/TokenFromOAuth1Arg.cs

@@ -65,6 +65,7 @@ public TokenFromOAuth1Arg(string oauth1Token,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public TokenFromOAuth1Arg()
         {
         }

Dropbox.Api/Auth/TokenFromOAuth1Result.cs

@@ -53,6 +53,7 @@ public TokenFromOAuth1Result(string oauth2Token)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public TokenFromOAuth1Result()
         {
         }

Dropbox.Api/DropboxRequestHandler.cs

@@ -243,12 +243,21 @@ private async Task<Result> RequestJsonStringWithRetry(
 
             if (routeStyle == RouteStyle.Upload)
             {
+                if (body == null)
+                {
+                    throw new ArgumentNullException("body");
+                }
+
                 // to support retry logic, the body stream must be seekable
                 // if it isn't we won't retry
                 if (!body.CanSeek)
                 {
                     maxRetries = 0;
                 }
+                else if (maxRetries == 0)
+                {
+                    // Do not copy the stream
+                }
                 else if (body is MemoryStream)
                 {
                     cachedStreamStart = body.Position;
@@ -565,7 +574,6 @@ private class Result
         /// </summary>
         /// <typeparam name="TResponse">The type of the response.</typeparam>
         private class DownloadResponse<TResponse> : IDownloadResponse<TResponse>
-            where TResponse : new()
         {
             /// <summary>
             /// The HTTP response containing the body content.

Dropbox.Api/Files/AlphaGetMetadataArg.cs

@@ -63,6 +63,7 @@ public AlphaGetMetadataArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public AlphaGetMetadataArg()
         {
         }

Dropbox.Api/Files/CommitInfo.cs

@@ -77,6 +77,7 @@ public CommitInfo(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CommitInfo()
         {
             this.Mode = Dropbox.Api.Files.WriteMode.Add.Instance;

Dropbox.Api/Files/CommitInfoWithProperties.cs

@@ -66,6 +66,7 @@ public CommitInfoWithProperties(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CommitInfoWithProperties()
         {
         }

Dropbox.Api/Files/CreateFolderArg.cs

@@ -56,6 +56,7 @@ public CreateFolderArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CreateFolderArg()
         {
             this.Autorename = false;