Refresh Access token when no expiration is present (#241)

Brent1LT · Brent Bumann · web-flow · commit fde57457076c · 2021-05-21T15:42:05.000-07:00
Co-authored-by: Brent Bumann &lt;bbumann@dropbox.com&gt;
diff --git a/dropbox-sdk-dotnet/Dropbox.Api/DropboxRequestHandler.cs b/dropbox-sdk-dotnet/Dropbox.Api/DropboxRequestHandler.cs
@@ -640,7 +640,8 @@ private async Task<Result> RequestJsonString(
         private async Task<bool> CheckAndRefreshAccessToken()
         {
             bool canRefresh = this.options.OAuth2RefreshToken != null && this.options.AppKey != null;
-            bool needsRefresh = this.options.OAuth2AccessTokenExpiresAt.HasValue && DateTime.Now.AddSeconds(TokenExpirationBuffer) >= this.options.OAuth2AccessTokenExpiresAt.Value;
+            bool needsRefresh = (this.options.OAuth2AccessTokenExpiresAt.HasValue && DateTime.Now.AddSeconds(TokenExpirationBuffer) >= this.options.OAuth2AccessTokenExpiresAt.Value) ||
+                (this.options.OAuth2RefreshToken != null && !this.options.OAuth2AccessTokenExpiresAt.HasValue);
             bool needsToken = this.options.OAuth2AccessToken == null;
             if ((needsRefresh || needsToken) && canRefresh)
             {

Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,8 @@ private async Task<Result> RequestJsonString(`
`640`	`640`	`private async Task<bool> CheckAndRefreshAccessToken()`
`641`	`641`	`{`
`642`	`642`	`bool canRefresh = this.options.OAuth2RefreshToken != null && this.options.AppKey != null;`
`643`		`- bool needsRefresh = this.options.OAuth2AccessTokenExpiresAt.HasValue && DateTime.Now.AddSeconds(TokenExpirationBuffer) >= this.options.OAuth2AccessTokenExpiresAt.Value;`
	`643`	`+ bool needsRefresh = (this.options.OAuth2AccessTokenExpiresAt.HasValue && DateTime.Now.AddSeconds(TokenExpirationBuffer) >= this.options.OAuth2AccessTokenExpiresAt.Value) \|\|`
	`644`	`+ (this.options.OAuth2RefreshToken != null && !this.options.OAuth2AccessTokenExpiresAt.HasValue);`
`644`	`645`	`bool needsToken = this.options.OAuth2AccessToken == null;`
`645`	`646`	`if ((needsRefresh \|\| needsToken) && canRefresh)`
`646`	`647`	`{`