Merge pull request #76 from dropbox/handle-timestamp

Handle nullable timestamp

Author: Rajat Goel

dropbox/files/types.go

@@ -175,7 +175,7 @@ type CommitInfo struct {
 	// the Dropbox servers. It can also record an additional timestamp, provided
 	// by Dropbox desktop clients, mobile clients, and API apps of when the file
 	// was actually created or modified.
-	ClientModified time.Time `json:"client_modified,omitempty"`
+	ClientModified *time.Time `json:"client_modified,omitempty"`
 	// Mute : Normally, users are made aware of any file modifications in their
 	// Dropbox account via notifications in the client software. If true, this
 	// tells the clients that this modification shouldn't result in a user
@@ -1316,7 +1316,7 @@ type FileLockMetadata struct {
 	// LockholderAccountId : The account ID of the lock holder if known.
 	LockholderAccountId string `json:"lockholder_account_id,omitempty"`
 	// Created : The timestamp of the lock was created.
-	Created time.Time `json:"created,omitempty"`
+	Created *time.Time `json:"created,omitempty"`
 }
 
 // NewFileLockMetadata returns a new FileLockMetadata instance
@@ -2160,7 +2160,7 @@ type ListRevisionsResult struct {
 	// is either deleted or moved.
 	IsDeleted bool `json:"is_deleted"`
 	// ServerDeleted : The time of deletion if the file was deleted.
-	ServerDeleted time.Time `json:"server_deleted,omitempty"`
+	ServerDeleted *time.Time `json:"server_deleted,omitempty"`
 	// Entries : The revisions for the file. Only revisions that are not deleted
 	// will show up here.
 	Entries []*FileMetadata `json:"entries"`
@@ -2459,7 +2459,7 @@ type MediaMetadata struct {
 	// Location : The GPS coordinate of the photo/video.
 	Location *GpsCoordinates `json:"location,omitempty"`
 	// TimeTaken : The timestamp when the photo/video is taken.
-	TimeTaken time.Time `json:"time_taken,omitempty"`
+	TimeTaken *time.Time `json:"time_taken,omitempty"`
 }
 
 // NewMediaMetadata returns a new MediaMetadata instance

dropbox/paper/types.go

@@ -138,7 +138,7 @@ type Cursor struct {
 	// time will have a very short expiration as docs do get modified very often
 	// and the modified time can be changed while the iteration is happening
 	// thus altering the results.
-	Expiration time.Time `json:"expiration,omitempty"`
+	Expiration *time.Time `json:"expiration,omitempty"`
 }
 
 // NewCursor returns a new Cursor instance

dropbox/sharing/types.go

@@ -427,7 +427,7 @@ type LinkMetadata struct {
 	// Visibility : Who can access the link.
 	Visibility *Visibility `json:"visibility"`
 	// Expires : Expiration time, if set. By default the link won't expire.
-	Expires time.Time `json:"expires,omitempty"`
+	Expires *time.Time `json:"expires,omitempty"`
 }
 
 // NewLinkMetadata returns a new LinkMetadata instance
@@ -671,7 +671,7 @@ type SharedContentLinkMetadataBase struct {
 	CurrentAudience *LinkAudience `json:"current_audience"`
 	// Expiry : Whether the link has an expiry set on it. A link with an expiry
 	// will have its  audience changed to members when the expiry is reached.
-	Expiry time.Time `json:"expiry,omitempty"`
+	Expiry *time.Time `json:"expiry,omitempty"`
 	// LinkPermissions : A list of permissions for actions you can perform on
 	// the link.
 	LinkPermissions []*LinkPermission `json:"link_permissions"`
@@ -801,7 +801,7 @@ type SharedLinkMetadata struct {
 	// slash.
 	Name string `json:"name"`
 	// Expires : Expiration time, if set. By default the link won't expire.
-	Expires time.Time `json:"expires,omitempty"`
+	Expires *time.Time `json:"expires,omitempty"`
 	// PathLower : The lowercased full path in the user's Dropbox. This always
 	// starts with a slash. This field will only be present only if the linked
 	// file is in the authenticated user's  dropbox.
@@ -3680,7 +3680,7 @@ type SharedFileMetadata struct {
 	// this shared file. If the user was not invited to the shared file, the
 	// timestamp will indicate when the user was invited to the parent shared
 	// folder. This value may be absent.
-	TimeInvited time.Time `json:"time_invited,omitempty"`
+	TimeInvited *time.Time `json:"time_invited,omitempty"`
 }
 
 // NewSharedFileMetadata returns a new SharedFileMetadata instance
@@ -3922,7 +3922,7 @@ type SharedLinkSettings struct {
 	LinkPassword string `json:"link_password,omitempty"`
 	// Expires : Expiration time of the shared link. By default the link won't
 	// expire.
-	Expires time.Time `json:"expires,omitempty"`
+	Expires *time.Time `json:"expires,omitempty"`
 	// Audience : The new audience who can benefit from the access level
 	// specified by the link's access level specified in the `link_access_level`
 	// field of `LinkPermissions`. This is used in conjunction with team
@@ -4424,7 +4424,7 @@ type UserFileMembershipInfo struct {
 	UserMembershipInfo
 	// TimeLastSeen : The UTC timestamp of when the user has last seen the
 	// content, if they have.
-	TimeLastSeen time.Time `json:"time_last_seen,omitempty"`
+	TimeLastSeen *time.Time `json:"time_last_seen,omitempty"`
 	// PlatformType : The platform on which the user has last seen the content,
 	// or unknown.
 	PlatformType *seen_state.PlatformType `json:"platform_type,omitempty"`

dropbox/team/types.go

@@ -44,9 +44,9 @@ type DeviceSession struct {
 	// made.
 	Country string `json:"country,omitempty"`
 	// Created : The time this session was created.
-	Created time.Time `json:"created,omitempty"`
+	Created *time.Time `json:"created,omitempty"`
 	// Updated : The time of the last activity from this session.
-	Updated time.Time `json:"updated,omitempty"`
+	Updated *time.Time `json:"updated,omitempty"`
 }
 
 // NewDeviceSession returns a new DeviceSession instance
@@ -66,7 +66,7 @@ type ActiveWebSession struct {
 	// Browser : Information on the browser used for this web session.
 	Browser string `json:"browser"`
 	// Expires : The time this session expires.
-	Expires time.Time `json:"expires,omitempty"`
+	Expires *time.Time `json:"expires,omitempty"`
 }
 
 // NewActiveWebSession returns a new ActiveWebSession instance
@@ -278,7 +278,7 @@ type ApiApp struct {
 	// PublisherUrl : The publisher's URL.
 	PublisherUrl string `json:"publisher_url,omitempty"`
 	// Linked : The time this application was linked.
-	Linked time.Time `json:"linked,omitempty"`
+	Linked *time.Time `json:"linked,omitempty"`
 	// IsAppFolder : Whether the linked application uses a dedicated folder.
 	IsAppFolder bool `json:"is_app_folder"`
 }
@@ -439,9 +439,9 @@ func NewCustomQuotaUsersArg(Users []*UserSelectorArg) *CustomQuotaUsersArg {
 type DateRange struct {
 	// StartDate : Optional starting date (inclusive). If start_date is None or
 	// too long ago, this field will  be set to 6 months ago.
-	StartDate time.Time `json:"start_date,omitempty"`
+	StartDate *time.Time `json:"start_date,omitempty"`
 	// EndDate : Optional ending date (exclusive).
-	EndDate time.Time `json:"end_date,omitempty"`
+	EndDate *time.Time `json:"end_date,omitempty"`
 }
 
 // NewDateRange returns a new DateRange instance
@@ -1950,7 +1950,7 @@ type LegalHoldPolicy struct {
 	// Description : A description of the legal hold policy.
 	Description string `json:"description,omitempty"`
 	// ActivationTime : The time at which the legal hold was activated.
-	ActivationTime time.Time `json:"activation_time,omitempty"`
+	ActivationTime *time.Time `json:"activation_time,omitempty"`
 	// Members : Team members IDs and number of permanetly deleted members under
 	// hold.
 	Members *MembersInfo `json:"members"`
@@ -1959,7 +1959,7 @@ type LegalHoldPolicy struct {
 	// StartDate : Start date of the legal hold policy.
 	StartDate time.Time `json:"start_date"`
 	// EndDate : End date of the legal hold policy.
-	EndDate time.Time `json:"end_date,omitempty"`
+	EndDate *time.Time `json:"end_date,omitempty"`
 }
 
 // NewLegalHoldPolicy returns a new LegalHoldPolicy instance
@@ -2156,9 +2156,9 @@ type LegalHoldsPolicyCreateArg struct {
 	// Members : List of team member IDs added to the hold.
 	Members []string `json:"members"`
 	// StartDate : start date of the legal hold policy.
-	StartDate time.Time `json:"start_date,omitempty"`
+	StartDate *time.Time `json:"start_date,omitempty"`
 	// EndDate : end date of the legal hold policy.
-	EndDate time.Time `json:"end_date,omitempty"`
+	EndDate *time.Time `json:"end_date,omitempty"`
 }
 
 // NewLegalHoldsPolicyCreateArg returns a new LegalHoldsPolicyCreateArg instance
@@ -2830,14 +2830,14 @@ type MemberProfile struct {
 	MembershipType *TeamMembershipType `json:"membership_type"`
 	// InvitedOn : The date and time the user was invited to the team (contains
 	// value only when the member's status matches `TeamMemberStatus.invited`).
-	InvitedOn time.Time `json:"invited_on,omitempty"`
+	InvitedOn *time.Time `json:"invited_on,omitempty"`
 	// JoinedOn : The date and time the user joined as a member of a specific
 	// team.
-	JoinedOn time.Time `json:"joined_on,omitempty"`
+	JoinedOn *time.Time `json:"joined_on,omitempty"`
 	// SuspendedOn : The date and time the user was suspended from the team
 	// (contains value only when the member's status matches
 	// `TeamMemberStatus.suspended`).
-	SuspendedOn time.Time `json:"suspended_on,omitempty"`
+	SuspendedOn *time.Time `json:"suspended_on,omitempty"`
 	// PersistentId : Persistent ID that a team can attach to the user. The
 	// persistent ID is unique ID to be used for SAML authentication.
 	PersistentId string `json:"persistent_id,omitempty"`

dropbox/team_common/types.go

@@ -92,9 +92,9 @@ const (
 // TimeRange : Time range.
 type TimeRange struct {
 	// StartTime : Optional starting time (inclusive).
-	StartTime time.Time `json:"start_time,omitempty"`
+	StartTime *time.Time `json:"start_time,omitempty"`
 	// EndTime : Optional ending time (exclusive).
-	EndTime time.Time `json:"end_time,omitempty"`
+	EndTime *time.Time `json:"end_time,omitempty"`
 }
 
 // NewTimeRange returns a new TimeRange instance

dropbox/team_log/types.go

@@ -1854,10 +1854,10 @@ type DeviceSessionLogInfo struct {
 	IpAddress string `json:"ip_address,omitempty"`
 	// Created : The time this session was created. Might be missing due to
 	// historical data gap.
-	Created time.Time `json:"created,omitempty"`
+	Created *time.Time `json:"created,omitempty"`
 	// Updated : The time of the last activity from this session. Might be
 	// missing due to historical data gap.
-	Updated time.Time `json:"updated,omitempty"`
+	Updated *time.Time `json:"updated,omitempty"`
 }
 
 // NewDeviceSessionLogInfo returns a new DeviceSessionLogInfo instance
@@ -13228,7 +13228,7 @@ func NewFileRequestCreateType(Description string) *FileRequestCreateType {
 type FileRequestDeadline struct {
 	// Deadline : The deadline for this file request. Might be missing due to
 	// historical data gap.
-	Deadline time.Time `json:"deadline,omitempty"`
+	Deadline *time.Time `json:"deadline,omitempty"`
 	// AllowLateUploads : If set, allow uploads after the deadline has passed.
 	// Might be missing due to historical data gap.
 	AllowLateUploads string `json:"allow_late_uploads,omitempty"`
@@ -15134,7 +15134,7 @@ type LegalHoldsActivateAHoldDetails struct {
 	// StartDate : Hold start date.
 	StartDate time.Time `json:"start_date"`
 	// EndDate : Hold end date.
-	EndDate time.Time `json:"end_date,omitempty"`
+	EndDate *time.Time `json:"end_date,omitempty"`
 }
 
 // NewLegalHoldsActivateAHoldDetails returns a new LegalHoldsActivateAHoldDetails instance
@@ -19809,7 +19809,7 @@ func NewSharedContentAddInviteesType(Description string) *SharedContentAddInvite
 type SharedContentAddLinkExpiryDetails struct {
 	// NewValue : New shared content link expiration date. Might be missing due
 	// to historical data gap.
-	NewValue time.Time `json:"new_value,omitempty"`
+	NewValue *time.Time `json:"new_value,omitempty"`
 }
 
 // NewSharedContentAddLinkExpiryDetails returns a new SharedContentAddLinkExpiryDetails instance
@@ -19979,10 +19979,10 @@ func NewSharedContentChangeLinkAudienceType(Description string) *SharedContentCh
 type SharedContentChangeLinkExpiryDetails struct {
 	// NewValue : New shared content link expiration date. Might be missing due
 	// to historical data gap.
-	NewValue time.Time `json:"new_value,omitempty"`
+	NewValue *time.Time `json:"new_value,omitempty"`
 	// PreviousValue : Previous shared content link expiration date. Might be
 	// missing due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedContentChangeLinkExpiryDetails returns a new SharedContentChangeLinkExpiryDetails instance
@@ -20234,7 +20234,7 @@ func NewSharedContentRemoveInviteesType(Description string) *SharedContentRemove
 type SharedContentRemoveLinkExpiryDetails struct {
 	// PreviousValue : Previous shared content link expiration date. Might be
 	// missing due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedContentRemoveLinkExpiryDetails returns a new SharedContentRemoveLinkExpiryDetails instance
@@ -20778,10 +20778,10 @@ func NewSharedLinkAddExpiryType(Description string) *SharedLinkAddExpiryType {
 type SharedLinkChangeExpiryDetails struct {
 	// NewValue : New shared link expiration date. Might be missing due to
 	// historical data gap.
-	NewValue time.Time `json:"new_value,omitempty"`
+	NewValue *time.Time `json:"new_value,omitempty"`
 	// PreviousValue : Previous shared link expiration date. Might be missing
 	// due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedLinkChangeExpiryDetails returns a new SharedLinkChangeExpiryDetails instance
@@ -20940,7 +20940,7 @@ func NewSharedLinkDownloadType(Description string) *SharedLinkDownloadType {
 type SharedLinkRemoveExpiryDetails struct {
 	// PreviousValue : Previous shared link expiration date. Might be missing
 	// due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedLinkRemoveExpiryDetails returns a new SharedLinkRemoveExpiryDetails instance
@@ -20971,7 +20971,7 @@ type SharedLinkSettingsAddExpirationDetails struct {
 	SharedContentLink string `json:"shared_content_link,omitempty"`
 	// NewValue : New shared content link expiration date. Might be missing due
 	// to historical data gap.
-	NewValue time.Time `json:"new_value,omitempty"`
+	NewValue *time.Time `json:"new_value,omitempty"`
 }
 
 // NewSharedLinkSettingsAddExpirationDetails returns a new SharedLinkSettingsAddExpirationDetails instance
@@ -21121,10 +21121,10 @@ type SharedLinkSettingsChangeExpirationDetails struct {
 	SharedContentLink string `json:"shared_content_link,omitempty"`
 	// NewValue : New shared content link expiration date. Might be missing due
 	// to historical data gap.
-	NewValue time.Time `json:"new_value,omitempty"`
+	NewValue *time.Time `json:"new_value,omitempty"`
 	// PreviousValue : Previous shared content link expiration date. Might be
 	// missing due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedLinkSettingsChangeExpirationDetails returns a new SharedLinkSettingsChangeExpirationDetails instance
@@ -21185,7 +21185,7 @@ type SharedLinkSettingsRemoveExpirationDetails struct {
 	SharedContentLink string `json:"shared_content_link,omitempty"`
 	// PreviousValue : Previous shared link expiration date. Might be missing
 	// due to historical data gap.
-	PreviousValue time.Time `json:"previous_value,omitempty"`
+	PreviousValue *time.Time `json:"previous_value,omitempty"`
 }
 
 // NewSharedLinkSettingsRemoveExpirationDetails returns a new SharedLinkSettingsRemoveExpirationDetails instance

generator/go_helpers.py

@@ -85,7 +85,12 @@ def fmt_type(data_type, namespace=None, use_interface=False, raw=False):
     if use_interface and _needs_base_type(data_type):
         return _type_table.get(data_type.__class__, type_name)
     else:
-        return _type_table.get(data_type.__class__, '*' + type_name)
+        if data_type.__class__ not in _type_table:
+            return '*' + type_name
+        if data_type.__class__ == Timestamp:
+            # For other primitive types, `omitempty` does the job.
+            return ('*' if nullable else '') + _type_table[data_type.__class__]
+        return _type_table[data_type.__class__]
 
 
 def fmt_var(name, export=True, check_reserved=False):