Lot of go lint fixes.

Still get a bunch of warnings, but the important ones are addressed by
this commit.

Author: Diwaker Gupta

dropbox/async/types.go

@@ -18,6 +18,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+// Package async : has no documentation (yet)
 package async
 
 import (
@@ -26,21 +27,25 @@ import (
 	"github.com/dropbox/dropbox-sdk-go-unofficial/dropbox"
 )
 
-// Result returned by methods that launch an asynchronous job. A method who may
-// either launch an asynchronous job, or complete the request synchronously, can
-// use this union by extending it, and adding a 'complete' field with the type
-// of the synchronous response. See `LaunchEmptyResult` for an example.
+// LaunchResultBase : Result returned by methods that launch an asynchronous
+// job. A method who may either launch an asynchronous job, or complete the
+// request synchronously, can use this union by extending it, and adding a
+// 'complete' field with the type of the synchronous response. See
+// `LaunchEmptyResult` for an example.
 type LaunchResultBase struct {
 	dropbox.Tagged
-	// This response indicates that the processing is asynchronous. The string
-	// is an id that can be used to obtain the status of the asynchronous job.
+	// AsyncJobId : This response indicates that the processing is asynchronous.
+	// The string is an id that can be used to obtain the status of the
+	// asynchronous job.
 	AsyncJobId string `json:"async_job_id,omitempty"`
 }
 
+// Valid tag values for LaunchResultBase
 const (
-	LaunchResultBase_AsyncJobId = "async_job_id"
+	LaunchResultBaseAsyncJobId = "async_job_id"
 )
 
+// UnmarshalJSON deserializes into a LaunchResultBase instance
 func (u *LaunchResultBase) UnmarshalJSON(body []byte) error {
 	type wrap struct {
 		dropbox.Tagged
@@ -60,59 +65,66 @@ func (u *LaunchResultBase) UnmarshalJSON(body []byte) error {
 	return nil
 }
 
-// Result returned by methods that may either launch an asynchronous job or
-// complete synchronously. Upon synchronous completion of the job, no additional
-// information is returned.
+// LaunchEmptyResult : Result returned by methods that may either launch an
+// asynchronous job or complete synchronously. Upon synchronous completion of
+// the job, no additional information is returned.
 type LaunchEmptyResult struct {
 	dropbox.Tagged
 }
 
+// Valid tag values for LaunchEmptyResult
 const (
-	LaunchEmptyResult_Complete = "complete"
+	LaunchEmptyResultComplete = "complete"
 )
 
-// Arguments for methods that poll the status of an asynchronous job.
+// PollArg : Arguments for methods that poll the status of an asynchronous job.
 type PollArg struct {
-	// Id of the asynchronous job. This is the value of a response returned from
-	// the method that launched the job.
+	// AsyncJobId : Id of the asynchronous job. This is the value of a response
+	// returned from the method that launched the job.
 	AsyncJobId string `json:"async_job_id"`
 }
 
+// NewPollArg returns a new PollArg instance
 func NewPollArg(AsyncJobId string) *PollArg {
 	s := new(PollArg)
 	s.AsyncJobId = AsyncJobId
 	return s
 }
 
-// Result returned by methods that poll for the status of an asynchronous job.
-// Unions that extend this union should add a 'complete' field with a type of
-// the information returned upon job completion. See `PollEmptyResult` for an
-// example.
+// PollResultBase : Result returned by methods that poll for the status of an
+// asynchronous job. Unions that extend this union should add a 'complete' field
+// with a type of the information returned upon job completion. See
+// `PollEmptyResult` for an example.
 type PollResultBase struct {
 	dropbox.Tagged
 }
 
+// Valid tag values for PollResultBase
 const (
-	PollResultBase_InProgress = "in_progress"
+	PollResultBaseInProgress = "in_progress"
 )
 
-// Result returned by methods that poll for the status of an asynchronous job.
-// Upon completion of the job, no additional information is returned.
+// PollEmptyResult : Result returned by methods that poll for the status of an
+// asynchronous job. Upon completion of the job, no additional information is
+// returned.
 type PollEmptyResult struct {
 	dropbox.Tagged
 }
 
+// Valid tag values for PollEmptyResult
 const (
-	PollEmptyResult_Complete = "complete"
+	PollEmptyResultComplete = "complete"
 )
 
-// Error returned by methods for polling the status of asynchronous job.
+// PollError : Error returned by methods for polling the status of asynchronous
+// job.
 type PollError struct {
 	dropbox.Tagged
 }
 
+// Valid tag values for PollError
 const (
-	PollError_InvalidAsyncJobId = "invalid_async_job_id"
-	PollError_InternalError     = "internal_error"
-	PollError_Other             = "other"
+	PollErrorInvalidAsyncJobId = "invalid_async_job_id"
+	PollErrorInternalError     = "internal_error"
+	PollErrorOther             = "other"
 )

dropbox/auth/client.go

@@ -18,6 +18,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+// Package auth : has no documentation (yet)
 package auth
 
 import (
@@ -29,14 +30,17 @@ import (
 	"github.com/dropbox/dropbox-sdk-go-unofficial/dropbox"
 )
 
+// Client interface describes all routes in this namespace
 type Client interface {
-	// Disables the access token used to authenticate the call.
+	// TokenRevoke : Disables the access token used to authenticate the call.
 	TokenRevoke() (err error)
 }
 
 type apiImpl dropbox.Context
-type TokenRevokeApiError struct {
-	dropbox.ApiError
+
+//TokenRevokeAPIError is an error-wrapper for the token/revoke route
+type TokenRevokeAPIError struct {
+	dropbox.APIError
 	EndpointError struct{} `json:"error"`
 }
 
@@ -48,8 +52,8 @@ func (dbx *apiImpl) TokenRevoke() (err error) {
 		return
 	}
 
-	if dbx.Config.AsMemberId != "" {
-		req.Header.Set("Dropbox-API-Select-User", dbx.Config.AsMemberId)
+	if dbx.Config.AsMemberID != "" {
+		req.Header.Set("Dropbox-API-Select-User", dbx.Config.AsMemberID)
 	}
 	if dbx.Config.Verbose {
 		log.Printf("req: %v", req)
@@ -73,15 +77,15 @@ func (dbx *apiImpl) TokenRevoke() (err error) {
 	}
 	if resp.StatusCode != 200 {
 		if resp.StatusCode == 409 {
-			var apiError TokenRevokeApiError
+			var apiError TokenRevokeAPIError
 			err = json.Unmarshal(body, &apiError)
 			if err != nil {
 				return
 			}
 			err = apiError
 			return
 		}
-		var apiError dropbox.ApiError
+		var apiError dropbox.APIError
 		if resp.StatusCode == 400 {
 			apiError.ErrorSummary = string(body)
 			err = apiError
@@ -97,6 +101,7 @@ func (dbx *apiImpl) TokenRevoke() (err error) {
 	return
 }
 
+// New returns a Client implementation for this namespace
 func New(c dropbox.Config) *apiImpl {
 	ctx := apiImpl(dropbox.NewContext(c))
 	return &ctx

dropbox/auth/types.go

@@ -18,18 +18,20 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+// Package auth : has no documentation (yet)
 package auth
 
 import "github.com/dropbox/dropbox-sdk-go-unofficial/dropbox"
 
-// Errors occurred during authentication.
+// AuthError : Errors occurred during authentication.
 type AuthError struct {
 	dropbox.Tagged
 }
 
+// Valid tag values for AuthError
 const (
-	AuthError_InvalidAccessToken = "invalid_access_token"
-	AuthError_InvalidSelectUser  = "invalid_select_user"
-	AuthError_InvalidSelectAdmin = "invalid_select_admin"
-	AuthError_Other              = "other"
+	AuthErrorInvalidAccessToken = "invalid_access_token"
+	AuthErrorInvalidSelectUser  = "invalid_select_user"
+	AuthErrorInvalidSelectAdmin = "invalid_select_admin"
+	AuthErrorOther              = "other"
 )

dropbox/common/types.go

@@ -18,4 +18,5 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
+// Package common : has no documentation (yet)
 package common