Skip to content

Commit 9270e26

Browse files
author
Diwaker Gupta
committed
Generate comments for deprecated routes.
As recommended at https://blog.golang.org/godoc-documenting-go-code
1 parent d01a3f8 commit 9270e26

File tree

4 files changed

+19
-1
lines changed

4 files changed

+19
-1
lines changed

dropbox/files/client.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ type Client interface {
4747
AlphaUpload(arg *CommitInfoWithProperties, content io.Reader) (res *FileMetadata, err error)
4848
// Copy : Copy a file or folder to a different location in the user's
4949
// Dropbox. If the source path is a folder all its contents will be copied.
50+
// Deprecated: Use `CopyV2` instead
5051
Copy(arg *RelocationArg) (res IsMetadata, err error)
5152
// CopyBatch : Copy multiple files or folders to different locations at once
5253
// in the user's Dropbox. If `RelocationBatchArg.allow_shared_folder` is
@@ -71,6 +72,7 @@ type Client interface {
7172
// Dropbox. If the source path is a folder all its contents will be copied.
7273
CopyV2(arg *RelocationArg) (res *RelocationResult, err error)
7374
// CreateFolder : Create a folder at a given path.
75+
// Deprecated: Use `CreateFolderV2` instead
7476
CreateFolder(arg *CreateFolderArg) (res *FolderMetadata, err error)
7577
// CreateFolderV2 : Create a folder at a given path.
7678
CreateFolderV2(arg *CreateFolderArg) (res *CreateFolderResult, err error)
@@ -79,6 +81,7 @@ type Client interface {
7981
// indicates that the file or folder was deleted. The returned metadata will
8082
// be the corresponding `FileMetadata` or `FolderMetadata` for the item at
8183
// time of deletion, and not a `DeletedMetadata` object.
84+
// Deprecated: Use `DeleteV2` instead
8285
Delete(arg *DeleteArg) (res IsMetadata, err error)
8386
// DeleteBatch : Delete multiple files/folders at once. This route is
8487
// asynchronous, which returns a job ID immediately and runs the delete
@@ -159,6 +162,7 @@ type Client interface {
159162
ListRevisions(arg *ListRevisionsArg) (res *ListRevisionsResult, err error)
160163
// Move : Move a file or folder to a different location in the user's
161164
// Dropbox. If the source path is a folder all its contents will be moved.
165+
// Deprecated: Use `MoveV2` instead
162166
Move(arg *RelocationArg) (res IsMetadata, err error)
163167
// MoveBatch : Move multiple files or folders to different locations at once
164168
// in the user's Dropbox. This route is 'all or nothing', which means if one
@@ -215,6 +219,7 @@ type Client interface {
215219
Upload(arg *CommitInfo, content io.Reader) (res *FileMetadata, err error)
216220
// UploadSessionAppend : Append more data to an upload session. A single
217221
// request should not upload more than 150 MB.
222+
// Deprecated: Use `UploadSessionAppendV2` instead
218223
UploadSessionAppend(arg *UploadSessionCursor, content io.Reader) (err error)
219224
// UploadSessionAppendV2 : Append more data to an upload session. When the
220225
// parameter close is set, this call will close the session. A single

dropbox/sharing/client.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ type Client interface {
4444
AddFolderMember(arg *AddFolderMemberArg) (err error)
4545
// ChangeFileMemberAccess : Identical to update_file_member but with less
4646
// information returned.
47+
// Deprecated: Use `UpdateFileMember` instead
4748
ChangeFileMemberAccess(arg *ChangeFileMemberAccessArgs) (res *FileMemberActionResult, err error)
4849
// CheckJobStatus : Returns the status of an asynchronous job. Apps must
4950
// have full Dropbox access to use this endpoint.
@@ -64,6 +65,7 @@ type Client interface {
6465
// the corresponding file or folder. In the future, this will no longer be
6566
// the case, so your app shouldn't rely on this behavior. Instead, if your
6667
// app needs to revoke a shared link, use `revokeSharedLink`.
68+
// Deprecated: Use `CreateSharedLinkWithSettings` instead
6769
CreateSharedLink(arg *CreateSharedLinkArg) (res *PathLinkMetadata, err error)
6870
// CreateSharedLinkWithSettings : Create a shared link with custom settings.
6971
// If no settings are given then the default visibility is
@@ -89,6 +91,7 @@ type Client interface {
8991
// all shared links that allow access to the given path. Collection links
9092
// are never returned in this case. Note that the url field in the response
9193
// is never the shortened URL.
94+
// Deprecated: Use `ListSharedLinks` instead
9295
GetSharedLinks(arg *GetSharedLinksArg) (res *GetSharedLinksResult, err error)
9396
// ListFileMembers : Use to obtain the members who have been invited to a
9497
// file, both inherited and uninherited members.
@@ -170,6 +173,7 @@ type Client interface {
170173
RelinquishFolderMembership(arg *RelinquishFolderMembershipArg) (res *async.LaunchEmptyResult, err error)
171174
// RemoveFileMember : Identical to remove_file_member_2 but with less
172175
// information returned.
176+
// Deprecated: Use `RemoveFileMember2` instead
173177
RemoveFileMember(arg *RemoveFileMemberArg) (res *FileMemberActionIndividualResult, err error)
174178
// RemoveFileMember2 : Removes a specified member from the file.
175179
RemoveFileMember2(arg *RemoveFileMemberArg) (res *FileMemberRemoveActionResult, err error)

dropbox/team/client.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ type Client interface {
3939
// DevicesListMembersDevices : List all device sessions of a team.
4040
DevicesListMembersDevices(arg *ListMembersDevicesArg) (res *ListMembersDevicesResult, err error)
4141
// DevicesListTeamDevices : List all device sessions of a team.
42+
// Deprecated: Use `DevicesListMembersDevices` instead
4243
DevicesListTeamDevices(arg *ListTeamDevicesArg) (res *ListTeamDevicesResult, err error)
4344
// DevicesRevokeDeviceSession : Revoke a device session of a team's member
4445
DevicesRevokeDeviceSession(arg *RevokeDeviceSessionArg) (err error)
@@ -109,6 +110,7 @@ type Client interface {
109110
// LinkedAppsListTeamLinkedApps : List all applications linked to the team
110111
// members' accounts. Note, this endpoint doesn't list any team-linked
111112
// applications.
113+
// Deprecated: Use `LinkedAppsListMembersLinkedApps` instead
112114
LinkedAppsListTeamLinkedApps(arg *ListTeamAppsArg) (res *ListTeamAppsResult, err error)
113115
// LinkedAppsRevokeLinkedApp : Revoke a linked application of the team
114116
// member

generator/go_helpers.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from stone.api import ApiNamespace
1+
from stone.api import (ApiNamespace, ApiRoute)
22
from stone.data_type import (
33
Boolean,
44
Float32,
@@ -118,6 +118,13 @@ def generate_doc(code_generator, t):
118118
d = 'Package %s : %s' % (t.name, doc)
119119
code_generator.emit_wrapped_text(d, prefix='// ')
120120

121+
# Generate comment for deprecated routes
122+
if isinstance(t, ApiRoute):
123+
if t.deprecated is not None:
124+
d = 'Deprecated: '
125+
if t.deprecated.by is not None:
126+
d += 'Use `%s` instead' % fmt_var(t.deprecated.by.name)
127+
code_generator.emit_wrapped_text(d, prefix='// ')
121128

122129
def _needs_base_type(data_type):
123130
if is_struct_type(data_type) and data_type.has_enumerated_subtypes():

0 commit comments

Comments
 (0)