Fix parsing for API errors for download RPCs.

Fixes #34
Fixes #35

Author: Diwaker Gupta

dropbox/files/client.go

@@ -1373,6 +1373,11 @@ func (dbx *apiImpl) Download(arg *DownloadArg) (res *FileMetadata, content io.Re
 		return
 	}
 	if resp.StatusCode == http.StatusConflict {
+		defer resp.Body.Close()
+		body, err = ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return
+		}
 		var apiError DownloadAPIError
 		err = json.Unmarshal(body, &apiError)
 		if err != nil {
@@ -1524,6 +1529,11 @@ func (dbx *apiImpl) GetPreview(arg *PreviewArg) (res *FileMetadata, content io.R
 		return
 	}
 	if resp.StatusCode == http.StatusConflict {
+		defer resp.Body.Close()
+		body, err = ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return
+		}
 		var apiError GetPreviewAPIError
 		err = json.Unmarshal(body, &apiError)
 		if err != nil {
@@ -1664,6 +1674,11 @@ func (dbx *apiImpl) GetThumbnail(arg *ThumbnailArg) (res *FileMetadata, content
 		return
 	}
 	if resp.StatusCode == http.StatusConflict {
+		defer resp.Body.Close()
+		body, err = ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return
+		}
 		var apiError GetThumbnailAPIError
 		err = json.Unmarshal(body, &apiError)
 		if err != nil {

dropbox/paper/client.go

@@ -285,6 +285,11 @@ func (dbx *apiImpl) DocsDownload(arg *PaperDocExport) (res *PaperDocExportResult
 		return
 	}
 	if resp.StatusCode == http.StatusConflict {
+		defer resp.Body.Close()
+		body, err = ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return
+		}
 		var apiError DocsDownloadAPIError
 		err = json.Unmarshal(body, &apiError)
 		if err != nil {

dropbox/sdk.go

@@ -35,7 +35,7 @@ const (
 	hostAPI       = "api"
 	hostContent   = "content"
 	hostNotify    = "notify"
-	sdkVersion    = "3.2.0"
+	sdkVersion    = "3.3.0"
 	specVersion   = "318810d"
 )
 

dropbox/sharing/client.go

@@ -1081,6 +1081,11 @@ func (dbx *apiImpl) GetSharedLinkFile(arg *GetSharedLinkMetadataArg) (res IsShar
 		return
 	}
 	if resp.StatusCode == http.StatusConflict {
+		defer resp.Body.Close()
+		body, err = ioutil.ReadAll(resp.Body)
+		if err != nil {
+			return
+		}
 		var apiError GetSharedLinkFileAPIError
 		err = json.Unmarshal(body, &apiError)
 		if err != nil {

generator/go_client.stoneg.py

@@ -176,7 +176,15 @@ def _generate_response(self, route):
 
     def _generate_error_handling(self, route):
         out = self.emit
+        style = route.attrs.get('style', 'rpc')
         with self.block('if resp.StatusCode == http.StatusConflict'):
+            # If style was download, body was assigned to a header.
+            # Need to re-read the response body to parse the error
+            if style == 'download':
+                out('defer resp.Body.Close()')
+                with self.block('body, err = ioutil.ReadAll(resp.Body);'
+                                'if err != nil'):
+                    out('return')
             out('var apiError %sAPIError' % fmt_var(route.name))
             with self.block('err = json.Unmarshal(body, &apiError);'
                             'if err != nil'):