Skip to content

Commit 2e0fa7f

Browse files
committed
raise MSRV to 1.84
It should still build with a rustc as far back as 1.75.0, but the lack of a MSRV-aware resolver means an increasinly large number of dependencies have to be manually pinned to old versions, and figuring it out is a huge pain.
1 parent 05e86ae commit 2e0fa7f

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

.github/workflows/cargo-test.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,10 @@ jobs:
3939
run: if [[ ! -z `git status --porcelain=v1` ]]; then echo "::error::Workspace is dirty after running generator. Did you remember to check in the generated files?"; exit 1; fi
4040

4141
- name: Install MSRV toolchain
42-
run: rustup install 1.75.0 --profile minimal
43-
44-
# remove this once our MSRV is >= 1.84, which has the MSRV-aware resolver
45-
- name: fix deps for old rustc
46-
run: |
47-
rustup run 1.75.0 cargo update litemap --precise 0.7.4
48-
rustup run 1.75.0 cargo update zerofrom --precise 0.1.5
42+
run: rustup install 1.84.0 --profile minimal
4943

5044
- name: Run cargo test
51-
run: rustup run 1.75.0 cargo test --all-features
45+
run: rustup run 1.84.0 cargo test --all-features
5246

5347
- name: Run clippy
5448
run: rustup run nightly cargo clippy --all-targets --all-features -- --deny warnings

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ readme = "README.md"
1212

1313
[package.metadata]
1414
# Keep this at least 1 year old.
15-
# 1.75 is required for "-> impl Trait"
16-
msrv = "1.75.0" # Dec 28, 2023
15+
# 1.84 is required for the MSRV-aware dependency resolver
16+
msrv = "1.84.0" # Jan 9, 2025
1717

1818
[dependencies]
1919
async-lock = "3.3.0"

RELEASE_NOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# unreleased (v0.19.2)
2+
xxxx-yy-zz
3+
* MSRV raised to 1.84.0
4+
15
# v0.19.1
26
2025-03-14
37
* ureq (default non-async HTTP client impl) updated from major version 2 to 3.

clippy.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
doc-valid-idents = ["OAuth2"]
33

44
# Don't warn about things that can't be used in this version.
5-
msrv = "1.75.0"
5+
msrv = "1.84.0"

0 commit comments

Comments
 (0)