Increased warning levels

Author: drowaudio

CMakeLists.txt

@@ -4,6 +4,12 @@ project(sync_send)
 set (CMAKE_CXX_STANDARD 23)
 #set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fsanitize-address-use-after-return=runtime")
 
+if (MSVC)
+    add_compile_options(/W4 /WX)
+else()
+    add_compile_options(-Wall -Wextra -pedantic -Werror)
+endif()
+
 enable_testing()
 add_subdirectory(tests)
 add_subdirectory(include/scl)

include/scl/utils/data_race_checker.test.h

@@ -124,12 +124,12 @@ inline void test_no_data_race()
   // Then only read from the vector - no data race
   std::vector<std::thread> threads;
 
-  for (auto _ : std::ranges::iota_view (0, 3))
+  for ([[maybe_unused]] auto _ : std::ranges::iota_view (0, 3))
     threads.emplace_back([&]
                        {
-                         for (auto _ : std::ranges::iota_view (0uz, 1'000'000uz))
+                         for ([[maybe_unused]] auto _ : std::ranges::iota_view (0uz, 1'000'000uz))
                          {
-                           volatile auto c = 0uz;
+                           [[maybe_unused]] volatile auto c = 0uz;
 
                            if (! vec.empty())
                              c = vec[vec.size() - 1];
@@ -156,12 +156,12 @@ inline void test_data_race()
                        }
                      });
 
-  for (auto _ : std::ranges::iota_view (0, 3))
+  for ([[maybe_unused]] auto _ : std::ranges::iota_view (0, 3))
     threads.emplace_back([&]
                        {
                          for (;;)
                          {
-                           volatile auto c = 0uz;
+                           [[maybe_unused]] volatile auto c = 0uz;
 
                            if (! vec.empty())
                              c = vec[vec.size() - 1];
@@ -183,12 +183,12 @@ inline void test_no_data_race_read_read()
   // Then only read from the vector - no data race
   std::vector<std::thread> threads;
 
-  for (auto _ : std::ranges::iota_view (0, 3))
+  for ([[maybe_unused]] auto _ : std::ranges::iota_view (0, 3))
     threads.emplace_back([&]
                        {
-                         for (auto _ : std::ranges::iota_view (0uz, 1'000'000uz))
+                         for ([[maybe_unused]] auto _ : std::ranges::iota_view (0uz, 1'000'000uz))
                          {
-                           volatile auto c = 0uz;
+                           [[maybe_unused]] volatile auto c = 0uz;
 
                            if (! vec.empty())
                              c = vec[vec.size() - 1];

tests/fail_empty_lambda_p.cpp

@@ -14,7 +14,7 @@ int main()
         // Launch all threads.
         const int num_threads = 15;
 
-        for (int i : std::views::iota (0, num_threads))
+        for ([[maybe_unused]] int i : std::views::iota (0, num_threads))
             threads.push_back (scl::thread ([] { std::print ("Hello scl::thread"); }));
     }
 

tests/fail_reference_capture_lambda.cpp

@@ -15,9 +15,9 @@ int main()
         const int num_threads = 15;
         int mol = 42;
 
-        for (int i : std::views::iota (0, num_threads))
+        for ([[maybe_unused]] int i : std::views::iota (0, num_threads))
         {
-            static_assert(! is_send_v<decltype([&mol] {})>);
+            static_assert(! scl::is_send_v<decltype([&mol] { (void) mol; })>);
             threads.push_back (scl::thread ([&mol] { std::print ("Hello safe_thread {}", mol); }));
         }
     }

tests/fail_thread_runner.cpp

@@ -9,13 +9,13 @@ template <typename T>
 struct is_send_test : std::integral_constant<
                     bool,
                     (! (std::is_lvalue_reference_v<T>
-                        || is_lambda_v<T>))
+                        || scl::is_lambda_v<T>))
                     &&
                     (std::is_pod_v<T>
                      || std::is_move_constructible_v<T>
-                     || (is_function_pointer_v<std::decay_t<T>>
+                     || (scl::is_function_pointer_v<std::decay_t<T>>
                          && ! std::is_member_function_pointer_v<T>)
-                     || is_sync_v<T>)>
+                     || scl::is_sync_v<T>)>
 {};
 
 template<typename T> struct is_send_test<T*>        : std::false_type {};
@@ -27,7 +27,7 @@ template<typename T> struct is_send_test<const T*&>  : std::false_type {};
 template<typename T> struct is_send_test<const T*&&> : std::false_type {};
 
 template<typename T>
-void check (T&& t) {
+void check (T&&) {
     static_assert (! is_send_test<T>::value);
 }
 

tests/fail_thread_runner_with_pointer.cpp

@@ -10,7 +10,7 @@ class thread_runner
 public:
     thread_runner()
     {
-        static_assert(! is_send_v<decltype([this] { return this; })>);
+        static_assert(! scl::is_send_v<decltype([this] { return this; })>);
         int i = 42;
         auto i_ptr = &i;
         thread = std::make_unique<scl::thread> (std::mem_fn (&thread_runner::run), this, i_ptr);