additional tweaks

Author: drowl87

nodes/DynamicNode/DynamicNode.node.ts

@@ -4,9 +4,10 @@ import {
   INodeType,
   INodeTypeDescription,
   NodeOperationError,
-  NodeConnectionType,
 } from 'n8n-workflow';
-import { WorkflowExecute } from 'n8n-core';
+
+// JSON import requires "resolveJsonModule" in tsconfig
+import subWorkflowTemplate from './subWorkflowTemplate.json';
 
 export class DynamicNode implements INodeType {
   description: INodeTypeDescription = {
@@ -15,57 +16,57 @@ export class DynamicNode implements INodeType {
     icon: 'file:dynamicNode.svg',
     group: ['transform'],
     version: 1,
-    defaults: {
-      name: 'Dynamic Node',
-      color: '#00BB00',
-    },
-    inputs: ['main'] as NodeConnectionType[],
-    outputs: ['main'] as NodeConnectionType[],
+    defaults: { name: 'Dynamic Node', color: '#00BB00' },
+    inputs: ['main'],
+    outputs: ['main'],
     properties: [
       {
         displayName: 'Node JSON',
         name: 'nodeJson',
         type: 'json',
         default: {},
-        description: 'Full node definition (from a workflow export) to execute',
+        description: 'Paste in your exported node JSON here',
       },
     ],
   };
 
   async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
-    // 1) Grab and validate the JSON the user pasted in
-    const nodeJson = this.getNodeParameter('nodeJson', 0) as any;
-    if (typeof nodeJson !== 'object') {
-      throw new NodeOperationError(this.getNode(), 'The Node JSON must be a valid object');
+    // 1) Pull in the incoming items
+    const items = this.getInputData();
+
+    // 2) Get the user-provided node JSON
+    const raw = this.getNodeParameter('nodeJson', 0) as any;
+    if (typeof raw !== 'object') {
+      throw new NodeOperationError(this.getNode(), 'Node JSON must be an object');
     }
 
-    // 2) Build a one-node workflow around it
-    const workflowData = {
-      name: 'DynamicWorkflow',
-      nodes: [
-        {
-          ...nodeJson,
-          position: [0, 0],
-        },
-      ],
-      connections: {},
-    };
+    // 3) Clone the sub-workflow template
+    const template = JSON.parse(JSON.stringify(subWorkflowTemplate)) as any;
 
-    // 3) Pull in whatever “additionalData” n8n-core needs
-    //    (this.getWorkflow() is your current running workflow instance)
-    const additionalData = await (this.getWorkflow() as any).getActiveWorkflow();
-    const workflow = new WorkflowExecute(additionalData, workflowData);
+    // 4) Make sure the JSON includes a name
+    if (!raw.name) {
+      throw new NodeOperationError(this.getNode(), 'Your JSON must include a `name` field');
+    }
+    // 5) Inject the node definition
+    template.nodes.push(raw);
+    // 6) Wire Start -> your node
+    template.connections.Start.main[0][0].node = raw.name;
 
-    // 4) Run it in “manual” mode
-    const runResult = await workflow.run('manual', {} as any);
+    // 7) Execute the mini-workflow
+    const executionResult = await this.executeWorkflow(
+      { code: template },
+      items,
+    );
 
-    // 5) Extract just the data for our node by name
-    const nodeName = nodeJson.name;
-    const runData = (runResult as any).runData
-      ?.resultData
-      ?.runData[nodeName] as INodeExecutionData[][];
+    // 8) Normalize the result: either it's an array or { data }
+    let outputData: INodeExecutionData[][];
+    if (Array.isArray(executionResult)) {
+      outputData = executionResult;
+    } else {
+      outputData = (executionResult as any).data;
+    }
 
-    // 6) Return that so n8n pipes it downstream
-    return runData || [[]];
+    // 9) Prepare and return
+    return this.prepareOutputData(outputData);
   }
-}
+}

nodes/DynamicNode/subWorkflowTemplate.json

@@ -0,0 +1,25 @@
+{
+  "name": "DynamicSubflow",
+  "nodes": [
+    {
+      "parameters": {},
+      "name": "Start",
+      "type": "n8n-nodes-base.start",
+      "typeVersion": 1,
+      "position": [0, 0]
+    }
+  ],
+  "connections": {
+    "Start": {
+      "main": [
+        [
+          {
+            "node": "__PLACEHOLDER__",
+            "type": "main",
+            "index": 0
+          }
+        ]
+      ]
+    }
+  }
+}

package.json

@@ -24,9 +24,9 @@
     "pnpm": ">=9.1"
   },
   "packageManager": "[email protected]",
-  "main": "dist/DynamicNode.node.js",
+  "main": "dist/index.js",
   "scripts": {
-    "build": "tsc",
+    "build": "tsc && gulp build:icons",
     "prepare": "npm run build",
     "test": "echo \"No tests specified\" && exit 0",
     "publish": "npm publish"
@@ -38,7 +38,7 @@
     "n8nNodesApiVersion": 1,
     "credentials": [],
     "nodes": [
-      "dist/nodes/DynamicNode/DynamicNode.node.js"
+      "dist/*.node.js"
     ]
   },
   "devDependencies": {
@@ -49,9 +49,11 @@
     "prettier": "^3.5.3",
     "typescript": "^5.8.3"
   },
+  "dependencies": {
+    "n8n-workflow": "^1.90.0"
+  },
   "peerDependencies": {
-    "n8n-workflow": "*",
-    "n8n-core": "*"
+    "n8n-workflow": "^1.90.0"
   },
   "bugs": {
     "url": "https://github.com/drowl87/n8n-nodes-dynamic-node/issues"