Skip to content

Commit 438e30d

Browse files
authored
[fix] Ensuring export_pandas returns a pandas.DataFrame (#189)
1 parent d0e506a commit 438e30d

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

pydruid/query.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,9 @@ def export_pandas(self):
198198
"type: {0}".format(self.query_type)
199199
)
200200

201-
df = pandas.DataFrame(nres)
202-
return df
201+
return pandas.DataFrame(nres)
202+
203+
return pandas.DataFrame()
203204

204205
def __str__(self):
205206
return str(self.result)

tests/test_query.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,11 @@ def test_export_pandas(self):
243243
query = create_query_with_results()
244244
df = query.export_pandas()
245245
expected_df = pandas.DataFrame(EXPECTED_RESULTS_PANDAS)
246-
assert_frame_equal(df, expected_df)
246+
assert_frame_equal(df, expected_df, check_like=True)
247+
248+
query = Query({}, 'timeseries')
249+
df = query.export_pandas()
250+
assert_frame_equal(df, pandas.DataFrame())
247251

248252
def test_query_acts_as_a_wrapper_for_raw_result(self):
249253
# given
@@ -253,4 +257,3 @@ def test_query_acts_as_a_wrapper_for_raw_result(self):
253257
assert len(query) == 2
254258
assert isinstance(query[0], dict)
255259
assert isinstance(query[1], dict)
256-

0 commit comments

Comments
 (0)