Optimize project performance

Author: janslifka

app-wizard/elm/Wizard/Api/Models/BootstrapConfig.elm

@@ -82,8 +82,9 @@ decoder =
         |> D.required "registry" RegistryConfig.decoder
         |> D.required "lookAndFeel" LookAndFeelConfig.decoder
         |> D.required "organization" OrganizationConfig.decoder
-        |> D.required "pluginSettings" (D.dict D.valueAsString)
-        |> D.required "plugins" (D.list PluginInfo.decoder)
+        -- TODO remove optional
+        |> D.optional "pluginSettings" (D.dict D.valueAsString) Dict.empty
+        |> D.optional "plugins" (D.list PluginInfo.decoder) []
         |> D.required "privacyAndSupport" PrivacyAndSupportConfig.decoder
         |> D.required "project" ProjectConfig.decoder
         |> D.required "submission" SubmissionConfig.decoder

app-wizard/elm/Wizard/Api/Models/ProjectDetail/CommentThread.elm

@@ -1,4 +1,4 @@
-module Wizard.Api.Models.ProjectDetail.CommentThread exposing (CommentThread, commentCount, compare, decoder, isAssigned, isAuthor)
+module Wizard.Api.Models.ProjectDetail.CommentThread exposing (CommentThread, compare, decoder, isAssigned, isAuthor)
 
 import Common.Api.Models.UserSuggestion as UserSuggestion exposing (UserSuggestion)
 import Json.Decode as D exposing (Decoder)
@@ -48,11 +48,6 @@ compare a b =
     Time.compare a.createdAt b.createdAt
 
 
-commentCount : CommentThread -> Int
-commentCount =
-    List.length << .comments
-
-
 isAssigned : CommentThread -> Bool
 isAssigned =
     Maybe.isJust << .assignedTo

app-wizard/elm/Wizard/Api/Models/ProjectDetail/Reply/ReplyValue.elm

@@ -3,7 +3,7 @@ module Wizard.Api.Models.ProjectDetail.Reply.ReplyValue exposing
     , decoder
     , encode
     , getAnswerUuid
-    , getChoiceUuid
+    , getChoiceUuids
     , getFileUuid
     , getItemUuids
     , getSelectedItemUuid
@@ -152,8 +152,8 @@ getAnswerUuid replyValue =
             ""
 
 
-getChoiceUuid : ReplyValue -> List String
-getChoiceUuid replyValue =
+getChoiceUuids : ReplyValue -> List String
+getChoiceUuids replyValue =
     case replyValue of
         MultiChoiceReply uuids ->
             uuids

app-wizard/elm/Wizard/Api/Models/ProjectFileSimple.elm

@@ -1,10 +1,12 @@
 module Wizard.Api.Models.ProjectFileSimple exposing
     ( ProjectFileSimple
     , decoder
+    , encode
     )
 
 import Json.Decode as D exposing (Decoder)
 import Json.Decode.Pipeline as D
+import Json.Encode as E
 import Uuid exposing (Uuid)
 
 
@@ -23,3 +25,13 @@ decoder =
         |> D.required "contentType" D.string
         |> D.required "fileName" D.string
         |> D.required "fileSize" D.int
+
+
+encode : ProjectFileSimple -> E.Value
+encode file =
+    E.object
+        [ ( "uuid", Uuid.encode file.uuid )
+        , ( "contentType", E.string file.contentType )
+        , ( "fileName", E.string file.fileName )
+        , ( "fileSize", E.int file.fileSize )
+        ]

app-wizard/elm/Wizard/Api/Models/ProjectQuestionnaire.elm

@@ -24,6 +24,7 @@ module Wizard.Api.Models.ProjectQuestionnaire exposing
     , getUnresolvedCommentCount
     , getWarnings
     , hasReply
+    , hasTodo
     , isCurrentVersion
     , isPathVisible
     , itemSelectQuestionItemMissing
@@ -850,7 +851,7 @@ getItemTitleRecursive itemUuids questionnaire itemPath itemTemplateQuestions =
 
                 MultiChoiceQuestion common _ ->
                     getReply common
-                        |> Maybe.map (ReplyValue.getChoiceUuid << .value)
+                        |> Maybe.map (ReplyValue.getChoiceUuids << .value)
                         |> Maybe.andThen
                             (\uuids ->
                                 if List.isEmpty uuids then
@@ -936,15 +937,15 @@ getItemUsageInItemSelectQuestions questionnaire itemUuid =
 -- Evaluations
 
 
-calculateUnansweredQuestionsForChapter : ProjectQuestionnaire -> Chapter -> Int
+calculateUnansweredQuestionsForChapter : ProjectQuestionnaire -> String -> Int
 calculateUnansweredQuestionsForChapter questionnaire =
     Tuple.first << evaluateChapter questionnaire
 
 
-evaluateChapter : ProjectQuestionnaire -> Chapter -> ( Int, Int )
-evaluateChapter questionnaire chapter =
-    KnowledgeModel.getChapterQuestions chapter.uuid questionnaire.knowledgeModel
-        |> List.map (evaluateQuestion questionnaire [ chapter.uuid ])
+evaluateChapter : ProjectQuestionnaire -> String -> ( Int, Int )
+evaluateChapter questionnaire chapterUuid =
+    KnowledgeModel.getChapterQuestions chapterUuid questionnaire.knowledgeModel
+        |> List.map (evaluateQuestion questionnaire [ chapterUuid ])
         |> List.foldl Tuple.sum ( 0, 0 )
 
 

app-wizard/elm/Wizard/Components/Questionnaire.elm

@@ -3678,7 +3678,7 @@ viewQuestionMultiChoice appState cfg model path question =
 
         selectedChoicesUuids =
             Dict.get (pathToString path) model.questionnaire.replies
-                |> Maybe.unwrap [] (.value >> ReplyValue.getChoiceUuid)
+                |> Maybe.unwrap [] (.value >> ReplyValue.getChoiceUuids)
 
         clearReplyButton =
             viewQuestionClearButton appState cfg path (not (List.isEmpty selectedChoicesUuids))

app-wizard/elm/Wizard/Components/Questionnaire/NavigationTree.elm

@@ -89,7 +89,7 @@ viewChapterIndication : ProjectQuestionnaire -> Chapter -> Html msg
 viewChapterIndication questionnaire chapter =
     let
         unanswered =
-            ProjectQuestionnaire.calculateUnansweredQuestionsForChapter questionnaire chapter
+            ProjectQuestionnaire.calculateUnansweredQuestionsForChapter questionnaire chapter.uuid
     in
     if unanswered > 0 then
         Badge.light [ class "rounded-pill" ] [ text <| String.fromInt unanswered ]