skip keys with invalid characters

Author: dsa0x

helpers.go

@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"regexp"
 	"strings"
 	"time"
 )
@@ -34,6 +35,8 @@ var envStyleExt = map[EnvStyle]string{
 	DOTENV: "env",
 }
 
+var envNameRegex = "^[a-zA-Z0-9_]*$"
+
 // cleanUpFile removes the given file
 func cleanUpFile(filePath string) {
 	err := os.Remove(filePath)
@@ -94,6 +97,12 @@ func parseConfig(config []byte, store map[string]string, envType EnvStyle) (err
 			continue
 		}
 
+		// invalidate keys with invalid characters (only alphanumeric and _)
+		regexpKey := regexp.MustCompile(envNameRegex)
+		if !regexpKey.MatchString(cfgLine[0]) {
+			continue
+		}
+
 		store[cfgLine[0]] = strings.Join(cfgLine[1:], delim)
 		if err == io.EOF {
 			return nil

helpers_test.go

@@ -2,6 +2,7 @@ package sicher
 
 import (
 	"encoding/hex"
+	"fmt"
 	"os"
 	"testing"
 )
@@ -70,6 +71,96 @@ URI=localhost
 		t.Errorf("Expected dotenv style env not be be parseable with yaml envType")
 	}
 }
+func TestParseConfig(t *testing.T) {
+
+	tests := []struct {
+		text     string
+		expected map[string]string
+		envType  string
+	}{
+		{
+			text: `
+			PORT:8080
+			URI:localhost
+			#OLD_PORT:5000
+				`,
+			expected: map[string]string{
+				"PORT": "8080",
+				"URI":  "localhost",
+			},
+			envType: "yaml",
+		},
+		{
+			text: `
+			PORT=8080
+			URI=localhost
+			#OLD_PORT=5000
+				`,
+			expected: map[string]string{
+				"PORT": "8080",
+				"URI":  "localhost",
+			},
+			envType: "dotenv",
+		},
+		{
+			text: `
+			PORT=8080
+			URI=localhost
+			#OLD_PORT=5000
+			KEY=value=ndsjhjdghdhg
+				`,
+			expected: map[string]string{
+				"PORT": "8080",
+				"URI":  "localhost",
+				"KEY":  "value=ndsjhjdghdhg",
+			},
+			envType: "dotenv",
+		},
+		{
+			text: `
+			PORT:8080
+			URI=localhost
+				`,
+			expected: map[string]string{
+				"PORT": "8080",
+			},
+			envType: "yaml",
+		},
+		{
+			text: `
+			PORT:8080
+			URI=localhost
+			SOME_KEY:somevalue=jsfhjdghdhg
+				`,
+			expected: map[string]string{
+				"URI": "localhost",
+			},
+			envType: "dotenv",
+		},
+	}
+
+	for _, val := range tests {
+		enMap := make(map[string]string)
+		if err := parseConfig([]byte(val.text), enMap, EnvStyle(val.envType)); err != nil {
+			t.Errorf("Unable to parse config; %v", err)
+		}
+
+		t.Run(fmt.Sprintf("Envtype %s", val.envType), func(t *testing.T) {
+			for key, value := range val.expected {
+				if enMap[key] != value {
+					t.Errorf("Expected value to be %s, got %s", value, enMap[key])
+				}
+			}
+			for key, value := range enMap {
+				if val.expected[key] != value {
+					t.Errorf("Expected value to be %s, got %s", value, val.expected[key])
+				}
+			}
+		})
+	}
+
+}
+
 func TestYamlParseConfig(t *testing.T) {
 	enMap := make(map[string]string)
 	cfg := []byte(`