remove manual fnv

Author: dsa0x

bloom.go

@@ -1,8 +1,6 @@
 package gobloomgo
 
 import (
-	"bytes"
-	"encoding/gob"
 	"fmt"
 	"log"
 	"math"
@@ -53,8 +51,6 @@ func NewBloom(err_rate float64, capacity int, database Store) *BloomFilter {
 		panic("Capacity must be greater than 0")
 	}
 
-	// P = err_rate
-
 	// number of hash functions (k)
 	numHashFn := int(math.Ceil(math.Log2(1.0 / err_rate)))
 
@@ -187,31 +183,3 @@ func (bf *BloomFilter) Count() int {
 func (bf *BloomFilter) FilterSize() int {
 	return bf.bit_width
 }
-
-// https://en.wikipedia.org/wiki/Fowler%E2%80%93Noll%E2%80%93Vo_hash_function
-// fnvHash implements the Fowler–Noll–Vo hash function
-func fnvHash(key string) (int64, error) {
-	var offsetBasis, fnvPrime int64
-	offsetBasis = math.MaxInt64
-	fnvPrime = 0x100000001b3
-	hash := offsetBasis
-
-	buf := new(bytes.Buffer)
-	enc := gob.NewEncoder(buf)
-	err := enc.Encode(&key)
-	if err != nil {
-		return 0, err
-	}
-
-	for i := 0; i < buf.Len(); i++ {
-		b, err := buf.ReadByte()
-		if err != nil {
-			return 0, err
-		}
-		hash = hash * fnvPrime
-		hash = int64(uint8(hash>>8) ^ uint8(b))
-	}
-
-	return hash, nil
-
-}

bloom_test.go

@@ -30,17 +30,6 @@ func BadgerDBSetupTest(t *testing.T) (Store, func()) {
 	}
 }
 
-func TestFnvHash(t *testing.T) {
-
-	t.Run("success", func(t *testing.T) {
-		val := "hello"
-		_, err := fnvHash(val)
-		if err != nil {
-			t.Errorf("error occured when fnvHash(%s) : %s", val, err)
-		}
-	})
-}
-
 func TestBloomFilter_Add(t *testing.T) {
 	bf := NewBloom(0.01, 1000, nil)