Fixing Get-TargetResource is reporting error when cluster is not found (#284)

- Cluster
  - Fixed Get-TargetResource is reporting error when cluster is not found (issue #283).

Author: webalexeu

CHANGELOG.md

@@ -7,6 +7,11 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
 
 ## [Unreleased]
 
+### Fixed
+
+- Cluster
+  - Fixed Get-TargetResource is reporting error when cluster is not found ([issue #283](https://github.com/dsccommunity/FailOverClusterDsc/issues/283)).
+
 ### Changed
 
 - FailoverClusterDsc

source/DSCResources/DSC_Cluster/DSC_Cluster.psm1

@@ -75,12 +75,14 @@ function Get-TargetResource
         $cluster = Get-Cluster -Name $Name -Domain $computerInformation.Domain
         if ($null -eq $cluster)
         {
-            $errorMessage = $script:localizedData.ClusterNameNotFound -f $Name
-            New-ObjectNotFoundException -Message $errorMessage
+            Write-Verbose -Message ($script:localizedData.ClusterNameNotFound -f $Name)
+            # Future improvement: Manage Ensure state.
+        }
+        else
+        {
+            # This will return the IP address regardless if using Static IP or DHCP.
+            $address = Get-ClusterResource -Cluster $Name -Name 'Cluster IP Address' | Get-ClusterParameter -Name 'Address'
         }
-
-        # This will return the IP address regardless if using Static IP or DHCP.
-        $address = Get-ClusterResource -Cluster $Name -Name 'Cluster IP Address' | Get-ClusterParameter -Name 'Address'
     }
     finally
     {

tests/Unit/DSC_Cluster.Tests.ps1

@@ -182,15 +182,16 @@ foreach ($moduleVersion in @('2012', '2016'))
                 }
 
                 Context 'When the cluster cannot be found' {
-                    It 'Should throw the correct error message' {
+                    It 'Should returns the cluster name' {
                         $mockDynamicDomainName = $mockDomainName
                         $mockDynamicServerName = $mockServerName
 
                         Mock -CommandName Get-Cluster -Verifiable
                         Mock -CommandName Get-CimInstance -MockWith $mockGetCimInstance -ParameterFilter $mockGetCimInstance_ParameterFilter -Verifiable
 
-                        $mockCorrectErrorRecord = Get-ObjectNotFoundException -Message ($script:localizedData.ClusterNameNotFound -f $mockClusterName)
-                        { Get-TargetResource @mockGetTargetResourceParameters } | Should -Throw $mockCorrectErrorRecord
+                        $getTargetResourceResult = Get-TargetResource @mockGetTargetResourceParameters
+
+                        $getTargetResourceResult.Name | Should -Be $mockDefaultParameters.Name
                     }
                 }