Refactor integration tests for Add-SqlDscDataFile and Add-SqlDscFileGroup to use real SMO Database and FileGroup objects; add AfterAll cleanup for database connections.

Author: johlju

tests/Integration/Commands/Add-SqlDscDataFile.Integration.Tests.ps1

@@ -27,22 +27,25 @@ BeforeAll {
     $script:moduleName = 'SqlServerDsc'
 
     Import-Module -Name $script:moduleName -Force -ErrorAction 'Stop'
+}
 
-    # Import the SMO module to ensure real SMO types are available
-    Import-SqlDscPreferredModule
+Describe 'Add-SqlDscDataFile' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
+    BeforeAll {
+        $script:mockInstanceName = 'DSCSQLTEST'
+        $script:mockComputerName = Get-ComputerName
 
-    $script:mockInstanceName = 'DSCSQLTEST'
-    $script:mockComputerName = Get-ComputerName
+        $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
+        $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
 
-    $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
-    $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
+        $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
 
-    $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
+        $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
+    }
 
-    $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
-}
+    AfterAll {
+        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
+    }
 
-Describe 'Add-SqlDscDataFile' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     Context 'When adding a DataFile to a FileGroup with real SMO types' {
         BeforeEach {
             # Create real SMO Database and FileGroup objects
@@ -103,25 +106,4 @@ Describe 'Add-SqlDscDataFile' -Tag @('Integration_SQL2017', 'Integration_SQL2019
             $result[1] | Should -Be $dataFile2
         }
     }
-
-    Context 'When verifying DataFile parent relationship' {
-        BeforeEach {
-            $script:testDatabase = [Microsoft.SqlServer.Management.Smo.Database]::new()
-            $script:testDatabase.Name = 'TestDatabase'
-            $script:testDatabase.Parent = $script:serverObject
-
-            $script:testFileGroup = New-SqlDscFileGroup -Database $script:testDatabase -Name 'TestFileGroup' -Confirm:$false
-            $script:testDataFile = New-SqlDscDataFile -FileGroup $script:testFileGroup -Name 'TestDataFile' -FileName 'C:\Data\TestDataFile.ndf' -Confirm:$false
-        }
-
-        It 'Should update DataFile parent reference when added to FileGroup' {
-            $script:testDataFile.Parent | Should -BeNullOrEmpty
-
-            Add-SqlDscDataFile -FileGroup $script:testFileGroup -DataFile $script:testDataFile
-
-            # Note: The parent may or may not be updated depending on SMO implementation
-            # This test verifies the DataFile is in the collection
-            $script:testFileGroup.Files[$script:testDataFile.Name] | Should -Be $script:testDataFile
-        }
-    }
 }

tests/Integration/Commands/Add-SqlDscFileGroup.Integration.Tests.ps1

@@ -27,22 +27,25 @@ BeforeAll {
     $script:moduleName = 'SqlServerDsc'
 
     Import-Module -Name $script:moduleName -Force -ErrorAction 'Stop'
+}
 
-    # Import the SMO module to ensure real SMO types are available
-    Import-SqlDscPreferredModule
+Describe 'Add-SqlDscFileGroup' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
+    BeforeAll {
+        $script:mockInstanceName = 'DSCSQLTEST'
+        $script:mockComputerName = Get-ComputerName
 
-    $script:mockInstanceName = 'DSCSQLTEST'
-    $script:mockComputerName = Get-ComputerName
+        $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
+        $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
 
-    $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
-    $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
+        $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
 
-    $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
+        $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
+    }
 
-    $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
-}
+    AfterAll {
+        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
+    }
 
-Describe 'Add-SqlDscFileGroup' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     Context 'When adding a FileGroup to a Database with real SMO types' {
         BeforeEach {
             # Create real SMO Database object

tests/Integration/Commands/New-SqlDscDataFile.Integration.Tests.ps1

@@ -33,7 +33,7 @@ BeforeAll {
 }
 
 Describe 'New-SqlDscDataFile' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
-        BeforeAll {
+    BeforeAll {
         $script:mockInstanceName = 'DSCSQLTEST'
         $script:mockComputerName = Get-ComputerName
 
@@ -45,6 +45,10 @@ Describe 'New-SqlDscDataFile' -Tag @('Integration_SQL2017', 'Integration_SQL2019
         $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
     }
 
+    AfterAll {
+        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
+    }
+
     Context 'When creating a DataFile with a FileGroup object' {
         BeforeAll {
             # Create a real SMO Database object

tests/Integration/Commands/New-SqlDscFileGroup.Integration.Tests.ps1

@@ -45,6 +45,10 @@ Describe 'New-SqlDscFileGroup' -Tag @('Integration_SQL2017', 'Integration_SQL201
         $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
     }
 
+    AfterAll {
+        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
+    }
+
     Context 'When creating a standalone FileGroup with real SMO types' {
         It 'Should create a standalone FileGroup successfully' {
             $result = New-SqlDscFileGroup -Name 'TestFileGroup'
@@ -106,21 +110,4 @@ Describe 'New-SqlDscFileGroup' -Tag @('Integration_SQL2017', 'Integration_SQL201
             $result | Should -BeNullOrEmpty
         }
     }
-
-    Context 'When verifying FileGroup properties' {
-        BeforeAll {
-            # Create a real SMO Database object
-            $script:propertyTestDatabase = [Microsoft.SqlServer.Management.Smo.Database]::new()
-            $script:propertyTestDatabase.Name = 'PropertyTestDatabase'
-            $script:propertyTestDatabase.Parent = $script:serverObject
-        }
-
-        It 'Should have Files collection initialized when attached to a Database' {
-            $result = New-SqlDscFileGroup -Database $script:propertyTestDatabase -Name 'TestFileGroup' -Confirm:$false
-
-            $result.Files | Should -Not -BeNullOrEmpty
-            $result.Files | Should -BeOfType 'Microsoft.SqlServer.Management.Smo.DataFileCollection'
-            $result.Files.Count | Should -Be 0
-        }
-    }
 }