Refactor ConvertToSmoEnumType methods in SqlResourceBase for improved clarity and error handling

Author: johlju

source/Classes/011.SqlResourceBase.ps1

@@ -136,43 +136,30 @@ class SqlResourceBase : ResourceBase
         return $this.SqlServerObject
     }
 
-    <#
-        .SYNOPSIS
+    # TypeName: The SMO enum type name (e.g., 'RecoveryModel'). Value: The string to convert.
+    hidden [System.Object] ConvertToSmoEnumType([System.String] $TypeName, [System.String] $Value)
+    {
+        return $this.ConvertToSmoEnumType($TypeName, $Value, 'Microsoft.SqlServer.Management.Smo')
+    }
+
+    # TypeName: The SMO enum type name. Value: The string to convert. Namespace: The namespace (prepended if TypeName has no dot).
+    hidden [System.Object] ConvertToSmoEnumType([System.String] $TypeName, [System.String] $Value, [System.String] $Namespace)
+    {
+        <#
             Converts a string value to the corresponding SMO enum type at runtime.
 
-        .DESCRIPTION
             This helper method is required because PowerShell parses class definitions
             at module load time. Direct SMO type literals (e.g., [SMOType]::Value)
             would fail because SMO assemblies may not be loaded yet.
 
             This method uses runtime type resolution to avoid parse-time errors.
 
-        .PARAMETER TypeName
-            The name of the SMO enum type (e.g., 'RecoveryModel'). If the type name
-            does not contain a dot, the Namespace parameter is prepended.
-
-        .PARAMETER Value
-            The string value to convert to the enum type.
-
-        .PARAMETER Namespace
-            The namespace of the SMO enum type. Defaults to 'Microsoft.SqlServer.Management.Smo'.
-
-        .OUTPUTS
-            The SMO enum value.
-
-        .NOTES
             This is required due to PowerShell's class parsing behavior. We cannot
             use SMO types directly in the class definition, because they may not be
             installed when the module is imported. The user also decides which SMO
             to use (SQLPS, SqlServer, dbatools).
-    #>
-    hidden [System.Object] ConvertToSmoEnumType([System.String] $TypeName, [System.String] $Value)
-    {
-        return $this.ConvertToSmoEnumType($TypeName, $Value, 'Microsoft.SqlServer.Management.Smo')
-    }
+        #>
 
-    hidden [System.Object] ConvertToSmoEnumType([System.String] $TypeName, [System.String] $Value, [System.String] $Namespace)
-    {
         # If the type name doesn't contain a dot, prepend the namespace
         $fullTypeName = if ($TypeName -notmatch '\.')
         {
@@ -205,8 +192,25 @@ class SqlResourceBase : ResourceBase
                 #>
                 $sqlServerAssemblies = [System.AppDomain]::CurrentDomain.GetAssemblies() |
                     Where-Object -FilterScript {
-                        $_.FullName -like 'Microsoft.SqlServer.*' -or
-                        $_.ExportedTypes.FullName -like 'Microsoft.SqlServer.*'
+                        if ($_.FullName -like 'Microsoft.SqlServer.*')
+                        {
+                            return $true
+                        }
+
+                        <#
+                            Check if assembly exports Microsoft.SqlServer types (for
+                            stub types in unit tests). Wrap in try-catch because some
+                            assemblies like Microsoft.Data.SqlClient throw
+                            ReflectionTypeLoadException when accessing ExportedTypes.
+                        #>
+                        try
+                        {
+                            return $_.ExportedTypes.FullName -like 'Microsoft.SqlServer.*'
+                        }
+                        catch
+                        {
+                            return $false
+                        }
                     }
 
                 foreach ($assembly in $sqlServerAssemblies)