Skip to content

Commit 1eb69be

Browse files
committed
fix integ test
1 parent 45fd312 commit 1eb69be

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ The format is based on and uses the types of changes according to [Keep a Change
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

66
## [Unreleased]
7+
78
### Removed
89

910
- SqlServerDsc.Common
@@ -94,6 +95,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
9495
- Change the alias command to real command name, to pass HQRM tests.
9596
- `SqlServiceAccount`
9697
- Change the alias command to real command name, to pass HQRM tests.
98+
- `Get-SqlDscRSSetupConfiguration`
99+
- The integration test was updated to verify so that the `CurrentVersion`
100+
and `ProductVersion` strings can be converted to valid versions and
101+
that they always are higher than what we expect.
97102

98103
## [17.0.0] - 2024-09-30
99104

tests/Integration/Commands/Get-SqlDscRSSetupConfiguration.Integration.Tests.ps1

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Describe 'Get-SqlDscRSSetupConfiguration' {
3737
$result.InstallFolder | Should -Be 'C:\Program Files\SSRS'
3838
$result.ServiceName | Should -Be 'SQLServerReportingServices'
3939
$result.ErrorDumpDirectory | Should -Be 'C:\Program Files\SSRS\SSRS\LogFiles'
40-
$result.CurrentVersion | Should -Be '14.0.601.20'
40+
[System.Version] $result.CurrentVersion | Should -BeGreaterOrEqual ([System.Version] '14.0.601.20')
4141
$result.ProductVersion | Should -BeNullOrEmpty
4242
$result.CustomerFeedback | Should -Be 1
4343
$result.EnableErrorReporting | Should -Be 1
@@ -59,8 +59,8 @@ Describe 'Get-SqlDscRSSetupConfiguration' {
5959
$result.InstallFolder | Should -Be 'C:\Program Files\SSRS'
6060
$result.ServiceName | Should -Be 'SQLServerReportingServices'
6161
$result.ErrorDumpDirectory | Should -Be 'C:\Program Files\SSRS\SSRS\LogFiles'
62-
$result.CurrentVersion | Should -Be '15.0.1103.41'
63-
$result.ProductVersion | Should -Be '15.0.9098.6826'
62+
[System.Version] $result.CurrentVersion | Should -BeGreaterOrEqual ([System.Version] '15.0.1103.41')
63+
[System.Version] $result.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '15.0.9098.6826')
6464
$result.CustomerFeedback | Should -Be 1
6565
$result.EnableErrorReporting | Should -Be 1
6666
$result.VirtualRootServer | Should -Be 'ReportServer'
@@ -81,8 +81,8 @@ Describe 'Get-SqlDscRSSetupConfiguration' {
8181
$result.InstallFolder | Should -Be 'C:\Program Files\SSRS'
8282
$result.ServiceName | Should -Be 'SQLServerReportingServices'
8383
$result.ErrorDumpDirectory | Should -Be 'C:\Program Files\SSRS\SSRS\LogFiles'
84-
$result.CurrentVersion | Should -Be '16.0.1116.38'
85-
$result.ProductVersion | Should -Be '16.0.9101.19239'
84+
[System.Version] $result.CurrentVersion | Should -BeGreaterOrEqual ([System.Version] '16.0.1116.38')
85+
[System.Version] $result.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '16.0.9101.19239')
8686
$result.CustomerFeedback | Should -Be 1
8787
$result.EnableErrorReporting | Should -Be 1
8888
$result.VirtualRootServer | Should -Be 'ReportServer'
@@ -102,8 +102,8 @@ Describe 'Get-SqlDscRSSetupConfiguration' {
102102
$result.InstallFolder | Should -Be 'C:\Program Files\PBIRS'
103103
$result.ServiceName | Should -Be 'PowerBIReportServer'
104104
$result.ErrorDumpDirectory | Should -Be 'C:\Program Files\PBIRS\PBIRS\LogFiles'
105-
$result.CurrentVersion | Should -Be '15.0.1117.98'
106-
$result.ProductVersion | Should -Be '1.22.9153.7886'
105+
[System.Version] $result.CurrentVersion | Should -BeGreaterOrEqual ([System.Version] '15.0.1117.98')
106+
[System.Version] $result.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '1.22.9153.7886')
107107
$result.CustomerFeedback | Should -Be 1
108108
$result.EnableErrorReporting | Should -Be 1
109109
$result.VirtualRootServer | Should -Be 'ReportServer'

0 commit comments

Comments
 (0)