Refactor integration tests to remove unnecessary comments about SQL Server service state

- Removed comments indicating that the SQL Server service is already running for performance optimization from multiple integration test files.
- Cleaned up AfterAll sections to enhance readability and maintainability of the test scripts.

Author: johlju

tests/Integration/Commands/Assert-SqlDscAgentOperator.Integration.Tests.ps1

@@ -43,8 +43,6 @@ AfterAll {
 
 Describe 'Assert-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022' {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
         $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
 
@@ -62,8 +60,6 @@ Describe 'Assert-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_S
 
         # Disconnect from the SQL Server
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:sqlServerObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     Context 'When operator exists' {

tests/Integration/Commands/Assert-SqlDscLogin.Integration.Tests.ps1

@@ -31,16 +31,10 @@ BeforeAll {
 
 Describe 'Assert-SqlDscLogin' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:instanceName = 'DSCSQLTEST'
         $script:computerName = Get-ComputerName
     }
 
-    AfterAll {
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
-    }
-
     Context 'When connecting to SQL Server instance' {
         BeforeAll {
             $sqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.

tests/Integration/Commands/ConvertTo-SqlDscDatabasePermission.Integration.Tests.ps1

@@ -31,8 +31,6 @@ BeforeAll {
 
 Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:mockInstanceName = 'DSCSQLTEST'
 
         $mockSqlAdministratorUserName = 'SqlAdmin'
@@ -45,22 +43,19 @@ Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Int
 
     AfterAll {
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
-
     Context 'When converting empty collection of DatabasePermissionInfo' {
         It 'Should return empty array for empty DatabasePermissionInfo collection' {
             $emptyCollection = [Microsoft.SqlServer.Management.Smo.DatabasePermissionInfo[]] @()
-            
+
             $result = ConvertTo-SqlDscDatabasePermission -DatabasePermissionInfo $emptyCollection
 
             $result | Should -BeNullOrEmpty
         }
 
         It 'Should accept empty collection through pipeline' {
             $emptyCollection = [Microsoft.SqlServer.Management.Smo.DatabasePermissionInfo[]] @()
-            
+
             $result = $emptyCollection | ConvertTo-SqlDscDatabasePermission
 
             $result | Should -BeNullOrEmpty
@@ -78,12 +73,12 @@ Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Int
 
                 # Validate the result structure
                 $result | Should -Not -BeNullOrEmpty
-                
+
                 # Each result should have State and Permission properties
                 foreach ($permission in $result) {
                     $permission.State | Should -Not -BeNullOrEmpty
                     $permission.Permission | Should -Not -BeNullOrEmpty
-                    
+
                     # Validate that permission state is one of the expected values
                     $permission.State | Should -BeIn @('Grant', 'Deny', 'GrantWithGrant')
                 }
@@ -100,12 +95,12 @@ Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Int
 
                 # Validate the result structure
                 $result | Should -Not -BeNullOrEmpty
-                
+
                 # Each result should have State and Permission properties
                 foreach ($permission in $result) {
                     $permission.State | Should -Not -BeNullOrEmpty
                     $permission.Permission | Should -Not -BeNullOrEmpty
-                    
+
                     # Validate that permission state is one of the expected values
                     $permission.State | Should -BeIn @('Grant', 'Deny', 'GrantWithGrant')
                 }
@@ -124,12 +119,12 @@ Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Int
 
                 # Validate the result structure
                 $result | Should -Not -BeNullOrEmpty
-                
+
                 # Each result should have State and Permission properties
                 foreach ($permission in $result) {
                     $permission.State | Should -Not -BeNullOrEmpty
                     $permission.Permission | Should -Not -BeNullOrEmpty
-                    
+
                     # Validate that permission state is one of the expected values
                     $permission.State | Should -BeIn @('Grant', 'Deny', 'GrantWithGrant')
                 }
@@ -149,7 +144,7 @@ Describe 'ConvertTo-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'Int
                 if ($result) {
                     # Validate that permissions are properly grouped by state
                     $uniqueStates = $result.State | Sort-Object -Unique
-                    
+
                     foreach ($state in $uniqueStates) {
                         $permissionsForState = $result | Where-Object { $_.State -eq $state }
                         $permissionsForState | Should -HaveCount 1

tests/Integration/Commands/Deny-SqlDscServerPermission.Integration.Tests.ps1

@@ -31,8 +31,6 @@ BeforeAll {
 
 Describe 'Deny-SqlDscServerPermission' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:mockInstanceName = 'DSCSQLTEST'
 
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
@@ -49,8 +47,6 @@ Describe 'Deny-SqlDscServerPermission' -Tag @('Integration_SQL2017', 'Integratio
 
     AfterAll {
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     Context 'When denying server permissions to login' {

tests/Integration/Commands/Disable-SqlDscAgentOperator.Integration.Tests.ps1

@@ -43,8 +43,6 @@ AfterAll {
 
 Describe 'Disable-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022' {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
         $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
         $mockSqlAdministratorCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
@@ -60,9 +58,6 @@ Describe 'Disable-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_
         Set-SqlDscConfigurationOption -ServerObject $script:serverObject -Name 'Agent XPs' -Value 0 -Force -Verbose -ErrorAction 'Stop'
 
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Stopping the named instance SQL Server service after running tests.
-        Stop-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop'
     }
 
     Context 'When disabling an existing agent operator' {

tests/Integration/Commands/Disable-SqlDscAudit.Integration.Tests.ps1

@@ -31,8 +31,6 @@ BeforeAll {
 
 Describe 'Disable-SqlDscAudit' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:mockInstanceName = 'DSCSQLTEST'
         $script:mockComputerName = Get-ComputerName
 
@@ -46,8 +44,6 @@ Describe 'Disable-SqlDscAudit' -Tag @('Integration_SQL2017', 'Integration_SQL201
 
     AfterAll {
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     Context 'When disabling an audit using ServerObject parameter set' {
@@ -204,7 +200,7 @@ Describe 'Disable-SqlDscAudit' -Tag @('Integration_SQL2017', 'Integration_SQL201
                 'SqlDscTestMultiDisable1_' + (Get-Random),
                 'SqlDscTestMultiDisable2_' + (Get-Random)
             )
-            
+
             foreach ($auditName in $script:testAuditNames)
             {
                 $null = New-SqlDscAudit -ServerObject $script:serverObject -Name $auditName -LogType 'ApplicationLog' -Force -ErrorAction Stop

tests/Integration/Commands/Disable-SqlDscLogin.Integration.Tests.ps1

@@ -31,8 +31,6 @@ BeforeAll {
 
 Describe 'Disable-SqlDscLogin' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:mockInstanceName = 'DSCSQLTEST'
 
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
@@ -48,8 +46,6 @@ Describe 'Disable-SqlDscLogin' -Tag @('Integration_SQL2017', 'Integration_SQL201
 
     AfterAll {
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     Context 'When disabling a login using ServerObject parameter set' {

tests/Integration/Commands/Enable-SqlDscAgentOperator.Integration.Tests.ps1

@@ -43,8 +43,6 @@ AfterAll {
 
 Describe 'Enable-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022' {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
         $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
         $mockSqlAdministratorCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
@@ -60,9 +58,6 @@ Describe 'Enable-SqlDscAgentOperator' -Tag 'Integration_SQL2017', 'Integration_S
         Set-SqlDscConfigurationOption -ServerObject $script:serverObject -Name 'Agent XPs' -Value 0 -Force -Verbose -ErrorAction 'Stop'
 
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Stopping the named instance SQL Server service after running tests.
-        Stop-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop'
     }
 
     Context 'When enabling an existing agent operator' {

tests/Integration/Commands/Enable-SqlDscLogin.Integration.Tests.ps1

@@ -31,8 +31,6 @@ BeforeAll {
 
 Describe 'Enable-SqlDscLogin' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') {
     BeforeAll {
-        # Note: SQL Server service is already running from Install-SqlDscServer test for performance optimization
-
         $script:mockInstanceName = 'DSCSQLTEST'
 
         $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
@@ -48,8 +46,6 @@ Describe 'Enable-SqlDscLogin' -Tag @('Integration_SQL2017', 'Integration_SQL2019
 
     AfterAll {
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     Context 'When enabling a login using ServerObject parameter set' {

tests/Integration/Commands/Get-SqlDscAgentAlert.Integration.Tests.ps1

@@ -74,8 +74,6 @@ END
 
         # Disconnect from the SQL Server
         Disconnect-SqlDscDatabaseEngine -ServerObject $script:sqlServerObject
-
-        # Note: SQL Server service is left running for subsequent tests for performance optimization
     }
 
     It 'Should get all alerts' {