Enhance error handling in New-SqlDscLogin.Tests by enforcing module import failure checks

johlju · johlju · commit 30d9e6f70535 · 2025-08-18T12:51:40.000+02:00
diff --git a/tests/Unit/Public/New-SqlDscLogin.Tests.ps1 b/tests/Unit/Public/New-SqlDscLogin.Tests.ps1
@@ -29,7 +29,7 @@ BeforeAll {
 
     $env:SqlServerDscCI = $true
 
-    Import-Module -Name $script:dscModuleName -Force
+    Import-Module -Name $script:dscModuleName -Force -ErrorAction 'Stop'
 
     # Loading mocked classes
     Add-Type -Path (Join-Path -Path (Join-Path -Path $PSScriptRoot -ChildPath '../Stubs') -ChildPath 'SMO.cs')
@@ -308,10 +308,6 @@ Describe 'New-SqlDscLogin' -Tag 'Public' {
 
                 Should -Invoke -CommandName Test-SqlDscIsLogin -Exactly -Times 1 -Scope It
             }
-
-            It 'Should call Create method on login object' {
-                New-SqlDscLogin -ServerObject $script:mockServerObject -Name 'TestLogin' -SqlLogin -SecurePassword $script:mockSecurePassword -Confirm:$false
-            }
         }
 
         Context 'When creating a Windows user login' {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ BeforeAll {`
`29`	`29`
`30`	`30`	`$env:SqlServerDscCI = $true`
`31`	`31`
`32`		`- Import-Module -Name $script:dscModuleName -Force`
	`32`	`+ Import-Module -Name $script:dscModuleName -Force -ErrorAction 'Stop'`
`33`	`33`
`34`	`34`	`# Loading mocked classes`
`35`	`35`	`Add-Type -Path (Join-Path -Path (Join-Path -Path $PSScriptRoot -ChildPath '../Stubs') -ChildPath 'SMO.cs')`
`@@ -308,10 +308,6 @@ Describe 'New-SqlDscLogin' -Tag 'Public' {`
`308`	`308`
`309`	`309`	`Should -Invoke -CommandName Test-SqlDscIsLogin -Exactly -Times 1 -Scope It`
`310`	`310`	`}`
`311`		`-`
`312`		`- It 'Should call Create method on login object' {`
`313`		`- New-SqlDscLogin -ServerObject $script:mockServerObject -Name 'TestLogin' -SqlLogin -SecurePassword $script:mockSecurePassword -Confirm:$false`
`314`		`- }`
`315`	`311`	`}`
`316`	`312`
`317`	`313`	`Context 'When creating a Windows user login' {`