Refactor test for Assert-SetupActionProperties to simplify syntax and improve readability

johlju · johlju · commit 4947e324dc83 · 2025-12-27T12:56:48.000+01:00
diff --git a/tests/Unit/Private/Assert-SetupActionProperties.Tests.ps1 b/tests/Unit/Private/Assert-SetupActionProperties.Tests.ps1
@@ -608,12 +608,10 @@ Describe 'Assert-SetupActionProperties' -Tag 'Private' {
 
         It 'Should not throw an exception' {
             InModuleScope -ScriptBlock {
-                {
-                    Assert-SetupActionProperties -Property @{
-                        MediaPath = $TestDrive
-                        AllowDqRemoval = $true
-                    } -SetupAction 'Upgrade'
-                } | Should -Not -Throw
+                Assert-SetupActionProperties -Property @{
+                    MediaPath      = $TestDrive
+                    AllowDqRemoval = $true
+                } -SetupAction 'Upgrade'
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -608,12 +608,10 @@ Describe 'Assert-SetupActionProperties' -Tag 'Private' {`
`608`	`608`
`609`	`609`	`It 'Should not throw an exception' {`
`610`	`610`	`InModuleScope -ScriptBlock {`
`611`		`- {`
`612`		`- Assert-SetupActionProperties -Property @{`
`613`		`- MediaPath = $TestDrive`
`614`		`- AllowDqRemoval = $true`
`615`		`- } -SetupAction 'Upgrade'`
`616`		`- } \| Should -Not -Throw`
	`611`	`+ Assert-SetupActionProperties -Property @{`
	`612`	`+ MediaPath = $TestDrive`
	`613`	`+ AllowDqRemoval = $true`
	`614`	`+ } -SetupAction 'Upgrade'`
`617`	`615`	`}`
`618`	`616`	`}`
`619`	`617`	`}`