Skip to content

Commit 51e1811

Browse files
Copilotjohlju
andcommitted
Fix integration test expectation for multiple pipeline objects - command combines permissions into single result
Co-authored-by: johlju <7189721+johlju@users.noreply.github.com>
1 parent 34fac99 commit 51e1811

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

tests/Integration/Commands/ConvertFrom-SqlDscDatabasePermission.Integration.Tests.ps1

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ Describe 'ConvertFrom-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'I
155155
}
156156

157157
Context 'When processing multiple DatabasePermission objects through pipeline' {
158-
It 'Should process each permission object and return multiple DatabasePermissionSet objects' {
158+
It 'Should process each permission object and combine them into single DatabasePermissionSet object' {
159159
$databasePermissions = & (Get-Module -Name $script:moduleName) {
160160
@(
161161
[DatabasePermission] @{
@@ -169,21 +169,19 @@ Describe 'ConvertFrom-SqlDscDatabasePermission' -Tag @('Integration_SQL2017', 'I
169169
)
170170
}
171171

172-
$results = $databasePermissions | ConvertFrom-SqlDscDatabasePermission -ErrorAction 'Stop'
172+
$result = $databasePermissions | ConvertFrom-SqlDscDatabasePermission -ErrorAction 'Stop'
173173

174-
$results | Should -Not -BeNullOrEmpty
175-
$results.Count | Should -Be 2
176-
$results[0] | Should -BeOfType [Microsoft.SqlServer.Management.Smo.DatabasePermissionSet]
177-
$results[1] | Should -BeOfType [Microsoft.SqlServer.Management.Smo.DatabasePermissionSet]
178-
179-
# First permission set should have Connect
180-
$results[0].Connect | Should -BeTrue
181-
$results[0].Select | Should -BeFalse
174+
# The command combines all permissions into a single DatabasePermissionSet
175+
$result | Should -Not -BeNullOrEmpty
176+
$result | Should -BeOfType [Microsoft.SqlServer.Management.Smo.DatabasePermissionSet]
182177

183-
# Second permission set should have Select and Update
184-
$results[1].Connect | Should -BeFalse
185-
$results[1].Select | Should -BeTrue
186-
$results[1].Update | Should -BeTrue
178+
# All permissions from both objects should be set to true
179+
$result.Connect | Should -BeTrue
180+
$result.Select | Should -BeTrue
181+
$result.Update | Should -BeTrue
182+
$result.Insert | Should -BeFalse
183+
$result.Delete | Should -BeFalse
184+
}
187185
}
188186
}
189187

0 commit comments

Comments
 (0)