Replace try-catch blocks with $ErrorActionPreference = 'Stop'

Co-authored-by: johlju <[email protected]>

Author: Copilot

source/Private/Invoke-ReportServerSetupAction.ps1

@@ -196,20 +196,14 @@ function Invoke-ReportServerSetupAction
         $PassThru
     )
 
+    $ErrorActionPreference = 'Stop'
+
     if ($Force.IsPresent -and -not $Confirm)
     {
         $ConfirmPreference = 'None'
     }
 
-    try
-    {
-        Assert-ElevatedUser -ErrorAction 'Stop'
-    }
-    catch
-    {
-        # Re-throw the error to ensure the function terminates
-        $PSCmdlet.ThrowTerminatingError($_)
-    }
+    Assert-ElevatedUser -ErrorAction 'Stop'
 
     $assertBoundParameters = @{
         BoundParameterList     = $PSBoundParameters

source/Private/Invoke-SetupAction.ps1

@@ -1372,20 +1372,14 @@ function Invoke-SetupAction
         $Force
     )
 
+    $ErrorActionPreference = 'Stop'
+
     if ($Force.IsPresent -and -not $Confirm)
     {
         $ConfirmPreference = 'None'
     }
 
-    try
-    {
-        Assert-ElevatedUser -ErrorAction 'Stop'
-    }
-    catch
-    {
-        # Re-throw the error to ensure the function terminates
-        $PSCmdlet.ThrowTerminatingError($_)
-    }
+    Assert-ElevatedUser -ErrorAction 'Stop'
 
     switch ($PSCmdlet.ParameterSetName)
     {

source/Public/Get-SqlDscStartupParameter.ps1

@@ -65,15 +65,9 @@ function Get-SqlDscStartupParameter
         $InstanceName = 'MSSQLSERVER'
     )
 
-    try
-    {
-        Assert-ElevatedUser -ErrorAction 'Stop'
-    }
-    catch
-    {
-        # Re-throw the error to ensure the function terminates
-        $PSCmdlet.ThrowTerminatingError($_)
-    }
+    $ErrorActionPreference = 'Stop'
+
+    Assert-ElevatedUser -ErrorAction 'Stop'
 
     if ($PSCmdlet.ParameterSetName -eq 'ByServiceObject')
     {

source/Public/Set-SqlDscStartupParameter.ps1

@@ -91,15 +91,9 @@ function Set-SqlDscStartupParameter
 
     begin
     {
-        try
-        {
-            Assert-ElevatedUser -ErrorAction 'Stop'
-        }
-        catch
-        {
-            # Re-throw the error to ensure the function terminates
-            $PSCmdlet.ThrowTerminatingError($_)
-        }
+        $ErrorActionPreference = 'Stop'
+
+        Assert-ElevatedUser -ErrorAction 'Stop'
 
         if ($Force.IsPresent -and -not $Confirm)
         {