Add support for discontinued features in SQL Server 2025 and update tests

Author: johlju

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- `Test-SqlDscIsSupportedFeature`
+  - Added DQ, DQC, and MDS features as discontinued starting with SQL Server 2025
+    (17.x) and later versions ([issue #2380](https://github.com/dsccommunity/SqlServerDsc/issues/2380)).
 - Added public command `Get-SqlDscRSPackage` to retrieve package information for
   SQL Server Reporting Services or Power BI Report Server. Supports getting version
   information from an executable file

source/Private/Assert-SetupActionProperties.ps1

@@ -42,12 +42,19 @@ function Assert-SetupActionProperties
         $SetupAction
     )
 
+    $setupExecutableFileVersion = $null
+
+    <#
+        Assumes that the MediaPath parameter is always specified as this should
+        only be called internally by Invoke-SetupAction that have MediaPath as a
+        mandatory parameter.
+    #>
+    $setupExecutableFileVersion = $Property.MediaPath |
+        Join-Path -ChildPath 'setup.exe' |
+        Get-FileVersion
+
     if ($Property.ContainsKey('Features'))
     {
-        $setupExecutableFileVersion = $Property.MediaPath |
-            Join-Path -ChildPath 'setup.exe' |
-            Get-FileVersion
-
         $Property.Features |
             Assert-Feature -ProductVersion $setupExecutableFileVersion.ProductVersion
     }
@@ -242,10 +249,6 @@ function Assert-SetupActionProperties
     # The parameter AllowDqRemoval is only allowed for SQL Server 2025 (17.x) and later versions.
     if ($Property.ContainsKey('AllowDqRemoval'))
     {
-        $setupExecutableFileVersion = $Property.MediaPath |
-            Join-Path -ChildPath 'setup.exe' |
-            Get-FileVersion
-
         $majorVersion = $setupExecutableFileVersion.ProductVersion.Split('.')[0]
 
         if ([System.Int32] $majorVersion -lt 17)

source/Public/Test-SqlDscIsSupportedFeature.ps1

@@ -54,6 +54,7 @@ function Test-SqlDscIsSupportedFeature
             13 = @('ADV_SSMS', 'SSMS') # cSpell: disable-line
             14 = @('RS', 'RS_SHP', 'RS_SHPWFE') # cSpell: disable-line
             16 = @('Tools', 'BC', 'CONN', 'BC', 'DREPLAY_CTLR', 'DREPLAY_CLT', 'SNAC_SDK', 'SDK', 'PolyBaseJava', 'SQL_INST_MR', 'SQL_INST_MPY', 'SQL_SHARED_MPY', 'SQL_SHARED_MR') # cSpell: disable-line
+            17 = @('DQ', 'DQC', 'MDS') # Discontinued in SQL Server 2025 (17.x). See https://learn.microsoft.com/en-us/sql/database-engine/discontinued-database-engine-functionality-in-sql-server
         }
 
         <#

tests/Unit/Public/Test-SqlDscIsSupportedFeature.Tests.ps1

@@ -105,4 +105,30 @@ Describe 'Test-SqlDscIsSupportedFeature' -Tag 'Public' {
             Test-SqlDscIsSupportedFeature -Feature 'PolyBaseJava' -ProductVersion 14 | Should -BeFalse
         }
     }
+
+    Context 'When DQ, DQC, and MDS features are discontinued in SQL Server 2025 (17.x)' {
+        It 'Should return $true for feature <Feature> on major version 16' -ForEach @(
+            @{ Feature = 'DQ' }
+            @{ Feature = 'DQC' }
+            @{ Feature = 'MDS' }
+        ) {
+            Test-SqlDscIsSupportedFeature -Feature $Feature -ProductVersion 16 | Should -BeTrue
+        }
+
+        It 'Should return $false for feature <Feature> on major version 17' -ForEach @(
+            @{ Feature = 'DQ' }
+            @{ Feature = 'DQC' }
+            @{ Feature = 'MDS' }
+        ) {
+            Test-SqlDscIsSupportedFeature -Feature $Feature -ProductVersion 17 | Should -BeFalse
+        }
+
+        It 'Should return $false for feature <Feature> on major version 999 (future version)' -ForEach @(
+            @{ Feature = 'DQ' }
+            @{ Feature = 'DQC' }
+            @{ Feature = 'MDS' }
+        ) {
+            Test-SqlDscIsSupportedFeature -Feature $Feature -ProductVersion 999 | Should -BeFalse
+        }
+    }
 }