Fix localization strings (#2062)

johlju · web-flow · commit 666ef4eaba2b · 2025-03-01T11:10:05.000+01:00
diff --git a/.github/workflows/code-analysis-built-module.yml b/.github/workflows/code-analysis-built-module.yml
@@ -7,7 +7,7 @@ on:
     branches: [ main ]
   workflow_dispatch:
 
-# cSpell: ignore potatoqualitee codeql SARIF
+# cSpell: ignore codeql SARIF
 jobs:
   pssa:
     name: PSScriptAnalyzer
@@ -29,11 +29,24 @@ jobs:
         shell: powershell
         run: |
           dotnet-gitversion | ConvertFrom-Json
+      - name: Resolve dependencies
+        shell: powershell
+        run: |
+          Write-Information -MessageData 'Resolving dependencies.' -InformationAction 'Continue'
+          .\build.ps1 -ResolveDependency -Tasks 'noop'
+      # This is a workaround for the issue: https://github.com/PoshCode/ModuleBuilder/pull/136
+      - name: Patch ModuleBuilder
+        shell: powershell
+        run: |
+          Write-Information -MessageData 'Patching ModuleBuilder v3.1.7.' -InformationAction 'Continue'
+          .\build.ps1 -Tasks 'noop'
+          Install-PSResource -Name 'Viscalyx.Common' -Repository 'PSGallery' -TrustRepository -Quiet -Confirm:$false
+          Install-ModulePatch -Uri https://raw.githubusercontent.com/viscalyx/Viscalyx.Common/refs/heads/main/patches/ModuleBuilder_3.1.7_patch.json -Force
       - name: Build Module
         shell: powershell
         run: |
           Write-Information -MessageData 'Module is being built.' -InformationAction 'Continue'
-          .\build.ps1 -ResolveDependency -Tasks 'build'
+          .\build.ps1 -Tasks 'build'
       - name: Run PSScriptAnalyzer
         shell: powershell
         run: |
diff --git a/.github/workflows/code-analysis.yml b/.github/workflows/code-analysis.yml
@@ -7,7 +7,7 @@ on:
     branches: [ main ]
   workflow_dispatch:
 
-# cSpell: ignore potatoqualitee codeql SARIF
+# cSpell: ignore codeql SARIF
 jobs:
   pssa:
     name: PSScriptAnalyzer
@@ -29,11 +29,24 @@ jobs:
         shell: powershell
         run: |
           dotnet-gitversion | ConvertFrom-Json
+      - name: Resolve dependencies
+        shell: powershell
+        run: |
+          Write-Information -MessageData 'Resolving dependencies.' -InformationAction 'Continue'
+          .\build.ps1 -ResolveDependency -Tasks 'noop'
+      # This is a workaround for the issue: https://github.com/PoshCode/ModuleBuilder/pull/136
+      - name: Patch ModuleBuilder
+        shell: powershell
+        run: |
+          Write-Information -MessageData 'Patching ModuleBuilder v3.1.7.' -InformationAction 'Continue'
+          .\build.ps1 -Tasks 'noop'
+          Install-PSResource -Name 'Viscalyx.Common' -Repository 'PSGallery' -TrustRepository -Quiet -Confirm:$false
+          Install-ModulePatch -Uri https://raw.githubusercontent.com/viscalyx/Viscalyx.Common/refs/heads/main/patches/ModuleBuilder_3.1.7_patch.json -Force
       - name: Build Module
         shell: powershell
         run: |
-          Write-Information -MessageData 'Module is being built so that examples can be scanned.' -InformationAction 'Continue'
-          .\build.ps1 -ResolveDependency -Tasks 'build'
+          Write-Information -MessageData 'Module is being built.' -InformationAction 'Continue'
+          .\build.ps1 -Tasks 'build'
       - name: Run PSScriptAnalyzer
         shell: powershell
         run: |
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,8 +18,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fixed workaround for the GitHub Actions to support building module in Windows
+  PowerShell.
 - SqlServerDsc
   - Fix localization tests.
+- `SqlAudit`
+  - Fix localization strings in `Assert` method.
+- `Save-SqlDscSqlServerMediaFile`
+  - Fix localizations strings that used wrong keys.
+- `SqlConfiguration`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlDatabaseUser`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlMaxDop`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlMemory`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlReplication`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlRSSetup`
+  - Change the alias command to real command name, to pass HQRM tests.
+- `SqlServiceAccount`
+  - Change the alias command to real command name, to pass HQRM tests.
 
 ## [17.0.0] - 2024-09-30
 
diff --git a/source/Classes/020.SqlAudit.ps1 b/source/Classes/020.SqlAudit.ps1
@@ -547,12 +547,12 @@ class SqlAudit : SqlResourceBase
         # ReserveDiskSpace can only be used with MaximumFiles.
         if ($properties.Keys -contains 'ReserveDiskSpace' -and $properties.Keys -notcontains 'MaximumFiles')
         {
-            $errorMessage = $this.localizedData.BothFileSizePropertiesMustBeSet
+            $errorMessage = $this.localizedData.ReservDiskSpaceWithoutMaximumFiles
 
             New-InvalidArgumentException -ArgumentName 'ReserveDiskSpace' -Message $errorMessage
         }
 
-        # Test so that the path exist.
+        # Test so that the path exists.
         if ($properties.Keys -contains 'Path' -and -not (Test-Path -Path $properties.Path))
         {
             $errorMessage = $this.localizedData.PathInvalid -f $properties.Path
diff --git a/source/DSCResources/DSC_SqlConfiguration/DSC_SqlConfiguration.psm1 b/source/DSCResources/DSC_SqlConfiguration/DSC_SqlConfiguration.psm1
@@ -74,7 +74,7 @@ function Get-TargetResource
     if (-not $option)
     {
         $errorMessage = $script:localizedData.ConfigurationOptionNotFound -f $OptionName
-        New-InvalidArgumentException -ArgumentName 'OptionName' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'OptionName' -Message $errorMessage
     }
 
     Write-Verbose -Message (
@@ -157,7 +157,7 @@ function Set-TargetResource
     if (-not $option)
     {
         $errorMessage = $script:localizedData.ConfigurationOptionNotFound -f $OptionName
-        New-InvalidArgumentException -ArgumentName 'OptionName' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'OptionName' -Message $errorMessage
     }
 
     $option.ConfigValue = $OptionValue
diff --git a/source/DSCResources/DSC_SqlDatabaseUser/DSC_SqlDatabaseUser.psm1 b/source/DSCResources/DSC_SqlDatabaseUser/DSC_SqlDatabaseUser.psm1
@@ -687,37 +687,37 @@ function Assert-Parameters
     if ($UserType -ne 'Login' -and $PSBoundParameters.ContainsKey('LoginName'))
     {
         $errorMessage = $script:localizedData.LoginNameProvidedWithWrongUserType -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 
     if ($UserType -ne 'Certificate' -and $PSBoundParameters.ContainsKey('CertificateName'))
     {
         $errorMessage = $script:localizedData.CertificateNameProvidedWithWrongUserType -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 
     if ($UserType -ne 'AsymmetricKey' -and $PSBoundParameters.ContainsKey('AsymmetricKeyName'))
     {
         $errorMessage = $script:localizedData.AsymmetricKeyNameProvidedWithWrongUserType -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 
     if ($UserType -eq 'Login' -and -not $PSBoundParameters.ContainsKey('LoginName'))
     {
         $errorMessage = $script:localizedData.LoginUserTypeWithoutLoginName -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 
     if ($UserType -eq 'AsymmetricKey' -and -not $PSBoundParameters.ContainsKey('AsymmetricKeyName'))
     {
         $errorMessage = $script:localizedData.AsymmetricKeyUserTypeWithoutAsymmetricKeyName -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 
     if ($UserType -eq 'Certificate' -and -not $PSBoundParameters.ContainsKey('CertificateName'))
     {
         $errorMessage = $script:localizedData.CertificateUserTypeWithoutCertificateName -f $UserType
-        New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Action' -Message $errorMessage
     }
 }
 
diff --git a/source/DSCResources/DSC_SqlMaxDop/DSC_SqlMaxDop.psm1 b/source/DSCResources/DSC_SqlMaxDop/DSC_SqlMaxDop.psm1
@@ -144,7 +144,7 @@ function Set-TargetResource
                     if ($MaxDop)
                     {
                         $errorMessage = $script:localizedData.MaxDopParamMustBeNull
-                        New-InvalidArgumentException -ArgumentName 'MaxDop' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MaxDop' -Message $errorMessage
                     }
 
                     $targetMaxDop = Get-SqlDscDynamicMaxDop -SqlServerObject $sqlServerObject
@@ -302,7 +302,7 @@ function Test-TargetResource
                 if ($MaxDop)
                 {
                     $errorMessage = $script:localizedData.MaxDopParamMustBeNull
-                    New-InvalidArgumentException -ArgumentName 'MaxDop' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MaxDop' -Message $errorMessage
                 }
 
                 $MaxDop = Get-SqlDscDynamicMaxDop
diff --git a/source/DSCResources/DSC_SqlMemory/DSC_SqlMemory.psm1 b/source/DSCResources/DSC_SqlMemory/DSC_SqlMemory.psm1
@@ -166,13 +166,13 @@ function Set-TargetResource
                     if ($MaxMemory)
                     {
                         $errorMessage = $script:localizedData.MaxMemoryParamMustBeNull
-                        New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
                     }
 
                     if ($MaxMemoryPercent)
                     {
                         $errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull
-                        New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
                     }
 
                     $MaxMemory = Get-SqlDscDynamicMaxMemory
@@ -186,7 +186,7 @@ function Set-TargetResource
                     if ($PSBoundParameters.ContainsKey('MaxMemory') -and -not $MaxMemory)
                     {
                         $errorMessage = $script:localizedData.MaxMemoryParamMustNotBeNull
-                        New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
                     }
                 }
 
@@ -195,7 +195,7 @@ function Set-TargetResource
                     if ($MaxMemoryPercent)
                     {
                         $errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull
-                        New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
                     }
 
                     $sqlServerObject.Configuration.MaxServerMemory.ConfigValue = $MaxMemory
@@ -220,7 +220,7 @@ function Set-TargetResource
                     if ($MinMemoryPercent)
                     {
                         $errorMessage = $script:localizedData.MinMemoryPercentParamMustBeNull
-                        New-InvalidArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage
+                        New-ArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage
                     }
 
                     $sqlServerObject.Configuration.MinServerMemory.ConfigValue = $MinMemory
@@ -420,13 +420,13 @@ function Test-TargetResource
                 if ($MaxMemory)
                 {
                     $errorMessage = $script:localizedData.MaxMemoryParamMustBeNull
-                    New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
                 }
 
                 if ($MaxMemoryPercent)
                 {
                     $errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull
-                    New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
                 }
 
                 $MaxMemory = Get-SqlDscDynamicMaxMemory
@@ -440,7 +440,7 @@ function Test-TargetResource
                 if ($PSBoundParameters.ContainsKey('MaxMemory') -and -not $MaxMemory)
                 {
                     $errorMessage = $script:localizedData.MaxMemoryParamMustNotBeNull
-                    New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage
                 }
             }
 
@@ -449,7 +449,7 @@ function Test-TargetResource
                 if ($MaxMemory -and $MaxMemoryPercent)
                 {
                     $errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull
-                    New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage
                 }
 
                 if ($MaxMemoryPercent)
@@ -472,7 +472,7 @@ function Test-TargetResource
                 if ($MinMemory -and $MinMemoryPercent)
                 {
                     $errorMessage = $script:localizedData.MinMemoryPercentParamMustBeNull
-                    New-InvalidArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage
+                    New-ArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage
                 }
 
                 if ($MinMemoryPercent)
diff --git a/source/DSCResources/DSC_SqlRSSetup/DSC_SqlRSSetup.psm1 b/source/DSCResources/DSC_SqlRSSetup/DSC_SqlRSSetup.psm1
@@ -287,20 +287,20 @@ function Set-TargetResource
     if ($Action -eq 'Install' -and $PSBoundParameters.ContainsKey('Edition') -and $PSBoundParameters.ContainsKey('ProductKey'))
     {
         $errorMessage = $script:localizedData.EditionInvalidParameter
-        New-InvalidArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage
     }
 
     # Must either choose ProductKey or Edition, not none.
     if ($Action -eq 'Install' -and -not $PSBoundParameters.ContainsKey('Edition') -and -not $PSBoundParameters.ContainsKey('ProductKey'))
     {
         $errorMessage = $script:localizedData.EditionMissingParameter
-        New-InvalidArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage
     }
 
     if (-not (Test-Path -Path $SourcePath) -or (Get-Item -Path $SourcePath).Extension -ne '.exe')
     {
         $errorMessage = $script:localizedData.SourcePathNotFound -f $SourcePath
-        New-InvalidArgumentException -ArgumentName 'SourcePath' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'SourcePath' -Message $errorMessage
     }
 
     $InstanceName = $InstanceName.ToUpper()
diff --git a/source/DSCResources/DSC_SqlReplication/DSC_SqlReplication.psm1 b/source/DSCResources/DSC_SqlReplication/DSC_SqlReplication.psm1
@@ -232,7 +232,7 @@ function Set-TargetResource
     if (($DistributorMode -eq 'Remote') -and (-not $RemoteDistributor))
     {
         $errorMessage = $script:localizedData.NoRemoteDistributor
-        New-InvalidArgumentException -ArgumentName 'RemoteDistributor' -Message $errorMessage
+        New-ArgumentException -ArgumentName 'RemoteDistributor' -Message $errorMessage
     }
 
     $sqlMajorVersion = Get-SqlInstanceMajorVersion -InstanceName $InstanceName
diff --git a/source/DSCResources/DSC_SqlServiceAccount/DSC_SqlServiceAccount.psm1 b/source/DSCResources/DSC_SqlServiceAccount/DSC_SqlServiceAccount.psm1
@@ -322,7 +322,7 @@ function Get-ServiceObject
     if (($ServiceType -eq 'IntegrationServices') -and ([String]::IsNullOrEmpty($VersionNumber)))
     {
         $errorMessage = $script:localizedData.MissingParameter -f $ServiceType
-        New-InvalidArgumentException -Message $errorMessage -ArgumentName 'VersionNumber'
+        New-ArgumentException -Message $errorMessage -ArgumentName 'VersionNumber'
     }
 
     # Load the SMO libraries
@@ -578,7 +578,7 @@ function Get-SqlServiceName
     else
     {
         $errorMessage = $script:localizedData.UnknownServiceType -f $ServiceType
-        New-InvalidArgumentException -Message $errorMessage -ArgumentName 'ServiceType'
+        New-ArgumentException -Message $errorMessage -ArgumentName 'ServiceType'
     }
 
     if ([System.String]::IsNullOrEmpty($serviceNamingScheme))
diff --git a/source/Public/Save-SqlDscSqlServerMediaFile.ps1 b/source/Public/Save-SqlDscSqlServerMediaFile.ps1
@@ -112,8 +112,8 @@ function Save-SqlDscSqlServerMediaFile
     if ((Test-Path -Path $destinationFilePath))
     {
         $verboseDescriptionMessage = $script:localizedData.SqlServerMediaFile_Save_ShouldProcessVerboseDescription -f $destinationFilePath
-        $verboseWarningMessage = $script:localizedData.qlServerMedia_Save_ShouldProcessVerboseWarning -f $destinationFilePath
-        $captionMessage = $script:localizedData.qlServerMedia_Save_ShouldProcessCaption
+        $verboseWarningMessage = $script:localizedData.SqlServerMediaFile_Save_ShouldProcessVerboseWarning -f $destinationFilePath
+        $captionMessage = $script:localizedData.SqlServerMediaFile_Save_ShouldProcessCaption
 
         if ($PSCmdlet.ShouldProcess($verboseDescriptionMessage, $verboseWarningMessage, $captionMessage))
         {
@@ -125,8 +125,6 @@ function Save-SqlDscSqlServerMediaFile
         }
     }
 
-    Write-Verbose -Message ($script:localizedData.SqlServerMediaFile_Save_ShouldProcessVerboseDescription -f $destinationFilePath)
-
     [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
 
     $isExecutable = $false
@@ -156,6 +154,8 @@ function Save-SqlDscSqlServerMediaFile
         $ProgressPreference = 'SilentlyContinue'
     }
 
+    Write-Verbose -Message ($script:localizedData.SqlServerMediaFile_Save_DownloadingInformation -f $Url)
+
     # Download the URL content.
     Invoke-WebRequest -Uri $Url -OutFile $downloadedFilePath | Out-Null
 
diff --git a/tests/Unit/Classes/SqlAudit.Tests.ps1 b/tests/Unit/Classes/SqlAudit.Tests.ps1

Original file line number	Diff line number	Diff line change
`@@ -547,12 +547,12 @@ class SqlAudit : SqlResourceBase`
`547`	`547`	`# ReserveDiskSpace can only be used with MaximumFiles.`
`548`	`548`	`if ($properties.Keys -contains 'ReserveDiskSpace' -and $properties.Keys -notcontains 'MaximumFiles')`
`549`	`549`	`{`
`550`		`- $errorMessage = $this.localizedData.BothFileSizePropertiesMustBeSet`
	`550`	`+ $errorMessage = $this.localizedData.ReservDiskSpaceWithoutMaximumFiles`
`551`	`551`
`552`	`552`	`New-InvalidArgumentException -ArgumentName 'ReserveDiskSpace' -Message $errorMessage`
`553`	`553`	`}`
`554`	`554`
`555`		`- # Test so that the path exist.`
	`555`	`+ # Test so that the path exists.`
`556`	`556`	`if ($properties.Keys -contains 'Path' -and -not (Test-Path -Path $properties.Path))`
`557`	`557`	`{`
`558`	`558`	`$errorMessage = $this.localizedData.PathInvalid -f $properties.Path`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ function Get-TargetResource`
`74`	`74`	`if (-not $option)`
`75`	`75`	`{`
`76`	`76`	`$errorMessage = $script:localizedData.ConfigurationOptionNotFound -f $OptionName`
`77`		`- New-InvalidArgumentException -ArgumentName 'OptionName' -Message $errorMessage`
	`77`	`+ New-ArgumentException -ArgumentName 'OptionName' -Message $errorMessage`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`Write-Verbose -Message (`
`@@ -157,7 +157,7 @@ function Set-TargetResource`
`157`	`157`	`if (-not $option)`
`158`	`158`	`{`
`159`	`159`	`$errorMessage = $script:localizedData.ConfigurationOptionNotFound -f $OptionName`
`160`		`- New-InvalidArgumentException -ArgumentName 'OptionName' -Message $errorMessage`
	`160`	`+ New-ArgumentException -ArgumentName 'OptionName' -Message $errorMessage`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`$option.ConfigValue = $OptionValue`
Original file line number	Diff line number	Diff line change
`@@ -687,37 +687,37 @@ function Assert-Parameters`
`687`	`687`	`if ($UserType -ne 'Login' -and $PSBoundParameters.ContainsKey('LoginName'))`
`688`	`688`	`{`
`689`	`689`	`$errorMessage = $script:localizedData.LoginNameProvidedWithWrongUserType -f $UserType`
`690`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`690`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`691`	`691`	`}`
`692`	`692`
`693`	`693`	`if ($UserType -ne 'Certificate' -and $PSBoundParameters.ContainsKey('CertificateName'))`
`694`	`694`	`{`
`695`	`695`	`$errorMessage = $script:localizedData.CertificateNameProvidedWithWrongUserType -f $UserType`
`696`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`696`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`697`	`697`	`}`
`698`	`698`
`699`	`699`	`if ($UserType -ne 'AsymmetricKey' -and $PSBoundParameters.ContainsKey('AsymmetricKeyName'))`
`700`	`700`	`{`
`701`	`701`	`$errorMessage = $script:localizedData.AsymmetricKeyNameProvidedWithWrongUserType -f $UserType`
`702`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`702`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`703`	`703`	`}`
`704`	`704`
`705`	`705`	`if ($UserType -eq 'Login' -and -not $PSBoundParameters.ContainsKey('LoginName'))`
`706`	`706`	`{`
`707`	`707`	`$errorMessage = $script:localizedData.LoginUserTypeWithoutLoginName -f $UserType`
`708`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`708`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`709`	`709`	`}`
`710`	`710`
`711`	`711`	`if ($UserType -eq 'AsymmetricKey' -and -not $PSBoundParameters.ContainsKey('AsymmetricKeyName'))`
`712`	`712`	`{`
`713`	`713`	`$errorMessage = $script:localizedData.AsymmetricKeyUserTypeWithoutAsymmetricKeyName -f $UserType`
`714`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`714`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`715`	`715`	`}`
`716`	`716`
`717`	`717`	`if ($UserType -eq 'Certificate' -and -not $PSBoundParameters.ContainsKey('CertificateName'))`
`718`	`718`	`{`
`719`	`719`	`$errorMessage = $script:localizedData.CertificateUserTypeWithoutCertificateName -f $UserType`
`720`		`- New-InvalidArgumentException -ArgumentName 'Action' -Message $errorMessage`
	`720`	`+ New-ArgumentException -ArgumentName 'Action' -Message $errorMessage`
`721`	`721`	`}`
`722`	`722`	`}`
`723`	`723`
Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ function Set-TargetResource`
`144`	`144`	`if ($MaxDop)`
`145`	`145`	`{`
`146`	`146`	`$errorMessage = $script:localizedData.MaxDopParamMustBeNull`
`147`		`- New-InvalidArgumentException -ArgumentName 'MaxDop' -Message $errorMessage`
	`147`	`+ New-ArgumentException -ArgumentName 'MaxDop' -Message $errorMessage`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`$targetMaxDop = Get-SqlDscDynamicMaxDop -SqlServerObject $sqlServerObject`
`@@ -302,7 +302,7 @@ function Test-TargetResource`
`302`	`302`	`if ($MaxDop)`
`303`	`303`	`{`
`304`	`304`	`$errorMessage = $script:localizedData.MaxDopParamMustBeNull`
`305`		`- New-InvalidArgumentException -ArgumentName 'MaxDop' -Message $errorMessage`
	`305`	`+ New-ArgumentException -ArgumentName 'MaxDop' -Message $errorMessage`
`306`	`306`	`}`
`307`	`307`
`308`	`308`	`$MaxDop = Get-SqlDscDynamicMaxDop`
Original file line number	Diff line number	Diff line change
`@@ -166,13 +166,13 @@ function Set-TargetResource`
`166`	`166`	`if ($MaxMemory)`
`167`	`167`	`{`
`168`	`168`	`$errorMessage = $script:localizedData.MaxMemoryParamMustBeNull`
`169`		`- New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
	`169`	`+ New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`if ($MaxMemoryPercent)`
`173`	`173`	`{`
`174`	`174`	`$errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull`
`175`		`- New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
	`175`	`+ New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`$MaxMemory = Get-SqlDscDynamicMaxMemory`
`@@ -186,7 +186,7 @@ function Set-TargetResource`
`186`	`186`	`if ($PSBoundParameters.ContainsKey('MaxMemory') -and -not $MaxMemory)`
`187`	`187`	`{`
`188`	`188`	`$errorMessage = $script:localizedData.MaxMemoryParamMustNotBeNull`
`189`		`- New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
	`189`	`+ New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`
`@@ -195,7 +195,7 @@ function Set-TargetResource`
`195`	`195`	`if ($MaxMemoryPercent)`
`196`	`196`	`{`
`197`	`197`	`$errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull`
`198`		`- New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
	`198`	`+ New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`$sqlServerObject.Configuration.MaxServerMemory.ConfigValue = $MaxMemory`
`@@ -220,7 +220,7 @@ function Set-TargetResource`
`220`	`220`	`if ($MinMemoryPercent)`
`221`	`221`	`{`
`222`	`222`	`$errorMessage = $script:localizedData.MinMemoryPercentParamMustBeNull`
`223`		`- New-InvalidArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage`
	`223`	`+ New-ArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`$sqlServerObject.Configuration.MinServerMemory.ConfigValue = $MinMemory`
`@@ -420,13 +420,13 @@ function Test-TargetResource`
`420`	`420`	`if ($MaxMemory)`
`421`	`421`	`{`
`422`	`422`	`$errorMessage = $script:localizedData.MaxMemoryParamMustBeNull`
`423`		`- New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
	`423`	`+ New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
`424`	`424`	`}`
`425`	`425`
`426`	`426`	`if ($MaxMemoryPercent)`
`427`	`427`	`{`
`428`	`428`	`$errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull`
`429`		`- New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
	`429`	`+ New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
`430`	`430`	`}`
`431`	`431`
`432`	`432`	`$MaxMemory = Get-SqlDscDynamicMaxMemory`
`@@ -440,7 +440,7 @@ function Test-TargetResource`
`440`	`440`	`if ($PSBoundParameters.ContainsKey('MaxMemory') -and -not $MaxMemory)`
`441`	`441`	`{`
`442`	`442`	`$errorMessage = $script:localizedData.MaxMemoryParamMustNotBeNull`
`443`		`- New-InvalidArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
	`443`	`+ New-ArgumentException -ArgumentName 'MaxMemory' -Message $errorMessage`
`444`	`444`	`}`
`445`	`445`	`}`
`446`	`446`
`@@ -449,7 +449,7 @@ function Test-TargetResource`
`449`	`449`	`if ($MaxMemory -and $MaxMemoryPercent)`
`450`	`450`	`{`
`451`	`451`	`$errorMessage = $script:localizedData.MaxMemoryPercentParamMustBeNull`
`452`		`- New-InvalidArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
	`452`	`+ New-ArgumentException -ArgumentName 'MaxMemoryPercent' -Message $errorMessage`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`if ($MaxMemoryPercent)`
`@@ -472,7 +472,7 @@ function Test-TargetResource`
`472`	`472`	`if ($MinMemory -and $MinMemoryPercent)`
`473`	`473`	`{`
`474`	`474`	`$errorMessage = $script:localizedData.MinMemoryPercentParamMustBeNull`
`475`		`- New-InvalidArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage`
	`475`	`+ New-ArgumentException -ArgumentName 'MinMemoryPercent' -Message $errorMessage`
`476`	`476`	`}`
`477`	`477`
`478`	`478`	`if ($MinMemoryPercent)`
Original file line number	Diff line number	Diff line change
`@@ -287,20 +287,20 @@ function Set-TargetResource`
`287`	`287`	`if ($Action -eq 'Install' -and $PSBoundParameters.ContainsKey('Edition') -and $PSBoundParameters.ContainsKey('ProductKey'))`
`288`	`288`	`{`
`289`	`289`	`$errorMessage = $script:localizedData.EditionInvalidParameter`
`290`		`- New-InvalidArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage`
	`290`	`+ New-ArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`# Must either choose ProductKey or Edition, not none.`
`294`	`294`	`if ($Action -eq 'Install' -and -not $PSBoundParameters.ContainsKey('Edition') -and -not $PSBoundParameters.ContainsKey('ProductKey'))`
`295`	`295`	`{`
`296`	`296`	`$errorMessage = $script:localizedData.EditionMissingParameter`
`297`		`- New-InvalidArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage`
	`297`	`+ New-ArgumentException -ArgumentName 'Edition, ProductKey' -Message $errorMessage`
`298`	`298`	`}`
`299`	`299`
`300`	`300`	`if (-not (Test-Path -Path $SourcePath) -or (Get-Item -Path $SourcePath).Extension -ne '.exe')`
`301`	`301`	`{`
`302`	`302`	`$errorMessage = $script:localizedData.SourcePathNotFound -f $SourcePath`
`303`		`- New-InvalidArgumentException -ArgumentName 'SourcePath' -Message $errorMessage`
	`303`	`+ New-ArgumentException -ArgumentName 'SourcePath' -Message $errorMessage`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`$InstanceName = $InstanceName.ToUpper()`
Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ function Set-TargetResource`
`232`	`232`	`if (($DistributorMode -eq 'Remote') -and (-not $RemoteDistributor))`
`233`	`233`	`{`
`234`	`234`	`$errorMessage = $script:localizedData.NoRemoteDistributor`
`235`		`- New-InvalidArgumentException -ArgumentName 'RemoteDistributor' -Message $errorMessage`
	`235`	`+ New-ArgumentException -ArgumentName 'RemoteDistributor' -Message $errorMessage`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`$sqlMajorVersion = Get-SqlInstanceMajorVersion -InstanceName $InstanceName`