Refactor error handling in Get-SqlDscRSPackage to simplify exception creation and update variable names in tests for consistency

Author: johlju

source/Public/Get-SqlDscRSPackage.ps1

@@ -105,7 +105,7 @@ function Get-SqlDscRSPackage
 
             $PSCmdlet.ThrowTerminatingError(
                 [System.Management.Automation.ErrorRecord]::new(
-                    [System.InvalidOperationException]::new($errorMessage),
+                    $errorMessage,
                     'GSDRSP0001',
                     [System.Management.Automation.ErrorCategory]::ObjectNotFound,
                     $Package
@@ -146,7 +146,7 @@ function Get-SqlDscRSPackage
 
                 $PSCmdlet.ThrowTerminatingError(
                     [System.Management.Automation.ErrorRecord]::new(
-                        [System.InvalidOperationException]::new($errorMessage),
+                        $errorMessage,
                         'GSDRSP0002',
                         [System.Management.Automation.ErrorCategory]::InvalidArgument,
                         $FilePath

tests/Unit/Public/Get-SqlDscRSPackage.Tests.ps1

@@ -24,15 +24,15 @@ BeforeDiscovery {
 }
 
 BeforeAll {
-    $script:dscModuleName = 'SqlServerDsc'
+    $script:moduleName = 'SqlServerDsc'
 
     $env:SqlServerDscCI = $true
 
-    Import-Module -Name $script:dscModuleName -Force -ErrorAction 'Stop'
+    Import-Module -Name $script:moduleName -Force -ErrorAction 'Stop'
 
-    $PSDefaultParameterValues['InModuleScope:ModuleName'] = $script:dscModuleName
-    $PSDefaultParameterValues['Mock:ModuleName'] = $script:dscModuleName
-    $PSDefaultParameterValues['Should:ModuleName'] = $script:dscModuleName
+    $PSDefaultParameterValues['InModuleScope:ModuleName'] = $script:moduleName
+    $PSDefaultParameterValues['Mock:ModuleName'] = $script:moduleName
+    $PSDefaultParameterValues['Should:ModuleName'] = $script:moduleName
 }
 
 AfterAll {
@@ -41,7 +41,7 @@ AfterAll {
     $PSDefaultParameterValues.Remove('Should:ModuleName')
 
     # Unload the module being tested so that it doesn't impact any other tests.
-    Get-Module -Name $script:dscModuleName -All | Remove-Module -Force
+    Get-Module -Name $script:moduleName -All | Remove-Module -Force
 
     Remove-Item -Path 'env:SqlServerDscCI'
 }